On Thu, Nov 11, 2021 at 08:27:21PM +0900, SASANO Takayoshi wrote:
> Hi,
>
> Recently I tried to crossbuild for arm64 on amd64.
> I found "TARGET=arm64 make cross-tools" stops when building libfido2.
>
> libfido2 requires libz but this is not built yet at that time.
> lib/Makefile needs to tweak like this.
>
> openbsd-current-vm# diff -uNpr Makefile~ Makefile
> --- Makefile~ Sun Jan 3 05:04:36 2021
> +++ Makefile Thu Nov 11 19:47:42 2021
> @@ -2,10 +2,10 @@
> # $NetBSD: Makefile,v 1.20.4.1 1996/06/14 17:22:38 cgd Exp $
>
> SUBDIR= csu libagentx libarch libc libcbor libcrypto libcurses \
> - libedit libelf libevent libexpat \
> + libedit libelf libevent libexpat libz \
> libfido2 libform libfuse libkeynote libkvm libl libm libmenu \
> libossaudio libpanel libpcap libradius librthread \
> librpcsvc libskey libsndio libssl libtls libusbhid \
> - libutil liby libz
> + libutil liby
>
> .include <bsd.subdir.mk>
> openbsd-current-vm#
>
> It works good, but I think there is better build order.
>
> --
> SASANO Takayoshi (JG1UAA) <u...@mx5.nisiq.net>
>
Hi,
I just had the same issue and after a short discussion it seems like
it's a better idea to separate libfido2 into a separate line to show
that it should be built at the end due to having libz as dependency.
Comments? ok?
Patrick
diff --git a/lib/Makefile b/lib/Makefile
index 7f95cb1e3e7..1f1586b0518 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -3,9 +3,10 @@
SUBDIR= csu libagentx libarch libc libcbor libcrypto libcurses \
libedit libelf libevent libexpat \
- libfido2 libform libfuse libkeynote libkvm libl libm libmenu \
+ libform libfuse libkeynote libkvm libl libm libmenu \
libossaudio libpanel libpcap libradius librthread \
librpcsvc libskey libsndio libssl libtls libusbhid \
libutil liby libz
+SUBDIR+=libfido2
.include <bsd.subdir.mk>
