Re: [External] : soqinsque(): replace 'DIAGNOSTIC' block by KASSERT(9)

2021-10-26 Thread Alexandr Nedvedicky
On Tue, Oct 26, 2021 at 11:55:23PM +0300, Vitaliy Makkoveev wrote: > Just for consistency with the rest of kern/uipc_socket2.c looks OK to me. sashan > > Index: sys/kern/uipc_socket2.c > === > RCS file: /cvs/src/sys/kern/uipc_socket

Re: fix uchcom(4) handling of parity and character size config

2021-10-26 Thread Felix Kronlage-Dammers
On Wed, Oct 27, 2021 at 06:46:38AM +1000, David Gwynne wrote: Hi David, > this ports the functionality to support configuring parity and char size > masks from netbsd src/sys/dev/usb/uchcom.c r1.26. part of that change > including tweaks to uchcom_reset_chip, which was then changed in r1.28 > bac

demystify vport(4) in vport(4) and ifconfigt(8)

2021-10-26 Thread Solene Rapenne
I tried to figure out how to use veb interfaces but the man page wasn't obvious in regards to the "vport" thing. It turns out it's a kind of interface that can be created with ifconfig. I think we should make this clearer. Because ifconfig(8) mentions many type of interfaces I've searched for "vp

Re: demystify vport(4) in vport(4) and ifconfigt(8)

2021-10-26 Thread David Gwynne
On Tue, Oct 26, 2021 at 09:18:30PM +0200, Solene Rapenne wrote: > I tried to figure out how to use veb interfaces but the man page > wasn't obvious in regards to the "vport" thing. It turns out it's > a kind of interface that can be created with ifconfig. > > I think we should make this clearer.

diff: improve legibility of structs in several manpages

2021-10-26 Thread Jan Klemkow
Hello, This diff harmonises the indentation of struct members and comments in several manpages. Also fixes line wraps of comments on 80 column terminals. General uses tabs for general indentation and 4 spaces on tight spots. Also uses extra space to align pointers and non-pointers as we do this

soqinsque(): replace 'DIAGNOSTIC' block by KASSERT(9)

2021-10-26 Thread Vitaliy Makkoveev
Just for consistency with the rest of kern/uipc_socket2.c Index: sys/kern/uipc_socket2.c === RCS file: /cvs/src/sys/kern/uipc_socket2.c,v retrieving revision 1.113 diff -u -p -r1.113 uipc_socket2.c --- sys/kern/uipc_socket2.c 26 J

fix uchcom(4) handling of parity and character size config

2021-10-26 Thread David Gwynne
i bought some random usb to rs485 serial adapters so i can talk modbus to a thing, but then discovered i can't talk to the modbus thing because uchcom doesn't support configuring parity. this ports the functionality to support configuring parity and char size masks from netbsd src/sys/dev/usb/uchc

Re: demystify vport(4) in vport(4) and ifconfigt(8)

2021-10-26 Thread Sebastian Benoit
Solene Rapenne(sol...@perso.pw) on 2021.10.26 21:18:30 +0200: > I tried to figure out how to use veb interfaces but the man page > wasn't obvious in regards to the "vport" thing. It turns out it's > a kind of interface that can be created with ifconfig. > > I think we should make this clearer. >

Re: route.8: nameserver command is not resolvd(8) specific

2021-10-26 Thread Sebastian Benoit
Klemens Nanni(k...@openbsd.org) on 2021.10.26 15:30:17 +: > On Tue, Oct 26, 2021 at 04:06:20PM +0100, Jason McIntyre wrote: > > On Tue, Oct 26, 2021 at 08:57:40AM -0600, Theo de Raadt wrote: > > > Jason McIntyre wrote: > > > > > > > On Tue, Oct 26, 2021 at 12:21:52PM +, Klemens Nanni wrot

Re: upd(4) page fault since 7.0

2021-10-26 Thread Anton Lindqvist
On Tue, Oct 26, 2021 at 05:58:12PM +0200, Damien Couderc wrote: > Le 26/10/2021 à 16:11, Anton Lindqvist a écrit : > > On Tue, Oct 26, 2021 at 09:50:41AM +0200, Damien Couderc wrote: > > > Le 24/10/2021 à 21:45, Anton Lindqvist a écrit : > > > > On Sun, Oct 24, 2021 at 03:03:01PM +0200, Damien Coud

Re: ixl(4): add rx/tx checksum offloading

2021-10-26 Thread Jan Klemkow
On Tue, Oct 26, 2021 at 05:17:55PM +1000, Jonathan Matthew wrote: > First of all, thanks for looking at this, I forgot we hadn't done offloads > for ixl(4) yet. You're welcome. > In the case of ixl(4), the driver has to tell the nic the length of each of > the > packet headers, so it should also

ipsec tdb walk lock order

2021-10-26 Thread Alexander Bluhm
Hi, There is an lock ordering problem with the new tdb_sadb_mtx mutex. panic: acquiring blockable sleep lock with spinlock or critical section h eld (kernel_lock) &kernel_lock Stopped at db_enter+0x4: popl%ebp TIDPIDUID PRFLAGS PFLAGS CPU COMMAND *270299 46739

Re: rpki-client adjust tal parse to the BIO free world

2021-10-26 Thread Job Snijders
OK job@ On Tue, Oct 26, 2021 at 05:43:32PM +0200, Claudio Jeker wrote: > This is part 3 of the BIO removal. Switch tal_parse to pass a file buffer > like all other callers. The parent process can now just use load_file() > and pass that buffer to the parser. From there on the magic just happens. >

Re: upd(4) page fault since 7.0

2021-10-26 Thread Damien Couderc
Le 26/10/2021 à 16:11, Anton Lindqvist a écrit : On Tue, Oct 26, 2021 at 09:50:41AM +0200, Damien Couderc wrote: Le 24/10/2021 à 21:45, Anton Lindqvist a écrit : On Sun, Oct 24, 2021 at 03:03:01PM +0200, Damien Couderc wrote: Hi, I got a page fault with upd(4) since 7.0. The problem began wit

Re: route.8: nameserver command is not resolvd(8) specific

2021-10-26 Thread Jason McIntyre
certainly ok by me. jmc On 26 October 2021 16:30:17 BST, Klemens Nanni wrote: >On Tue, Oct 26, 2021 at 04:06:20PM +0100, Jason McIntyre wrote: >> On Tue, Oct 26, 2021 at 08:57:40AM -0600, Theo de Raadt wrote: >> > Jason McIntyre wrote: >> > >> > > On Tue, Oct 26, 2021 at 12:21:52PM +, Kleme

rpki-client adjust tal parse to the BIO free world

2021-10-26 Thread Claudio Jeker
This is part 3 of the BIO removal. Switch tal_parse to pass a file buffer like all other callers. The parent process can now just use load_file() and pass that buffer to the parser. From there on the magic just happens. -- :wq Claudio Index: encoding.c ===

Re: route.8: nameserver command is not resolvd(8) specific

2021-10-26 Thread Todd C . Miller
On Tue, 26 Oct 2021 15:30:17 -, Klemens Nanni wrote: > > i think either saying to the route socket or broadcast are clear and > > would read better. > > The latter is great, thanks. OK millert@ - todd

Re: route.8: nameserver command is not resolvd(8) specific

2021-10-26 Thread Klemens Nanni
On Tue, Oct 26, 2021 at 04:06:20PM +0100, Jason McIntyre wrote: > On Tue, Oct 26, 2021 at 08:57:40AM -0600, Theo de Raadt wrote: > > Jason McIntyre wrote: > > > > > On Tue, Oct 26, 2021 at 12:21:52PM +, Klemens Nanni wrote: > > > > While designed to populate resolv.conf(5), there is nothing r

Re: route.8: nameserver command is not resolvd(8) specific

2021-10-26 Thread Jason McIntyre
On Tue, Oct 26, 2021 at 08:57:40AM -0600, Theo de Raadt wrote: > Jason McIntyre wrote: > > > On Tue, Oct 26, 2021 at 12:21:52PM +, Klemens Nanni wrote: > > > While designed to populate resolv.conf(5), there is nothing resolvd(8) > > > specific about the route message route(8) sends. > > > >

Re: route.8: nameserver command is not resolvd(8) specific

2021-10-26 Thread Theo de Raadt
Jason McIntyre wrote: > On Tue, Oct 26, 2021 at 12:21:52PM +, Klemens Nanni wrote: > > While designed to populate resolv.conf(5), there is nothing resolvd(8) > > specific about the route message route(8) sends. > > > > At least unwind(8) consumes and acts upon it; there might as well be > >

Re: route.8: nameserver command is not resolvd(8) specific

2021-10-26 Thread Jason McIntyre
On Tue, Oct 26, 2021 at 12:21:52PM +, Klemens Nanni wrote: > While designed to populate resolv.conf(5), there is nothing resolvd(8) > specific about the route message route(8) sends. > > At least unwind(8) consumes and acts upon it; there might as well be > other programs in ports that do suc

packages-specs(7): minor typos

2021-10-26 Thread Maxim
Two little fixes in packages-specs(7). diff --git share/man/man7/packages-specs.7 share/man/man7/packages-specs.7 index 8154206c7..9b3d7b5e7 100644 --- share/man/man7/packages-specs.7 +++ share/man/man7/packages-specs.7 @@ -71,7 +71,7 @@ In case there are substantial changes in the package, a pat

Re: upd(4) page fault since 7.0

2021-10-26 Thread Anton Lindqvist
On Tue, Oct 26, 2021 at 09:50:41AM +0200, Damien Couderc wrote: > Le 24/10/2021 à 21:45, Anton Lindqvist a écrit : > > On Sun, Oct 24, 2021 at 03:03:01PM +0200, Damien Couderc wrote: > > > Hi, > > > I got a page fault with upd(4) since 7.0. > > > > > > The problem began with the last revision of u

unwind.conf.5: Zap duplicate bits, mention route nameserver

2021-10-26 Thread Klemens Nanni
Mentioning `route nameserver' relevance made it obvious that the `preference' block duplicates lots of information and I despise adding to that. So rearrange the list of types such that conceptually related ones are subsequent and can reference each user to not repeat things. This looks like this

Fwd: futex(2) not working in inherited mmap'd anon memory

2021-10-26 Thread Amit Kulkarni
-- Forwarded message - From: Thomas Munro Date: Tue, Oct 26, 2021 at 5:36 AM Subject: futex(2) not working in inherited mmap'd anon memory To: Hello, When I do mmap(MAP_ANONYMOUS | MAP_SHARED) and then fork(), it seems that futex(2) wakeups are not delivered between child and p

route.8: nameserver command is not resolvd(8) specific

2021-10-26 Thread Klemens Nanni
While designed to populate resolv.conf(5), there is nothing resolvd(8) specific about the route message route(8) sends. At least unwind(8) consumes and acts upon it; there might as well be other programs in ports that do such things, so describe it generically while going into required detail for

remove more BIO from rpki-client part 2

2021-10-26 Thread Claudio Jeker
This switches the cert parser to use d2i_X509 instead of the BIO versions. -- :wq Claudio Index: cert.c === RCS file: /cvs/src/usr.sbin/rpki-client/cert.c,v retrieving revision 1.40 diff -u -p -r1.40 cert.c --- cert.c 23 Oct 20

UNIX sockets: use vnode(9) lock to protect `v_socket' dereference

2021-10-26 Thread Vitaliy Makkoveev
Another step to make UNIX sockets locking fine grained. The listening socket has the references from file descriptors layer and from the vnode(9) layer. This means when we close(2)'ing such socket it still referenced by concurrent thread through connect(2) path. When we bind(2) UNIX socket we lin

libutil/ber: Bump BER_MAX_OID_LEN one last time

2021-10-26 Thread Martijn van Duren
Last time when this value was bumped because I ran into SNMP problems walking net-snmp because of string based indices in USM. This time I want to bump them one more time because I found the definition of the upper bound RFC 2578 section 7.1.3. This makes it easier to parse agentx messages, which a

remove more BIO from rpki-client

2021-10-26 Thread Claudio Jeker
I want to be able to pass a buffer to the various parser functions instead of a filename. This is in preparation for supporting rpki-client -f somefile This diff switches CMS and CRL to their regular d2i versions. The cert files will follow in the next diff. -- :wq Claudio Index: cms.c =

Re: upd(4) page fault since 7.0

2021-10-26 Thread Damien Couderc
Le 24/10/2021 à 21:45, Anton Lindqvist a écrit : On Sun, Oct 24, 2021 at 03:03:01PM +0200, Damien Couderc wrote: Hi, I got a page fault with upd(4) since 7.0. The problem began with the last revision of upd.c (1.30): === RCS file:

Re: ixl(4): add rx/tx checksum offloading

2021-10-26 Thread Jonathan Matthew
Hi Jan, First of all, thanks for looking at this, I forgot we hadn't done offloads for ixl(4) yet. On Mon, Oct 25, 2021 at 05:27:28PM +0200, Jan Klemkow wrote: > On Fri, Oct 22, 2021 at 03:39:01PM +0200, Hrvoje Popovski wrote: > > On 22.10.2021. 13:39, Jan Klemkow wrote: > > > Thats because, you