On Wed, Oct 27, 2021 at 06:46:38AM +1000, David Gwynne wrote: Hi David,
> this ports the functionality to support configuring parity and char size > masks from netbsd src/sys/dev/usb/uchcom.c r1.26. part of that change > including tweaks to uchcom_reset_chip, which was then changed in r1.28 > back to what we already have, so i left that chunk out. > > ive tested this talking to a device at 19200 with cs8 and even > parity. more tests would be appreciated to make sure i haven't > broken existing use functionality. I use uchcom(4) to connect with 115200 to the pinebook pro. I see no regressions with your diff, works fine. felix
