Re: ifconfig and MPLS: document commands and ioctls, SIOCDELLABEL inconsistency

2021-03-15 Thread Klemens Nanni
On Sat, Mar 13, 2021 at 11:45:30PM +0100, Claudio Jeker wrote: > On Sat, Mar 13, 2021 at 11:31:05PM +0100, Klemens Nanni wrote: > > First off: I've never used mpe(4), mpw(4) or mpip(4); this occured to > > me while looking at ifconfig.{c,8} in general. > > > > > > 1. bug: ifconfig(8) forgets to

Re: diff: efiboot: alignment for media which has IoAlign > 1

2021-03-15 Thread Mark Kettenis
> Date: Thu, 11 Mar 2021 15:05:11 +0900 (JST) > From: YASUOKA Masahiko > > On Wed, 10 Mar 2021 13:15:58 +0100 (CET) > Mark Kettenis wrote: > >> On Wed, 10 Mar 2021 20:35:41 +0900 (JST) > >> YASUOKA Masahiko wrote: > >> > efiboot cannot load the kernel properly on some machines if booted > >> >

Re: [PATCH v3 (resend)] tee: Add -q, --quiet, --silent option to not write to stdout

2021-03-15 Thread Alex Henrie
On Mon, Mar 15, 2021 at 11:42 AM Alex Henrie wrote: > > On Sun, Mar 14, 2021 at 3:44 AM Alejandro Colomar (man-pages) > wrote: > > > > On 1/25/21 5:03 AM, Bernhard Voelker wrote: > > > OTOH I understand that there's a little gap in the tool landscape. > > > Astonishingly, there doesn't seem to ex

Re: ixl(4): add ID for X710 10G SFP+

2021-03-15 Thread Mark Kettenis
> Date: Mon, 15 Mar 2021 19:25:56 +0100 > From: Patrick Wildt > > Am Mon, Mar 15, 2021 at 08:59:05AM +0100 schrieb Jan Klemkow: > > On Mon, Mar 15, 2021 at 01:35:28AM -0600, Theo de Raadt wrote: > > > My comments are about the "text name", which goes into every kernel > > > anyone compiles. > > >

Re: ixl(4): add ID for X710 10G SFP+

2021-03-15 Thread Patrick Wildt
Am Mon, Mar 15, 2021 at 08:59:05AM +0100 schrieb Jan Klemkow: > On Mon, Mar 15, 2021 at 01:35:28AM -0600, Theo de Raadt wrote: > > My comments are about the "text name", which goes into every kernel > > anyone compiles. > > > > It should be as short as possible. > > Sorry, I missed that point. >

Re: [PATCH v3 (resend)] tee: Add -q, --quiet, --silent option to not write to stdout

2021-03-15 Thread Alex Henrie
On Sun, Mar 14, 2021 at 3:44 AM Alejandro Colomar (man-pages) wrote: > > On 1/25/21 5:03 AM, Bernhard Voelker wrote: > > OTOH I understand that there's a little gap in the tool landscape. > > Astonishingly, there doesn't seem to exist a trivial tool to redirect > > from standard input (or any othe

Re: ixl(4): add ID for X710 10G SFP+

2021-03-15 Thread Jan Klemkow
On Mon, Mar 15, 2021 at 01:35:28AM -0600, Theo de Raadt wrote: > My comments are about the "text name", which goes into every kernel > anyone compiles. > > It should be as short as possible. Sorry, I missed that point. > But the reason why 10G is incorrect is because surely the port can > accept

Re: ixl(4): add ID for X710 10G SFP+

2021-03-15 Thread Jan Klemkow
On Sun, Mar 14, 2021 at 12:39:42PM -0600, Theo de Raadt wrote: > > +product INTEL X710_10G_SFP_2 0x104e X710 10G SFP+ > > You only need: > > X710 SFP+ > > Adding 10G is incorrect. OK? Thanks, Jan Index: if_ixl.c === RCS file:

Re: potentially uninitialized string printed by vmd

2021-03-15 Thread James Cook
> The array "base" which is passed to log_warnx might be uninitialized: > virtio_get_base doesn't necessarily touch it if it returns -1. Maybe it > would be better just omit base from the output, e.g. > > log_warnx("vm \"%s\" unable to read " > "base for disk %s", vcp->vcp_name, >

potentially uninitialized string printed by vmd

2021-03-15 Thread James Cook
Hi tech@, I'm looking at this code starting at line 390 of usr.sbin/vmd/config.c: n = virtio_get_base(diskfds[i][j], base, sizeof(base), vmc->vmc_disktypes[i], path); if (n == 0) break; if (n == -1) { log_warnx("vm \"%s\" unable

patch: new fix for vmctl create

2021-03-15 Thread James Cook
Hi tech@, The below patch removes calls to realpath(3) when looking up a qcow2 base image. Previous thread: https://marc.info/?t=16156249642&r=1&w=2 In short, the calls were failing inside vmctl, because of unveil. The other thread has alternative solutions but I think this is simplest. I in

uvideo(4) new quirk flag UVIDEO_FLAG_NOATTACH

2021-03-15 Thread Marcus Glocker
martijn@ has recently reported that in his machine he has two cams of which one is doing IR, which isn't really supported by uvideo(4). This IR device attaches always first as uvideo0, so he needs to swap that regularly with his working cam which by default attaches to uvideo1. I came up with a ne