Give support to the 2019 Apple's MBP (13-inch)

2020-06-10 Thread Romero Pérez , Abel
Hello, I tried to install stable flavor from USB on the MBP 13-inch 2019, with no luck, and the following issues: 1. Booting kernel messages Centered on the screen, with a very small size, not working well for reading. 2. After booting, keyboard not working I had to connect an USB KB. 3.

Re: userland clock_gettime proof of concept

2020-06-10 Thread Theo de Raadt
Christian Weisgerber wrote: > Paul Irofti: > > > This iteration of the diff adds bounds checking for tk_user and moves > > the usertc.c stub to every arch in libc as recommanded by deraadt@. > > It also fixes a gettimeofday issue reported by cheloha@ and tb@. > > Additionally, it changes struct

Re: userland clock_gettime proof of concept

2020-06-10 Thread Christian Weisgerber
Paul Irofti: > This iteration of the diff adds bounds checking for tk_user and moves > the usertc.c stub to every arch in libc as recommanded by deraadt@. > It also fixes a gettimeofday issue reported by cheloha@ and tb@. Additionally, it changes struct timekeep in an incompatible way. ;-) A user

Re: netstat -R: list rdomains with associated ifs and tables

2020-06-10 Thread Stuart Henderson
It's useful information, I like it. (I preferred it with the route count, but I agree, it's hard on the system if there's a full DFZ table). One thing though - > twister ..in/netstat$ obj/netstat -R > Rdomain 0 > Interfaces: lo0 iwm0 re0 enc0 pflog0 > Routing tables: 0 6 7 77 When there are

Re: userland clock_gettime proof of concept

2020-06-10 Thread Christian Weisgerber
Paul Irofti: > > This iteration of the diff adds bounds checking for tk_user and moves > > the usertc.c stub to every arch in libc as recommanded by deraadt@. > > It also fixes a gettimeofday issue reported by cheloha@ and tb@. > > Forgot to add armv7 tk_nclock entries. Noticed by benno@, thanks!

Re: netstat -R: list rdomains with associated ifs and tables

2020-06-10 Thread Sebastian Benoit
Remi Locherer(remi.loche...@relo.ch) on 2020.06.10 22:16:36 +0200: > On Tue, Jun 09, 2020 at 10:02:06AM +0200, Remi Locherer wrote: > > On Tue, Jun 09, 2020 at 09:17:31AM +0200, Claudio Jeker wrote: > > > On Tue, Jun 09, 2020 at 08:44:42AM +0200, Remi Locherer wrote: > > > > On Mon, Jun 08, 2020 at

Re: Call FRELE() without fdplock in dup*(2)

2020-06-10 Thread Vitaliy Makkoveev
> On 10 Jun 2020, at 17:34, Visa Hankala wrote: > > A while ago, finishdup() was changed to release fdplock before calling > closef() to avoid potential lock order problems in the file close path. > However, the dup* code can still invoke that path with fdplock held > through FRELE(). That is fix

Re: netstat -R: list rdomains with associated ifs and tables

2020-06-10 Thread Remi Locherer
On Tue, Jun 09, 2020 at 10:02:06AM +0200, Remi Locherer wrote: > On Tue, Jun 09, 2020 at 09:17:31AM +0200, Claudio Jeker wrote: > > On Tue, Jun 09, 2020 at 08:44:42AM +0200, Remi Locherer wrote: > > > On Mon, Jun 08, 2020 at 10:10:17PM +0200, Remi Locherer wrote: > > > > Hi, > > > > > > > > to my

Re: libkern: ffs() for arm64, powerpc, powerpc64

2020-06-10 Thread Mark Kettenis
> Date: Wed, 10 Jun 2020 20:08:31 +0200 > From: Christian Weisgerber > > Next try. > Optimized versions for kernel ffs(3) on arm64, powerpc, powerpc64. > > I have tested arm64; cwen@ has tested powerpc in userland. > powerpc64 is copied from powerpc. > > ok? ok kettenis@ > Index: lib/libkern/

Re: Call FRELE() without fdplock in dup*(2)

2020-06-10 Thread Anton Lindqvist
On Wed, Jun 10, 2020 at 02:34:00PM +, Visa Hankala wrote: > A while ago, finishdup() was changed to release fdplock before calling > closef() to avoid potential lock order problems in the file close path. > However, the dup* code can still invoke that path with fdplock held > through FRELE(). T

Re: libkern: ffs() for arm64, powerpc, powerpc64

2020-06-10 Thread Christian Weisgerber
Next try. Optimized versions for kernel ffs(3) on arm64, powerpc, powerpc64. I have tested arm64; cwen@ has tested powerpc in userland. powerpc64 is copied from powerpc. ok? Index: lib/libkern/arch/arm64/ffs.S === RCS file: lib/lib

Call FRELE() without fdplock in dup*(2)

2020-06-10 Thread Visa Hankala
A while ago, finishdup() was changed to release fdplock before calling closef() to avoid potential lock order problems in the file close path. However, the dup* code can still invoke that path with fdplock held through FRELE(). That is fixed by the diff below. (In principle, the FRELE(fp, p) could

Re: code style questions

2020-06-10 Thread Marc Espie
On Wed, Jun 10, 2020 at 05:38:36PM +1000, Jonathan Gray wrote: > On Wed, Jun 10, 2020 at 09:19:47AM +0200, Martin Pieuchot wrote: > > On 09/06/20(Tue) 20:19, jo...@armadilloaerospace.com wrote: > > > Looking for some guidance to avoid proposing any unpopular diffs. > > > > > > Style(9) says not to

iwx: increase command queue size

2020-06-10 Thread Stefan Sperling
Increase iwx(4) firmware command queue size. Otherwise, the firmware will eventually send spurious "command done" notifications for commands which were completed successfully earlier (which looks like a ring overflow) and then crash with a fatal error. This is required to get -48 firmware to work

iwx: do not load the firmware twice

2020-06-10 Thread Stefan Sperling
Firmware loading code inherited from iwm(4) loads firmware twice: Once to load the 'INIT' (boot) device firmware, and a second time to load the RT (run-time) device firmware. Both of these firmware images are part of the single firmware file in /etc/firmware. With iwx(4) devices only a single load

iwx: handle regulatory domain updates

2020-06-10 Thread Stefan Sperling
(This patch depends on the iwx NVM parser patch which I just sent out previously. This patch won't apply otherwise.) iwx(4) devices have a hardware component that can detect which country it is running in. The firmware will then inform the driver about the auto-detected regulatory domain. Current

iwx: stop reading NVM directly

2020-06-10 Thread Stefan Sperling
The iwx(4) firmware offers a command which reads data stored in non-volative memory of the device. Currently the driver still parses this data directly with a parser inherited from iwm(4). Use the command instead, which matches what Linux does on this hardware and is future-proof. The old parser i

Re: code style questions

2020-06-10 Thread Jonathan Gray
On Wed, Jun 10, 2020 at 09:19:47AM +0200, Martin Pieuchot wrote: > On 09/06/20(Tue) 20:19, jo...@armadilloaerospace.com wrote: > > Looking for some guidance to avoid proposing any unpopular diffs. > > > > Style(9) says not to use static on file-local functions in the > > kernel, because it interfe

Re: Diff for www:openssh/users.html

2020-06-10 Thread Anders Andersson
On Wed, Jun 10, 2020 at 3:23 AM wrote: > > Hi, > > Here a diff for www page: openssh/users.html > > Change URLs to those on archive.org (and others sites) > > Right? It says "The following operating systems and products are known to integrate OpenSSH into the base system.". If a system no longer

Re: code style questions

2020-06-10 Thread Martin Pieuchot
On 09/06/20(Tue) 20:19, jo...@armadilloaerospace.com wrote: > Looking for some guidance to avoid proposing any unpopular diffs. > > Style(9) says not to use static on file-local functions in the > kernel, because it interferes with the debugger. They still show up > on some functions today; is th

Re: code style questions

2020-06-10 Thread Marc Espie
On Tue, Jun 09, 2020 at 08:19:53PM -0700, jo...@armadilloaerospace.com wrote: > Also, style(9) says that prototypes should not have variable names > associated with the types. I try to use good names in the headers > for documentation purposes; what is the thinking behind the rule? function names