bug? in getopt(3) / possible [PATCH]

2020-03-11 Thread 0xef967c36
$ cat > opts.c <<'EOT' && cc -Wall -W opts.c -o opts #include #include int main(int ac, char **av){ int c, i; while((c = getopt(ac, av, "q")) != -1) if(c != '?' && c != ':') printf("OPT %c\n", c); for(i = optind; i < ac; i++) printf("%s\n", av[i]); } EOT $

Fix a panic with unlocked soclose()

2020-03-11 Thread Visa Hankala
jcs@ has reported the following panic which started appearing as a consequence of the recent file close unlocking: panic: kernel diagnostic assertion "timo || _kernel_lock_held()" failed: file "/usr/src/sys/kern/kern_synch.c", line 123 panic __assert tsleep usbd_transfer usbd_do_request_flags ur

Re: check disk_lookup return value

2020-03-11 Thread Theo de Raadt
Jasper Lievisse Adriaanse wrote: > Check return value of disk_lookup before dereference as it can > return NULL. These are Coverity CID 1452925, 1452951, 1452967. In what case... nfs diskless root? But in that case, do we even get here because rootdev/swapdev will be -1 won't they? I don't see

check disk_lookup return value

2020-03-11 Thread Jasper Lievisse Adriaanse
Hi, Check return value of disk_lookup before dereference as it can return NULL. These are Coverity CID 1452925, 1452951, 1452967. Other functions using disk_lookup (or the re-defined versions like wdlookup) check the return value already, including in the context of hibernation (sdmmc_scsi_hibern

Re: uplcom: remove dead code

2020-03-11 Thread Mark Kettenis
> Date: Wed, 11 Mar 2020 13:38:12 +0100 > From: Jasper Lievisse Adriaanse > > Hi, > > Remove dead code which is actually duplicated a few lines above > right after err is set. Coverity ID 975917 > > OK? ok kettenis@ > Index: dev/usb/uplcom.c > =

uplcom: remove dead code

2020-03-11 Thread Jasper Lievisse Adriaanse
Hi, Remove dead code which is actually duplicated a few lines above right after err is set. Coverity ID 975917 OK? Index: dev/usb/uplcom.c === RCS file: /cvs/src/sys/dev/usb/uplcom.c,v retrieving revision 1.73 diff -u -p -U11 -r1.73

Re: Debugger, traced processes & exit status

2020-03-11 Thread Martin Pieuchot
On 29/02/20(Sat) 19:55, Martin Pieuchot wrote: > On 28/02/20(Fri) 18:24, Martin Pieuchot wrote: > > Diff below fixes multiple issues with traced process, exposed by the > > regression test attached: > > > > - When a debugging process exit, give back the traced process to its > > original parent,