Jasper Lievisse Adriaanse <jas...@openbsd.org> wrote:

> Check return value of disk_lookup before dereference as it can
> return NULL. These are Coverity CID 1452925, 1452951, 1452967.

In what case... nfs diskless root?  But in that case, do we even
get here because rootdev/swapdev will be -1 won't they?

I don't see how it can fail.  I think coverity doesn't see the
full picture.

However, I think it is fine to follow the API and check for
an error which can't happen...

Reply via email to