Re: inteldrm(4) diff that needs testing

2015-10-25 Thread YASUOKA Masahiko
On Sat, 24 Oct 2015 23:48:01 +0200 (CEST) Mark Kettenis wrote: > The diff below makes inteldrm(4) attach directly to pci(4) instead of > vga(1). Because inteldrm(4) depends on intagp(4), this also make > intagp(4) a child of inteldrm(4). Ultimately I'd like to integrate > intagp(4) into inteldrm

Re: inteldrm(4) diff that needs testing

2015-10-25 Thread Jonathan Gray
On Sun, Oct 25, 2015 at 09:38:14PM +0100, Mark Kettenis wrote: > > Date: Sun, 25 Oct 2015 15:51:54 +1100 > > From: Jonathan Gray > > > > On Sat, Oct 24, 2015 at 11:48:01PM +0200, Mark Kettenis wrote: > > > The diff below makes inteldrm(4) attach directly to pci(4) instead of > > > vga(1). Becaus

Re: support for malloc allocation canaries

2015-10-25 Thread Daniel Micay
On 25/10/15 06:20 PM, Ted Unangst wrote: > Daniel Micay wrote: >> This patch adds an opt-in malloc configuration option placing canaries after >> small allocations to detect heap overflows on free(...). It's intended to be >> used alongside guard pages for large allocations. Since it's essentially

Re: The router doesn't know the size of the internet...

2015-10-25 Thread Einfach Jemand
Am 25.10.2015 um 13:47 schrieb Todd C. Miller: > On Sat, 24 Oct 2015 18:15:48 +0200, Sebastian Benoit wrote: > >>> s/size/diameter/ to quote RFC 2461 correctly >>> >>> The value should be set to that current diameter of the Internet. >> >> who measures that and tells me what to set there? > >

Re: telnet: low-delay traffic class for IPv6 connections

2015-10-25 Thread Todd C. Miller
On Sun, 25 Oct 2015 17:18:28 +0100, =?utf-8?Q?J=C3=A9r=C3=A9mie_Courr=C3=A8ges- Anglas?= wrote: > While here, there is no option to pass a different tos, and no other use > of the "tos" variable out of tn(), so move the "tos" variable in tn() > and assign it the right value from the start. OK mil

PF_KEY socket data sensitivity

2015-10-25 Thread Michael McConville
There are a few daemons in base that make a point of zeroing all data read from PF_KEY sockets. However, Benjamin Baier and I have looked into it a litle (RFC 2367 et al.) and it seems that this may only be metadata. To those with PF_KEY experience: is it worth zeroing?

Re: sed: better error message

2015-10-25 Thread Michael McConville
Jérémie Courrèges-Anglas wrote: > Michael McConville writes: > > It looks like it can be pretty easily replaced with calls to err(3), > > errx(3), warn(3), warnx(3), etc. > > Not sure about this, you'd have to repeat the same code over and over to > print the line number and file name. Good poin

Re: sed: better error message

2015-10-25 Thread Jérémie Courrèges-Anglas
Michael McConville writes: > Jérémie Courrèges-Anglas wrote: >> Tobias Stoeckmann writes: >> >> > $ sed s/a/b/ /nofile >> > sed: 0: /nofile: /nofile >> > >> > That message doesn't tell me a lot, let's better write >> > strerror(errno) if fopen returns NULL: >> > >> > $ ./sed s/a/b/ /nofile >> >

Re: inteldrm(4) diff that needs testing

2015-10-25 Thread Daniel Bolgheroni
On Sat, Oct 24, 2015 at 11:48:01PM +0200, Mark Kettenis wrote: > This diff needs to be tested on a wide range of hardware. So if you > have a machine with inteldrm(4), please give it a shot. I'm > particularly interested in testing on an x40. Works for me on a ThinkPad T420. OpenBSD 5.8-current

Re: utf8 hack for ls

2015-10-25 Thread Ted Unangst
it only gets deeper and thicker... this decodes chars and prints ? for bytes it doesn't like, as well as codepoints (128-159) it doesn't like. (this is extracted from some old utf8 code i had laying around. it's a bit simpler than the stringprep stuff but it seems to handle the case of some incor

Re: sed: better error message

2015-10-25 Thread Michael McConville
Jérémie Courrèges-Anglas wrote: > Tobias Stoeckmann writes: > > > $ sed s/a/b/ /nofile > > sed: 0: /nofile: /nofile > > > > That message doesn't tell me a lot, let's better write > > strerror(errno) if fopen returns NULL: > > > > $ ./sed s/a/b/ /nofile > > sed: 0: /nofile: No such file or directo

slist remove invalidate

2015-10-25 Thread Alexander Bluhm
Hi, This diff that makes SLIST_REMOVE invalidate pointer more paranoid. I am running it for a while now without problems. ok to put in in? bluhm Index: sys/queue.h === RCS file: /data/mirror/openbsd/cvs/src/sys/sys/queue.h,v retrie

Re: route6d: another pidfile() removal

2015-10-25 Thread Sebastian Benoit
ok! J??r??mie Courr??ges-Anglas(j...@wxcvbn.org) on 2015.10.25 23:15:12 +0100: > > Following the recent discussions, here's another pidfile(3) removal. > route6d(8) doesn't document it. > > ok? > > Index: Makefile > === > RCS file:

Re: support for malloc allocation canaries

2015-10-25 Thread Ted Unangst
Daniel Micay wrote: > This patch adds an opt-in malloc configuration option placing canaries after > small allocations to detect heap overflows on free(...). It's intended to be > used alongside guard pages for large allocations. Since it's essentially > adding extra padding to all small allocation

route6d: another pidfile() removal

2015-10-25 Thread Jérémie Courrèges-Anglas
Following the recent discussions, here's another pidfile(3) removal. route6d(8) doesn't document it. ok? Index: Makefile === RCS file: /cvs/src/usr.sbin/route6d/Makefile,v retrieving revision 1.7 diff -u -p -r1.7 Makefile --- Makefi

Re: ftpd banner

2015-10-25 Thread Jérémie Courrèges-Anglas
"Ted Unangst" writes: > unifdef some foolishness. note that BSD is not currently defined when this > file is built. ok jca@ [...] -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE

ftpd banner

2015-10-25 Thread Ted Unangst
unifdef some foolishness. note that BSD is not currently defined when this file is built. Index: ftpcmd.y === RCS file: /cvs/src/libexec/ftpd/ftpcmd.y,v retrieving revision 1.60 diff -u -p -r1.60 ftpcmd.y --- ftpcmd.y18 Aug 2015

Re: inteldrm(4) diff that needs testing

2015-10-25 Thread Mark Kettenis
> Date: Sun, 25 Oct 2015 15:51:54 +1100 > From: Jonathan Gray > > On Sat, Oct 24, 2015 at 11:48:01PM +0200, Mark Kettenis wrote: > > The diff below makes inteldrm(4) attach directly to pci(4) instead of > > vga(1). Because inteldrm(4) depends on intagp(4), this also make > > intagp(4) a child of

Re: sed: better error message

2015-10-25 Thread Jérémie Courrèges-Anglas
Tobias Stoeckmann writes: > $ sed s/a/b/ /nofile > sed: 0: /nofile: /nofile > > That message doesn't tell me a lot, let's better write > strerror(errno) if fopen returns NULL: > > $ ./sed s/a/b/ /nofile > sed: 0: /nofile: No such file or directory That's much nicer, ok jca@ (misc.c:err() alread

Re: rtadvd: pledge() and pidfile() are in a boat

2015-10-25 Thread Jérémie Courrèges-Anglas
j...@wxcvbn.org (Jérémie Courrèges-Anglas) writes: > So I took look at which pledge requests rtadvd could use. > > Turns out it can't call pledge early, because it attempts to retrieve > IPV6CTL_FORWARDING and pledge currently denies it. rtadvd is the only > user of IPV6CTL_FORWARDING in base, so

sed: better error message

2015-10-25 Thread Tobias Stoeckmann
$ sed s/a/b/ /nofile sed: 0: /nofile: /nofile That message doesn't tell me a lot, let's better write strerror(errno) if fopen returns NULL: $ ./sed s/a/b/ /nofile sed: 0: /nofile: No such file or directory Index: main.c === RCS file

rtadvd: pledge() and pidfile() are in a boat

2015-10-25 Thread Jérémie Courrèges-Anglas
So I took look at which pledge requests rtadvd could use. Turns out it can't call pledge early, because it attempts to retrieve IPV6CTL_FORWARDING and pledge currently denies it. rtadvd is the only user of IPV6CTL_FORWARDING in base, so IMO it doesn't call for a change in kern_pledge.c. There a

Re: inteldrm(4) diff that needs testing

2015-10-25 Thread Matthieu Herrb
On Sat, Oct 24, 2015 at 11:48:01PM +0200, Mark Kettenis wrote: > The diff below makes inteldrm(4) attach directly to pci(4) instead of > vga(1). Because inteldrm(4) depends on intagp(4), this also make > intagp(4) a child of inteldrm(4). Ultimately I'd like to integrate > intagp(4) into inteldrm(

Re: inteldrm(4) diff that needs testing

2015-10-25 Thread Ralf Horstmann
* Jonathan Gray [2015-10-25 05:51]: > On Sat, Oct 24, 2015 at 11:48:01PM +0200, Mark Kettenis wrote: > > The diff below makes inteldrm(4) attach directly to pci(4) instead of > > vga(1). Because inteldrm(4) depends on intagp(4), this also make > > intagp(4) a child of inteldrm(4). Ultimately I'd

Re: inteldrm(4) diff that needs testing

2015-10-25 Thread Mark Kettenis
> Date: Sun, 25 Oct 2015 15:50:51 +0100 > From: Stefan Sperling > > On Sat, Oct 24, 2015 at 11:48:01PM +0200, Mark Kettenis wrote: > > The diff below makes inteldrm(4) attach directly to pci(4) instead of > > vga(1). Because inteldrm(4) depends on intagp(4), this also make > > intagp(4) a child

Re: inteldrm(4) diff that needs testing

2015-10-25 Thread Mark Kettenis
> Date: Sat, 24 Oct 2015 23:48:01 +0200 (CEST) > From: Mark Kettenis > > The diff below makes inteldrm(4) attach directly to pci(4) instead of > vga(1). Because inteldrm(4) depends on intagp(4), this also make > intagp(4) a child of inteldrm(4). Ultimately I'd like to integrate > intagp(4) into

Re: More easy rt_ifix conversions

2015-10-25 Thread Alexander Bluhm
On Sat, Oct 24, 2015 at 02:54:00PM +0200, Martin Pieuchot wrote: > ok? Some parts have been commited in a differnet way. So I will comment individually. > Index: netinet/if_ether.c > === > RCS file: /cvs/src/sys/netinet/if_ether.c,v

installboot, softraid, and GPT

2015-10-25 Thread Stefan Sperling
installboot on a softraid volume on a GPT disk currently results in an error. # installboot sd2 Using / as root installing bootstrap on /dev/rsd2c using first-stage /usr/mdec/biosboot, second-stage /usr/mdec/boot sd2: softraid volume with 1 disk(s) sd2: installing boot loader on softra

Re: Further cleanup of Russian calendars

2015-10-25 Thread mxb
> On 23 okt. 2015, at 20:27, Mikhail wrote: > > I think "государственного" should be capitalized too (флаг is okay) +1

Re: Restrict envvar names

2015-10-25 Thread Vadim Zhukov
2015-10-25 17:03 GMT+01:00 Stefan Sperling : > On Sun, Oct 25, 2015 at 04:36:29PM +0100, Vadim Zhukov wrote: >> This patch restricts characters you could use in environment variable >> names passed via execve(2). Note that values are not affected, you're >> still allowed to pass anything there. >>

Re: Restrict envvar names

2015-10-25 Thread Christian Weisgerber
On 2015-10-25, Stefan Sperling wrote: > """ > Environment variable names used by the utilities in the Shell and > Utilities volume of POSIX.1-2008 consist solely of uppercase letters, > digits, and the ( '_' ) from the characters defined in > Portable Character Set and do not begin with a digit.

Re: inteldrm(4) diff that needs testing

2015-10-25 Thread Sebastien Marie
On Sun, Oct 25, 2015 at 08:20:50AM -0700, Philip Guenther wrote: > On Sun, Oct 25, 2015 at 5:43 AM, Gregor Best wrote: > > Hi Mark, > > > > On Sat, Oct 24, 2015 at 11:48:01PM +0200, Mark Kettenis wrote: > >> [...] > >> This diff needs to be tested on a wide range of hardware. So if you > >> have

Re: Introduce if_rtrequest()

2015-10-25 Thread Martin Pieuchot
On 25/10/15(Sun) 18:06, Ossi Herrala wrote: > On Sun, Oct 25, 2015 at 09:58:00AM +0100, Claudio Jeker wrote: > > On Sat, Oct 24, 2015 at 06:22:10PM +0200, Martin Pieuchot wrote: > > > On 24/10/15(Sat) 18:01, Martin Pieuchot wrote: > > > > > As a side effect arp_ifinit() can now die since every Eth

telnet: low-delay traffic class for IPv6 connections

2015-10-25 Thread Jérémie Courrèges-Anglas
While here, there is no option to pass a different tos, and no other use of the "tos" variable out of tn(), so move the "tos" variable in tn() and assign it the right value from the start. ok? Index: commands.c === RCS file: /cvs/sr

Re: Introduce if_rtrequest()

2015-10-25 Thread Ossi Herrala
On Sun, Oct 25, 2015 at 09:58:00AM +0100, Claudio Jeker wrote: > On Sat, Oct 24, 2015 at 06:22:10PM +0200, Martin Pieuchot wrote: > > On 24/10/15(Sat) 18:01, Martin Pieuchot wrote: > > > As a side effect arp_ifinit() can now die since every Ethernet driver > > > initialize if_rtrequest in ether_if

Re: Restrict envvar names

2015-10-25 Thread Stefan Sperling
On Sun, Oct 25, 2015 at 04:36:29PM +0100, Vadim Zhukov wrote: > This patch restricts characters you could use in environment variable > names passed via execve(2). Note that values are not affected, you're > still allowed to pass anything there. > > Everything starts fine like before for me as of

Re: inteldrm(4) diff that needs testing

2015-10-25 Thread Gregor Best
On Sun, Oct 25, 2015 at 08:20:50AM -0700, Philip Guenther wrote: > [...] > This looks like the result of applying the diff but not running config > [...] Thanks for the clue bat. It's working fine on a Thinkpad T400. -- Gregor

Restrict envvar names

2015-10-25 Thread Vadim Zhukov
This patch restricts characters you could use in environment variable names passed via execve(2). Note that values are not affected, you're still allowed to pass anything there. Everything starts fine like before for me as of now, including a couple of daemons and Iridium browser. okay? Or we do

Re: inteldrm(4) diff that needs testing

2015-10-25 Thread Philip Guenther
On Sun, Oct 25, 2015 at 5:43 AM, Gregor Best wrote: > Hi Mark, > > On Sat, Oct 24, 2015 at 11:48:01PM +0200, Mark Kettenis wrote: >> [...] >> This diff needs to be tested on a wide range of hardware. So if you >> have a machine with inteldrm(4), please give it a shot. I'm >> particularly interes

Re: Kill rtable_mpath_match

2015-10-25 Thread Sebastian Benoit
Martin Pieuchot(m...@openbsd.org) on 2015.10.25 16:14:27 +0100: > Diff below merges the guts of rtable_mpath_match() into rtable_lookup(). > As for the previous rtable_mpath_* diff this is a step towards MPATH by > default. > > This diff introduces a behavior change for RTM_GET. If multiple route

Kill rtable_mpath_match

2015-10-25 Thread Martin Pieuchot
Diff below merges the guts of rtable_mpath_match() into rtable_lookup(). As for the previous rtable_mpath_* diff this is a step towards MPATH by default. This diff introduces a behavior change for RTM_GET. If multiple route exists a gateway MUST be specified and the first one in the tree won't be

Re: ld.so crash second attempt

2015-10-25 Thread Philip Guenther
On Sun, Oct 25, 2015 at 3:01 AM, Peter Hajdu wrote: > I try to give it one more attempt with a bit more description about the > bug. I am, slooowly, looking at this. Philip Guenther

Re: inteldrm(4) diff that needs testing

2015-10-25 Thread Stefan Sperling
On Sat, Oct 24, 2015 at 11:48:01PM +0200, Mark Kettenis wrote: > The diff below makes inteldrm(4) attach directly to pci(4) instead of > vga(1). Because inteldrm(4) depends on intagp(4), this also make > intagp(4) a child of inteldrm(4). Ultimately I'd like to integrate > intagp(4) into inteldrm(

Re: Kill rtable_mpath_conflict

2015-10-25 Thread Claudio Jeker
On Sun, Oct 25, 2015 at 03:22:51PM +0100, Martin Pieuchot wrote: > Instead of having a separate function to check for MPATH conflicts > simply pass the gateway to rtable_insert(). Some regress tests > outputs will need an update as we're now doing one more rtalloc(9) > call in RTM_ADD. > > This

Kill rtable_mpath_conflict

2015-10-25 Thread Martin Pieuchot
Instead of having a separate function to check for MPATH conflicts simply pass the gateway to rtable_insert(). Some regress tests outputs will need an update as we're now doing one more rtalloc(9) call in RTM_ADD. This is a step towards MPATH by default. ok? Index: net/route.c

Re: inteldrm(4) diff that needs testing

2015-10-25 Thread Norman Golisz
On Sat Oct 24 2015 23:48, Mark Kettenis wrote: > This diff needs to be tested on a wide range of hardware. So if you > have a machine with inteldrm(4), please give it a shot. I'm > particularly interested in testing on an x40. No problems on my Thinkpad T400 (also running X11). OpenBSD 5.8-cur

Re: inteldrm(4) diff that needs testing

2015-10-25 Thread Sebastien Marie
On Sat, Oct 24, 2015 at 11:48:01PM +0200, Mark Kettenis wrote: > The diff below makes inteldrm(4) attach directly to pci(4) instead of > vga(1). Because inteldrm(4) depends on intagp(4), this also make > intagp(4) a child of inteldrm(4). Ultimately I'd like to integrate > intagp(4) into inteldrm(

Re: telnet: kill dead IP source route

2015-10-25 Thread Todd C. Miller
On Sat, 24 Oct 2015 18:08:28 +0200, =?utf-8?Q?J=C3=A9r=C3=A9mie_Courr=C3=A8ges- Anglas?= wrote: > That made me look for software that tried to use these options in > outgoing packets. That code, in telnet(1), has been broken since 1998, > says cvs log. I doubt that anyone will miss it. > > Also

Re: inteldrm(4) diff that needs testing

2015-10-25 Thread Gregor Best
Hi Mark, On Sat, Oct 24, 2015 at 11:48:01PM +0200, Mark Kettenis wrote: > [...] > This diff needs to be tested on a wide range of hardware. So if you > have a machine with inteldrm(4), please give it a shot. I'm > particularly interested in testing on an x40. > [...] I got a UVM fault with the

Re: The router doesn't know the size of the internet...

2015-10-25 Thread Todd C. Miller
On Sat, 24 Oct 2015 18:15:48 +0200, Sebastian Benoit wrote: > > s/size/diameter/ to quote RFC 2461 correctly > > > > The value should be set to that current diameter of the Internet. > > who measures that and tells me what to set there? Every sys/netinet hacker should own a set of internet

Re: inteldrm(4) diff that needs testing

2015-10-25 Thread Stefan Sperling
On Sat, Oct 24, 2015 at 11:48:01PM +0200, Mark Kettenis wrote: > The diff below makes inteldrm(4) attach directly to pci(4) instead of > vga(1). Because inteldrm(4) depends on intagp(4), this also make > intagp(4) a child of inteldrm(4). Ultimately I'd like to integrate > intagp(4) into inteldrm(

Re: be more consistent in rtsock

2015-10-25 Thread Martin Pieuchot
On 25/10/15(Sun) 10:46, Claudio Jeker wrote: > Some stuff I found while looking at kroute code is that the kernel is not > always filling the info in the same way. This tries to fix this. > First of all make sure the RTM_GET lookups fill out rtm_index no matter > what. We do the same thing in the s

Re: utf8 hack for ls

2015-10-25 Thread Ted Unangst
Ted Unangst wrote: > Christian Weisgerber wrote: > > On 2015-10-23, "Ted Unangst" wrote: > > > > >> To what degree should tools like ls protect terminals from escape codes? > > > > > > I think this is beyond the scope of what ls should care about. du doesn't > > > have > > > such a check. Does t

usbdump, a tool to print usb descriptor

2015-10-25 Thread Ludovic Coues
Usbdump is the result of my work during this summer of code. It is a tool inspired by pcidump. It reads usb device descriptor and print them with a bit of parsing. It aim to be a more friendly alternative to lsusb. There is two main difference with pcidump, boiling down to the nature of the usb pr

ld.so crash second attempt

2015-10-25 Thread Peter Hajdu
Hi, I try to give it one more attempt with a bit more description about the bug. After calling dlclose in _dl_notify_unload_shlib_ group reference counts are decreased by following the object's grpref-list. Unfortunately the references are removed from the list during the graph traversal. dlclo

be more consistent in rtsock

2015-10-25 Thread Claudio Jeker
Some stuff I found while looking at kroute code is that the kernel is not always filling the info in the same way. This tries to fix this. First of all make sure the RTM_GET lookups fill out rtm_index no matter what. We do the same thing in the sysctl code and also in most other RTM_* messages. Sec

Re: pledge(2) in quiz(6)

2015-10-25 Thread Ted Unangst
Jan Stary wrote: > Any comments/OK? > > On Oct 22 13:49:28, h...@stare.cz wrote: > > games/quiz.c popen()s a PAGER to display the help message. > > Throw that away and let the use pipe into a PAGER if needed. > > Then we can just pledge "stdio rpath". yeah, works for me.

Re: Introduce if_rtrequest()

2015-10-25 Thread Claudio Jeker
On Sat, Oct 24, 2015 at 06:22:10PM +0200, Martin Pieuchot wrote: > On 24/10/15(Sat) 18:01, Martin Pieuchot wrote: > > Revamping the network stack design continue here at u2k15... > > > > This times it's about the L2 resolution mechanism plugged into the > > routing table. While discussing with A

Re: rt_missmsg takes interface index

2015-10-25 Thread Claudio Jeker
On Sat, Oct 24, 2015 at 07:04:52PM +0200, Alexander Bluhm wrote: > Hi, > > Instead of doing the the if_get() dance for rt_missmsg(), change the > function to take an interface index. > > ok? Yes > bluhm > > Index: net/route.c > =

Re: [patch] tcpdump - better BGP UPDATE AS_PATH size calculations

2015-10-25 Thread Claudio Jeker
On Sat, Oct 24, 2015 at 12:37:44PM -0600, Kevin Reay wrote: > Adopt an updated version of the tcpdump.org ASN size calculation for > BGP UPDATE message AS_PATHs. This corrects some bad behaviour due to > incorrect ASN size calculations. > > I believe that the current way of calculating the ASN siz

Re: documenting multiple standards

2015-10-25 Thread Jason McIntyre
On Sun, Oct 25, 2015 at 01:58:21AM -0600, Anthony J. Bentley wrote: > >From wcrtomb(3): > > The wcrtomb() function conforms to ISO/IEC 9899/AMD1:1995 (``ISO C90, > Amendment 1''). The restrict qualifier is added at ISO/IEC 9899/1999 > (``ISO C99''). > > This wording is confusing.

Re: documenting multiple standards

2015-10-25 Thread Philip Guenther
On Sun, Oct 25, 2015 at 12:58 AM, Anthony J. Bentley wrote: > From wcrtomb(3): > > The wcrtomb() function conforms to ISO/IEC 9899/AMD1:1995 (``ISO C90, > Amendment 1''). The restrict qualifier is added at ISO/IEC 9899/1999 > (``ISO C99''). > > This wording is confusing. Is it impl

Re: documenting multiple standards

2015-10-25 Thread Theo de Raadt
>>From wcrtomb(3): > > The wcrtomb() function conforms to ISO/IEC 9899/AMD1:1995 (``ISO C90, > Amendment 1''). The restrict qualifier is added at ISO/IEC 9899/1999 > (``ISO C99''). > >This wording is confusing. Is it implying that we don't use a restrict >qualifier? (We do.) > >If a st

documenting multiple standards

2015-10-25 Thread Anthony J. Bentley
>From wcrtomb(3): The wcrtomb() function conforms to ISO/IEC 9899/AMD1:1995 (``ISO C90, Amendment 1''). The restrict qualifier is added at ISO/IEC 9899/1999 (``ISO C99''). This wording is confusing. Is it implying that we don't use a restrict qualifier? (We do.) If a standard cha