On 25/10/15(Sun) 18:06, Ossi Herrala wrote:
> On Sun, Oct 25, 2015 at 09:58:00AM +0100, Claudio Jeker wrote:
> > On Sat, Oct 24, 2015 at 06:22:10PM +0200, Martin Pieuchot wrote:
> > > On 24/10/15(Sat) 18:01, Martin Pieuchot wrote:
>
> > > > As a side effect arp_ifinit() can now die since every Ethernet driver
> > > > initialize if_rtrequest in ether_ifattach().
> > >
> > > Index: net/if.c
> > > ===================================================================
> > > RCS file: /cvs/src/sys/net/if.c,v
> > > retrieving revision 1.394
> > > diff -u -p -r1.394 if.c
> > > --- net/if.c 24 Oct 2015 10:52:05 -0000 1.394
> > > +++ net/if.c 24 Oct 2015 16:19:49 -0000
> > > @@ -520,6 +520,7 @@ if_attach_common(struct ifnet *ifp)
> > > M_TEMP, M_WAITOK);
>
> > > @@ -821,7 +820,6 @@ arpproxy(struct in_addr in, unsigned int
> > > void
> > > arp_ifinit(struct arpcom *ac, struct ifaddr *ifa)
> > > {
> > > - ifa->ifa_rtrequest = arp_rtrequest;
> > > }
> > >
> >
> > Woohoo empty function. Guess somebody can make a big diff killing this
> > function for real. Any volunteer?
> >
>
> Challenge accepted. Coffee, a bit of Coccinelle and then final polish
> by hand. GENERIC compiles in amd64 and i386. I tried to remove all
> unused "struct ifaddr *ifa = (struct ifaddr *)data;" by hand from all
> archs, but there might still be some and produce unused argument
> errors while compiling kernel.
>
> The following is "git diff" since I don't know how to work in CVS with
> patches applied. Help appreciated if it needs to be cvs diff.
>
> 136 files changed, 19 insertions(+), 619 deletions(-)
>
> I'm getting "diff blindness" to spot any mistakes. Comments welcome :)
Thanks for your work but I already did and committed most of it. I could
not build the armv7 and the vax bits so these are the missing ones.
