Re: Cast isspace() arg to unsigned char

2015-10-16 Thread Bob Beck
ok On Fri, Oct 16, 2015 at 01:59:51PM -0400, Michael McConville wrote: > ok? > > > Index: fio.c > === > RCS file: /cvs/src/usr.bin/mail/fio.c,v > retrieving revision 1.35 > diff -u -p -r1.35 fio.c > --- fio.c 16 Oct 2015 17:56:

aucat.1: small cleanup

2015-10-16 Thread Michael Reed
The use of Bk/Ek and Xo/Xc was not needed, as confirmed by "diff <{mandoc old.1} <{mandoc new.1} | less". The only visible changes should be the Ar -> Cm conversions. Index: aucat.1 === RCS file: /cvs/src/usr.bin/aucat/aucat.1,v ret

Re: rtisvalid6

2015-10-16 Thread Alexander Bluhm
On Fri, Oct 16, 2015 at 04:24:04PM +0200, Martin Pieuchot wrote: > --- netinet6/icmp6.c 18 Sep 2015 14:26:22 - 1.172 > +++ netinet6/icmp6.c 16 Oct 2015 13:48:56 - > @@ -1568,7 +1568,7 @@ icmp6_redirect_output(struct mbuf *m0, s > goto fail; > > /* sanity check *

Re: More rtisvalid(9)

2015-10-16 Thread Alexander Bluhm
On Fri, Oct 16, 2015 at 03:09:03PM +0200, Martin Pieuchot wrote: > - if (rt->rt_flags & (RTF_REJECT | RTF_BLACKHOLE) || > - (rt->rt_flags & RTF_UP) == 0) { > + if (!rtisvalid(rt) || ISSET(rt->rt_flags, RTF_REJECT|RTF_BLACKHOLE)) { Why change to ISSET()? I still don't know which va

Re: compress: tighter pledge

2015-10-16 Thread Theo de Raadt
> Here's an attempt to tighten compress/gzip's pledge: > > Due to the use of fts(3), we always require rpath, even for > gzip out. > > We only write to stdio and never to any files... > * if we are in cat mode (-c, zcat) > * if we are in test mode (-t) > * if there are no file arguments and there

compress: tighter pledge

2015-10-16 Thread Christian Weisgerber
Here's an attempt to tighten compress/gzip's pledge: Due to the use of fts(3), we always require rpath, even for gzip out. We only write to stdio and never to any files... * if we are in cat mode (-c, zcat) * if we are in test mode (-t) * if there are no file arguments and there is no -o outfile

Re: FreeType-2.6.1 !!header files layout changed again!!

2015-10-16 Thread Christian Weisgerber
On 2015-10-15, Christian Weisgerber wrote: > Known fallout so far: all Mozilla ports. David has fixed this and there has been no further fallout. The FreeType update can go ahead. -- Christian "naddy" Weisgerber na...@mips.inka.de

fix build with IFMEDIA_DEBUG

2015-10-16 Thread Stefan Sperling
Needs to know contents of struct ifp and a small ifmedia64 fix. Index: if_media.c === RCS file: /cvs/src/sys/net/if_media.c,v retrieving revision 1.28 diff -u -p -r1.28 if_media.c --- if_media.c 29 Sep 2015 10:11:40 - 1.28 +

Re: two bge(4) bugfixes

2015-10-16 Thread Mark Kettenis
> Date: Thu, 15 Oct 2015 17:23:21 + > From: Miod Vallat > > The following diff attempts to fix two small bge(4) bugs: > > - the first chunk fixes what seems to be a logic error on BCM 5720, > where the code attemps to preserve the state of four bits, but these > have actually already bee

Re: Unlocking ix(4) a bit further

2015-10-16 Thread Mark Kettenis
> Date: Fri, 16 Oct 2015 14:13:52 +0200 > From: Martin Pieuchot > > On 08/10/15(Thu) 20:49, Mark Kettenis wrote: > > > Date: Wed, 30 Sep 2015 14:30:11 +0200 (CEST) > > > From: Mark Kettenis > > > > > > Since people seemed to like my diff for em(4), here is one for ix(4). > > > In addition to un

Cast isspace() arg to unsigned char

2015-10-16 Thread Michael McConville
ok? Index: fio.c === RCS file: /cvs/src/usr.bin/mail/fio.c,v retrieving revision 1.35 diff -u -p -r1.35 fio.c --- fio.c 16 Oct 2015 17:56:07 - 1.35 +++ fio.c 16 Oct 2015 17:56:42 - @@ -142,7 +142,7 @@ setptr(

Re: Oct 15 OpenBSD errata and LibreSSL releases

2015-10-16 Thread Ted Unangst
André Schneider wrote: > Hi, > > maybe i'm overlooking something, but in the rebuild and install > instructions, > shouldn't it say >cd /usr/src/lib/libcrypto > instead of >cd src/lib/libcrypto either or. maybe somebody has their src somewhere else.

Re: Oct 15 OpenBSD errata and LibreSSL releases

2015-10-16 Thread Stuart Henderson
On 2015/10/16 18:34, Артур Истомин wrote: > On Thu, Oct 15, 2015 at 08:29:25PM -0400, Ted Unangst wrote: > > The OBJ_obj2txt function in libcrypto contains a one byte buffer overrun > > and memory leak, as reported by Qualys Security. This can be abused by an > > attacker to cause a denial of servi

Re: Oct 15 OpenBSD errata and LibreSSL releases

2015-10-16 Thread Артур Истомин
On Thu, Oct 15, 2015 at 08:29:25PM -0400, Ted Unangst wrote: > The OBJ_obj2txt function in libcrypto contains a one byte buffer overrun > and memory leak, as reported by Qualys Security. This can be abused by an > attacker to cause a denial of service in some cases. > > Patches are now available f

Re: More rtisvalid(9)

2015-10-16 Thread Bob Beck
Anyone who touches the network is, I think Obviously much more so than anyone who touches VFS, since NFS has an "N" for network in the name. I'm glad we thought carefully about this and now have clear areas of responsibility. On Fri, Oct 16, 2015 at 8:20 AM, Martin Pieuchot wrote: > On 16

rtisvalid6

2015-10-16 Thread Martin Pieuchot
This is like the inet version but... erf no! It's just the sys/netinet6 part! Index: netinet6/icmp6.c === RCS file: /cvs/src/sys/netinet6/icmp6.c,v retrieving revision 1.172 diff -u -p -r1.172 icmp6.c --- netinet6/icmp6.c18 Sep

ld.so does not use already loaded objects if full path is used

2015-10-16 Thread Peter Hajdu
Hi, I found something that seems to be a bug in ld.so. If I load a shared library with full path with dlopen, it does not check if the library is already loaded. I was hoping someone can have a look at it too, I might have missed something. This is my first patch, I hope I did not make too much

Re: More rtisvalid(9)

2015-10-16 Thread Martin Pieuchot
On 16/10/15(Fri) 07:50, Bob Beck wrote: > On Fri, Oct 16, 2015 at 7:09 AM, Martin Pieuchot wrote: > > So naddy@ confirmed my last rtisvalid(9) changes did not break his NFS > > setup! > > > > You know NFS is special right? The act of doing something that doesn't > break it actually makes you an N

Re: dedup in_pcbbind() port scan loop

2015-10-16 Thread Martin Pieuchot
On 15/10/15(Thu) 14:09, Vincent Gross wrote: > On 10/07/15 14:05, Martin Pieuchot wrote: > > On 01/10/15(Thu) 19:40, Vincent Gross wrote: > >> Although the sysctls controlling the port range are labelled > >> "port(hi)?first" and > >> "port(hi)?last", no ordering is enforced and you can have portf

Re: More rtisvalid(9)

2015-10-16 Thread Bob Beck
On Fri, Oct 16, 2015 at 7:09 AM, Martin Pieuchot wrote: > So naddy@ confirmed my last rtisvalid(9) changes did not break his NFS > setup! > You know NFS is special right? The act of doing something that doesn't break it actually makes you an NFS hacker.

Re: two bge(4) bugfixes

2015-10-16 Thread Martin Pieuchot
On 15/10/15(Thu) 17:23, Miod Vallat wrote: > The following diff attempts to fix two small bge(4) bugs: > > - the first chunk fixes what seems to be a logic error on BCM 5720, > where the code attemps to preserve the state of four bits, but these > have actually already been set in the local va

Re: Oct 15 OpenBSD errata and LibreSSL releases

2015-10-16 Thread André Schneider
Hi, maybe i'm overlooking something, but in the rebuild and install instructions, shouldn't it say cd /usr/src/lib/libcrypto instead of cd src/lib/libcrypto Best, André Schneider Am 16.10.2015 02:29 schrieb Ted Unangst: The OBJ_obj2txt function in libcrypto contains a one byte

Re: cast struct sockaddr_dl

2015-10-16 Thread Martin Pieuchot
On 15/10/15(Thu) 22:51, Alexander Bluhm wrote: > Hi, > > Inspired by the satosin() functions, I think it is better to have > inline functions than casts to convert between sockaddrs. They > check if the incoming object has the expected type. So introduce > satosdl() and sdltosa() to the kernel.

More rtisvalid(9)

2015-10-16 Thread Martin Pieuchot
So naddy@ confirmed my last rtisvalid(9) changes did not break his NFS setup! Here's more, the sys/netinet ones, ok? Index: netinet/in_pcb.c === RCS file: /cvs/src/sys/netinet/in_pcb.c,v retrieving revision 1.181 diff -u -p -r1.181 i

mpsafe gem(4)

2015-10-16 Thread Martin Pieuchot
I'm a bit late to the party, but here's a diff to bring gem(4) to the group of cool^WIPL_MPSAFE drivers. sparc and sparc64 are only compile tested, I've been running with this on my dual G5. It includes Mark's diff to disable flow control since I'm running with it and it does help in my lab! Mor

Re: Unlocking ix(4) a bit further

2015-10-16 Thread Martin Pieuchot
On 08/10/15(Thu) 20:49, Mark Kettenis wrote: > > Date: Wed, 30 Sep 2015 14:30:11 +0200 (CEST) > > From: Mark Kettenis > > > > Since people seemed to like my diff for em(4), here is one for ix(4). > > In addition to unlocking the rx completion path, this one also uses > > intr_barrier() and remove

intr_barrier() for sparc

2015-10-16 Thread Martin Pieuchot
I need that to be able to call intr_barrier() in gem(4), ok? Index: include/intr.h === RCS file: /cvs/src/sys/arch/sparc/include/intr.h,v retrieving revision 1.4 diff -u -p -r1.4 intr.h --- include/intr.h 5 Nov 2012 13:20:16 -000

Re: iwm: move some debug code into IWM_DEBUG

2015-10-16 Thread Martin Pieuchot
On 16/10/15(Fri) 12:53, Stefan Sperling wrote: > This moves iwm_error_event_table and the advanced_lookup table > inside #ifdef IWM_DEBUG. They're not used outside this ifdef. Sure, ok mpi@ > > Index: if_iwm.c > === > RCS file: /cvs

Re: preparing pfi_kif to MP world

2015-10-16 Thread Alexandr Nedvedicky
On Fri, Oct 16, 2015 at 01:41:50PM +0200, Mike Belopuhov wrote: > On 16 October 2015 at 13:28, Alexandr Nedvedicky > wrote: > > > > may be it's kind of bike shading... > > How about make kifs to stick to convention we see for other objects > > such as rulesets/anchors: > > > > pfi_kif_find

Re: iwm(4) scanning cleanup

2015-10-16 Thread Martin Pieuchot
On 16/10/15(Fri) 12:37, Stefan Sperling wrote: > On Tue, Oct 06, 2015 at 11:20:12AM +0200, Stefan Sperling wrote: > > On Tue, Oct 06, 2015 at 10:09:00AM +0200, Martin Pieuchot wrote: > > > On 05/10/15(Mon) 23:03, Stefan Sperling wrote: > > > > I find this approach easier to follow and it doesn't me

Re: preparing pfi_kif to MP world

2015-10-16 Thread Mike Belopuhov
On 16 October 2015 at 13:28, Alexandr Nedvedicky wrote: > > may be it's kind of bike shading... > How about make kifs to stick to convention we see for other objects > such as rulesets/anchors: > > pfi_kif_find() > pfi_kif_find_or_create() > Personally I don't like "_or_create" st

Re: preparing pfi_kif to MP world

2015-10-16 Thread Alexandr Nedvedicky
> > Turns out this is a rather simple issue that got slightly > complicated by the code diverging quite a bit since the > inception. Essentially the clr->ifname comes from the > interface specification in the "pfctl -i foo0 -Fs" for > if-bound states (floating states use fake interface "any"). >

iwm: move some debug code into IWM_DEBUG

2015-10-16 Thread Stefan Sperling
This moves iwm_error_event_table and the advanced_lookup table inside #ifdef IWM_DEBUG. They're not used outside this ifdef. Index: if_iwm.c === RCS file: /cvs/src/sys/dev/pci/if_iwm.c,v retrieving revision 1.57 diff -u -p -r1.57 if_i

Re: iwm(4) scanning cleanup

2015-10-16 Thread Stefan Sperling
On Tue, Oct 06, 2015 at 11:20:12AM +0200, Stefan Sperling wrote: > On Tue, Oct 06, 2015 at 10:09:00AM +0200, Martin Pieuchot wrote: > > On 05/10/15(Mon) 23:03, Stefan Sperling wrote: > > > I find this approach easier to follow and it doesn't mess with > > > ic->ic_scan_lock which is supposed to be

Re: nsd 4.1.6rc1

2015-10-16 Thread Stuart Henderson
On 2015/10/15 20:50, Todd C. Miller wrote: > On Thu, 15 Oct 2015 22:22:17 -0400, "Ted Unangst" wrote: > > > Secondary question: what's involved in updating lex? I didn't realize we had > > fallen behind as it were, but should we switch too? > > At one point it required GNU m4'isms we didn't suppo

Re: tmux(1): Use-after-free in capture-pane

2015-10-16 Thread Nicholas Marriott
Whoops, you are right there. Applied, thanks! On Fri, Oct 16, 2015 at 09:34:33AM +0200, Theo Buehler wrote: > On a recent amd64 snapshot I ran into this: > > (inside a tmux session session) > $ tmux new-window > $ tmux capture-pane -S - > $ tmux save-buffer /tmp/mybuf > $ hexdump -Cv /tmp/mybuf >

tmux(1): Use-after-free in capture-pane

2015-10-16 Thread Theo Buehler
On a recent amd64 snapshot I ran into this: (inside a tmux session session) $ tmux new-window $ tmux capture-pane -S - $ tmux save-buffer /tmp/mybuf $ hexdump -Cv /tmp/mybuf df df df df df df df df df df df df df df df df || 0010 df df df df df df df df df df df d