On 16/10/15(Fri) 12:53, Stefan Sperling wrote: > This moves iwm_error_event_table and the advanced_lookup table > inside #ifdef IWM_DEBUG. They're not used outside this ifdef.
Sure, ok mpi@ > > Index: if_iwm.c > =================================================================== > RCS file: /cvs/src/sys/dev/pci/if_iwm.c,v > retrieving revision 1.57 > diff -u -p -r1.57 if_iwm.c > --- if_iwm.c 16 Oct 2015 10:04:56 -0000 1.57 > +++ if_iwm.c 16 Oct 2015 10:48:36 -0000 > @@ -407,8 +407,8 @@ void iwm_start(struct ifnet *); > void iwm_stop(struct ifnet *, int); > void iwm_watchdog(struct ifnet *); > int iwm_ioctl(struct ifnet *, u_long, iwm_caddr_t); > -const char *iwm_desc_lookup(uint32_t); > #ifdef IWM_DEBUG > +const char *iwm_desc_lookup(uint32_t); > void iwm_nic_error(struct iwm_softc *); > #endif > void iwm_notif_intr(struct iwm_softc *); > @@ -5761,6 +5761,7 @@ iwm_ioctl(struct ifnet *ifp, u_long cmd, > * The interrupt side of things > */ > > +#ifdef IWM_DEBUG > /* > * Note: This structure is read from the device with IO accesses, > * and the reading already does the endian conversion. As it is > @@ -5852,7 +5853,6 @@ iwm_desc_lookup(uint32_t num) > return advanced_lookup[i].name; > } > > -#ifdef IWM_DEBUG > /* > * Support for dumping the error log seemed like a good idea ... > * but it's mostly hex junk and the only sensible thing is the >
