Re: Support for UCD-SNMP-MIB in snmpd (part one)

2012-06-19 Thread Matthew Dempsky
[+joel] On Tue, Jun 19, 2012 at 2:11 PM, Seth Wright wrote: > I kind of thought the UCD-SNMP-MIB was fairly standard and/or > widespread, but perhaps not? HOST-RESOURCES-MIB is an RFC standard, which I assume gives it more stature than UCD-SNMP-MIB, but I honestly haven't used SNMP much in the l

Re: Support for UCD-SNMP-MIB in snmpd (part one)

2012-06-19 Thread Seth Wright
On Tue, Jun 19, 2012 at 4:49 PM, Matthew Dempsky wrote: > On Tue, Jun 19, 2012 at 1:35 PM, Vincent Bernat wrote: >> Maybe it would be better to implement standard MIB like >> HOST-RESOURCES-MIB. > > snmpd already supports HOST-RESOURCES-MIB. > > Seth, does your diff expose any new information tha

Re: compat_linux: Add socket type mask.

2012-06-19 Thread Philip Guenther
On Tue, Jun 19, 2012 at 1:26 AM, Paul Irofti wrote: > The newer glibc's, when creating a socket, add some higher bit flags to > the type argument that are used for debug, statistics, profiling > whatever. They are not useful and implementation specific. Aren't those SOCK_CLOEXEC and SOCK_NONBLOCK

Re: Support for UCD-SNMP-MIB in snmpd (part one)

2012-06-19 Thread Seth Wright
On Tue, Jun 19, 2012 at 4:35 PM, Vincent Bernat wrote: >  ❦ 16 juin 2012 22:32 CEST, Seth Wright  : > >> Matthew's UCD-DISKIO-MIB patch got me interested in adding support for >> the UCD-SNMP-MIB in snmpd. > > Maybe it would be better to implement standard MIB like > HOST-RESOURCES-MIB. A lot of

Re: Support for UCD-SNMP-MIB in snmpd (part one)

2012-06-19 Thread Matthew Dempsky
On Tue, Jun 19, 2012 at 1:35 PM, Vincent Bernat wrote: > Maybe it would be better to implement standard MIB like > HOST-RESOURCES-MIB. snmpd already supports HOST-RESOURCES-MIB. Seth, does your diff expose any new information that's not already available via snmpd? If not, I think we'd prefer t

Re: Support for UCD-SNMP-MIB in snmpd (part one)

2012-06-19 Thread Vincent Bernat
❦ 16 juin 2012 22:32 CEST, Seth Wright  : > Matthew's UCD-DISKIO-MIB patch got me interested in adding support for > the UCD-SNMP-MIB in snmpd. Maybe it would be better to implement standard MIB like HOST-RESOURCES-MIB. -- Keep it simple to make it faster. - The Elements of Programmi

Re: tweak libs to be -fpic

2012-06-19 Thread Miod Vallat
> > Come on Marc, you know better. That won't work on the vax, which > > has no PIC. > > LOL. I'm using PICFLAG, I'm hoping the vax has a define there. *MEEP* Same player shoot again. > Especially the second lib, what was its name, oh right, > lib/arch/amd64. And you mentioned libl initial

Re: minor patch for bgpd.conf man page

2012-06-19 Thread Claudio Jeker
On Tue, Jun 19, 2012 at 05:00:09PM +1000, Rod Whitworth wrote: > Found whilst paging down looking for something else... Funny, found that yesterday as well but had no time to commit it yet. > --- /usr/share/man/man5/bgpd.conf.5 Mon Feb 13 03:34:48 2012 > +++ bgpd.conf.5 Tue Jun 19 16:52:55

Re: tweak libs to be -fpic

2012-06-19 Thread Marc Espie
So, here's the same diff with shlib glue. If you think that's slightly insane, blame bsd.lib.mk ! Note: for now, there's only arch/libamd64. I don't feel qualified to comment/test/do the other arches if need be. Index: libl/Makefile ==

Re: [PATCH] uvideo(4): fix kernel crash when enumerating non-existant formats

2012-06-19 Thread Gregor Best
On Mon, Jun 18, 2012 at 05:46:00PM +0200, Martin Pieuchot wrote: > [...] > Thanks. Out of curiosity with which application did you find this? > [...] I tried playing around with my new webcam and used an uninitialized fmtdesc (mainly because I didn't understand the API then), which had a rather hi

Re: tweak libs to be -fpic

2012-06-19 Thread Marc Espie
On Tue, Jun 19, 2012 at 08:45:18AM -0600, Theo de Raadt wrote: > Oh whoops, I ok'd the previous! > > Come on Marc, you know better. That won't work on the vax, which > has no PIC. LOL. I'm using PICFLAG, I'm hoping the vax has a define there. I don't expect the corresponding software to wor

Re: tweak libs to be -fpic

2012-06-19 Thread Theo de Raadt
Oh whoops, I ok'd the previous! Come on Marc, you know better. That won't work on the vax, which has no PIC. As Mark said, it has to be done properly. > > Some ports want to aggregate these into shared objects... > > this tends to fail. > > > > Any negative side-effect ? > > I think this is

Re: tweak libs to be -fpic

2012-06-19 Thread Mark Kettenis
> Some ports want to aggregate these into shared objects... > this tends to fail. > > Any negative side-effect ? I think this is a really bad idea. You're going to end up with multiple copies of the code and you'll never be quite sure what copy ends up being used. Especially dangerous for dlo

Re: compat_linux: Fix counting in futex_wake.

2012-06-19 Thread Jasper Lievisse Adriaanse
On Tue, Jun 19, 2012 at 12:13:09PM +0300, Paul Irofti wrote: > Count should always be zero no matter if we need to relocate or not. > > Okay? Makes sense to me (including the other diffs you sent which I didn't reply to individually). > Index: linux_futex.c >

Re: tweak libs to be -fpic

2012-06-19 Thread Theo de Raadt
I suppose if people want screw themselves using multiple lex and run into trouble, it isn't our fault. Note that netbsd libc has yacc in it and oh boy, they've had a rough road there.

tweak libs to be -fpic

2012-06-19 Thread Marc Espie
Some ports want to aggregate these into shared objects... this tends to fail. Any negative side-effect ? Index: libl/Makefile === RCS file: /cvs/src/lib/libl/Makefile,v retrieving revision 1.4 diff -u -p -r1.4 Makefile --- libl/Make

compat_linux: Fix counting in futex_wake.

2012-06-19 Thread Paul Irofti
Count should always be zero no matter if we need to relocate or not. Okay? Index: linux_futex.c === RCS file: /cvs/src/sys/compat/linux/linux_futex.c,v retrieving revision 1.4 diff -u -p -r1.4 linux_futex.c --- linux_futex.c 19

compat_linux: Set appropiate retval on futex wait

2012-06-19 Thread Paul Irofti
Seems I forgot to set the return value after wakeup. Okay? Index: linux_futex.c === RCS file: /cvs/src/sys/compat/linux/linux_futex.c,v retrieving revision 1.4 diff -u -p -r1.4 linux_futex.c --- linux_futex.c 19 Jun 2012 08:50:5

compat_linux: Fix msleep and wakeup calls.

2012-06-19 Thread Paul Irofti
Try to sleep on the actual data address and not on the stack address of the pointer to the data. Avoids eternal sleep. Okay? Index: linux_futex.c === RCS file: /cvs/src/sys/compat/linux/linux_futex.c,v retrieving revision 1.4 diff -

compat_linux: Add extra argument validation.

2012-06-19 Thread Paul Irofti
Make things more robust... Okay? Index: linux_futex.c === RCS file: /cvs/src/sys/compat/linux/linux_futex.c,v retrieving revision 1.4 diff -u -p -r1.4 linux_futex.c --- linux_futex.c 19 Jun 2012 08:50:59 - 1.4 +++ linux

compat_linux: Implement tgkill

2012-06-19 Thread Paul Irofti
Needed for newer glibc, okay? Index: linux_signal.c === RCS file: /cvs/src/sys/compat/linux/linux_signal.c,v retrieving revision 1.14 diff -u -p -r1.14 linux_signal.c --- linux_signal.c 9 Dec 2009 16:29:56 - 1.14 +++ li

compat_linux: Add dummies for epoll and eventfd.

2012-06-19 Thread Paul Irofti
Okay? Index: linux_dummy.c === RCS file: /cvs/src/sys/compat/linux/linux_dummy.c,v retrieving revision 1.19 diff -u -p -r1.19 linux_dummy.c --- linux_dummy.c 14 Dec 2011 08:33:18 - 1.19 +++ linux_dummy.c 19 Jun 20

compat_linux: Add socket type mask.

2012-06-19 Thread Paul Irofti
The newer glibc's, when creating a socket, add some higher bit flags to the type argument that are used for debug, statistics, profiling whatever. They are not useful and implementation specific. This is needed for DNS resolving, otherwise the nss library from glibc will always fail to do the righ

minor patch for bgpd.conf man page

2012-06-19 Thread Rod Whitworth
Found whilst paging down looking for something else... --- /usr/share/man/man5/bgpd.conf.5 Mon Feb 13 03:34:48 2012 +++ bgpd.conf.5 Tue Jun 19 16:52:55 2012 @@ -30,7 +30,7 @@ in RFC 4271. .Sh SECTIONS The .Nm -config file is divided into four main sections. +config file is divided into fiv