Re: [tcpdump-workers] [PATCH net 1/2] net: dev_queue_xmit_nit: fix skb->vlan_tci field value

2013-01-09 Thread Eric Dumazet
On Wed, 2013-01-09 at 11:27 -0800, Ani Sinha wrote: > This is wrong. Accelerated or not, the kernel code was organized to > have the tags in the packet aux data. So I think this is how user land > should be coded as well. You have your opinion, thats good. My opinion as a kernel developer is tha

Re: [tcpdump-workers] vlan tagged packets and libpcap breakage

2012-12-13 Thread Eric Dumazet
On Tue, 2012-12-11 at 14:36 -0800, Ani Sinha wrote: > > > > It is possible to test for the presence of support of the new vlan bpf > > extensions by attempting to load a filter that uses them. As only valid > > filters can be loaded, old kernels that do not support filtering of vlan > > tags will

Re: [tcpdump-workers] twice past the taps, thence out to net?

2011-12-16 Thread Eric Dumazet
Le vendredi 16 décembre 2011 à 11:35 -0800, Rick Jones a écrit : > I would *love* to. All my accessible igb-driven hardware is in an > environment locked to the kernels already there :( Not that it makes it > more possible for me to do it, but I suspect it does not require 30 > receivers to r

Re: [tcpdump-workers] twice past the taps, thence out to net?

2011-12-16 Thread Eric Dumazet
Le vendredi 16 décembre 2011 à 10:28 -0800, Jesse Brandeburg a écrit : > On Thu, Dec 15, 2011 at 8:27 PM, Eric Dumazet wrote: > > Le jeudi 15 décembre 2011 à 14:22 -0800, Rick Jones a écrit : > >> On 12/15/2011 11:00 AM, Eric Dumazet wrote: > >> >> Device's

Re: [tcpdump-workers] twice past the taps, thence out to net?

2011-12-15 Thread Eric Dumazet
Le jeudi 15 décembre 2011 à 14:22 -0800, Rick Jones a écrit : > On 12/15/2011 11:00 AM, Eric Dumazet wrote: > >> Device's work better if the driver proactively manages > >> stop_queue/wake_queue. > >> Old devices used TX_BUSY, but newer devices tend

Re: [tcpdump-workers] twice past the taps, thence out to net?

2011-12-15 Thread Eric Dumazet
Le mercredi 14 décembre 2011 à 18:12 -0800, Vijay Subramanian a écrit : > On 14 December 2011 11:27, Rick Jones wrote: > > While looking at "something else" with tcpdump/tcptrace, tcptrace emitted > > lots of notices about hardware duplicated packets being detected (same TCP > > sequence number an

Re: [tcpdump-workers] twice past the taps, thence out to net?

2011-12-15 Thread Eric Dumazet
Le jeudi 15 décembre 2011 à 10:32 -0800, Rick Jones a écrit : > > More exactly, we call dev_queue_xmit_nit() from dev_hard_start_xmit() > > _before_ giving skb to device driver. > > > > If device driver returns NETDEV_TX_BUSY, and a qdisc was setup on the > > device, packet is requeued. > > > > Lat

Re: [tcpdump-workers] [net-2.6 PATCH] af_packet: move strict addr_len check right

2010-03-02 Thread Eric Dumazet
Le mercredi 03 mars 2010 à 07:40 +0100, Jiri Pirko a écrit : > Subject: [net-2.6 PATCH] af_packet: move strict addr_len check right before > dev_[mc/unicast]_[add/del] > > My previous patch 914c8ad2d18b62ad1420f518c0cab0b0b90ab308 incorrectly changed > the length check in packet_mc_add to be more