Re: [systemd-devel] cdrom_id and 60-cdrom_id.rules behavior

2015-01-15 Thread Andrei Borzenkov
В Thu, 15 Jan 2015 11:36:33 +0100 Martin Pitt пишет: > Andrei Borzenkov [2015-01-15 11:24 +0300]: > > So what's the point of locking tray in the first place if it will be > > unlocked as soon as you press eject button? > > So that we can do a clean unmount and avoid the situation in the > origin

Re: [systemd-devel] [PATCH] Fix systemd crash (on assert) during shutdown/reboot in unprivileged container

2015-01-15 Thread Stéphane Graber
On Thu, Jan 15, 2015 at 07:20:55PM +0100, Lennart Poettering wrote: > On Thu, 15.01.15 12:14, Stéphane Graber (stgra...@ubuntu.com) wrote: > > > Hello, > > > > The last big issue I'm running into when running systemd in an > > unprivileged LXC container is that it's crashing on an assert in the >

[systemd-devel] [PATCH 2/2] missing: add macros for OFD locks

2015-01-15 Thread Michael Marineau
--- src/shared/missing.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/shared/missing.h b/src/shared/missing.h index cdc38b2..d074405 100644 --- a/src/shared/missing.h +++ b/src/shared/missing.h @@ -79,6 +79,12 @@ #define F_SEAL_WRITE0x0008 /* prevent writes */ #endif +#if

[systemd-devel] [PATCH 1/2] networkd: accept a trailing '.' on the end of domains

2015-01-15 Thread Michael Marineau
While not common outside of BIND configs the implied top level '.' in domains is commonly accepted and crops up in random places. Starting with commit 784d9b9c networkd began validating domains as hostnames which rejects trailing dots, breaking short name resolution in some environments such as Goo

Re: [systemd-devel] Wierd Segfault in sd_rtnl_message_unref (libnss_myhostname.so.2 by sshd )

2015-01-15 Thread Svenne Krap
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Tom, I will be happy to run different tests, but I need a serious amount of handholding, as I haven't done this kind of work for ages... You could start with how I run it through Valgrind... (which I do have installed, but no clue how to use in

Re: [systemd-devel] [PATCH] Fix systemd crash (on assert) during shutdown/reboot in unprivileged container

2015-01-15 Thread Lennart Poettering
On Thu, 15.01.15 12:14, Stéphane Graber (stgra...@ubuntu.com) wrote: > Hello, > > The last big issue I'm running into when running systemd in an > unprivileged LXC container is that it's crashing on an assert in the > shutdown/reboot path right after unmounting all devices. > > That's because du

Re: [systemd-devel] [PATCH] units: move machines.target to dist_systemunit_DATA

2015-01-15 Thread Ronny Chevalier
2014-12-30 0:22 GMT+01:00 Filipe Brandenburger : > Move units/machines.target from nodist_systemunit_DATA to > dist_systemunit_DATA, > since it's not a generated file. Otherwise, `make clean` would remove the > committed copy of the file. > > Tested that `./autogen.sh c` will not remove it and tha

[systemd-devel] [PATCH] Fix systemd crash (on assert) during shutdown/reboot in unprivileged container

2015-01-15 Thread Stéphane Graber
Hello, The last big issue I'm running into when running systemd in an unprivileged LXC container is that it's crashing on an assert in the shutdown/reboot path right after unmounting all devices. That's because due to mknod not being allowed inside a user namespace, we have to bind-mount all the

Re: [systemd-devel] [PATCH] Add support for "ROOT=" on the kernel command line

2015-01-15 Thread Harald Hoyer
On 15.01.2015 16:51, Harald Hoyer wrote: > On 15.01.2015 16:45, Harald Hoyer wrote: >> On 15.01.2015 16:24, har...@redhat.com wrote: >>> From: Harald Hoyer >>> >>> "ROOT=" mounts the initial ramdisk with a tmpfs filesystem. >> >> Ok, not true. Omitting "root=" will mount the initial ramdisk as a t

Re: [systemd-devel] [PATCH] cdrom_id: unmount media on --eject-media if media mounted

2015-01-15 Thread Kay Sievers
On Thu, Jan 15, 2015 at 5:13 PM, Robert Milasan wrote: > On Thu, 15 Jan 2015 17:05:54 +0100 > "Lennart Poettering" wrote: >> >> I think the best way to fix this is in the kernel properly. And if the >> kernel folks are not willing to do add code for that, then I think >> it's still better to make

Re: [systemd-devel] [PATCH] cdrom_id: unmount media on --eject-media if media mounted

2015-01-15 Thread Robert Milasan
On Thu, 15 Jan 2015 17:05:54 +0100 "Lennart Poettering" wrote: > > I think the best way to fix this is in the kernel properly. And if the > kernel folks are not willing to do add code for that, then I think > it's still better to make sure systemd unmounts it. It can do so > asynchronously, simpl

Re: [systemd-devel] [PATCH] cdrom_id: unmount media on --eject-media if media mounted

2015-01-15 Thread Lennart Poettering
On Thu, 15.01.15 15:24, Robert Milasan (rmila...@suse.com) wrote: > Signed-off-by: Robert Milasan Humm, I am not convinced that this is really a good idea, first of all it's pretty incomplete, given that there atons of ways how a device can be kept busy, and mounts are just one of it. And even m

Re: [systemd-devel] [PATCH] Add support for "ROOT=" on the kernel command line

2015-01-15 Thread Harald Hoyer
On 15.01.2015 16:45, Harald Hoyer wrote: > On 15.01.2015 16:24, har...@redhat.com wrote: >> From: Harald Hoyer >> >> "ROOT=" mounts the initial ramdisk with a tmpfs filesystem. > > Ok, not true. Omitting "root=" will mount the initial ramdisk as a tmpfs > filesystem, if tmpfs support is compiled

Re: [systemd-devel] [PATCH] Add support for "ROOT=" on the kernel command line

2015-01-15 Thread Harald Hoyer
On 15.01.2015 16:24, har...@redhat.com wrote: > From: Harald Hoyer > > "ROOT=" mounts the initial ramdisk with a tmpfs filesystem. Ok, not true. Omitting "root=" will mount the initial ramdisk as a tmpfs filesystem, if tmpfs support is compiled in the kernel. Seems like the preferred way of hav

Re: [systemd-devel] [PATCH] LLDP: Support locally assigned port subtype

2015-01-15 Thread Tom Gundersen
Thanks to both. Pushed! On Thu, Jan 15, 2015 at 9:33 AM, Mantas Mikulėnas wrote: > On Thu, Jan 15, 2015 at 9:11 AM, Susant Sahani wrote: >> >> The Zyxel switch sends port subtype as Locally assigned (7). >> Add LLDP_PORT_SUBTYPE_LOCALLY_ASSIGNED as supported type >> >> reported by Mantas Mikulėn

[systemd-devel] [PATCH] Add support for "ROOT=" on the kernel command line

2015-01-15 Thread harald
From: Harald Hoyer "ROOT=" mounts the initial ramdisk with a tmpfs filesystem. --- src/fstab-generator/fstab-generator.c | 5 + src/gpt-auto-generator/gpt-auto-generator.c | 7 +++ 2 files changed, 12 insertions(+) diff --git a/src/fstab-generator/fstab-generator.c b/src/fstab-ge

Re: [systemd-devel] [PATCH] cdrom_id: unmount media on --eject-media if media mounted

2015-01-15 Thread Robert Milasan
On Thu, 15 Jan 2015 15:42:28 +0100 "Martin Pitt" wrote: > Hey Robert, > > thanks for working on this! > > Robert Milasan [2015-01-15 15:24 +0100]: > > +err = execl("/bin/umount", "/bin/umount", > > node, NULL); > > If this succeeds, umount will completely "take over" th

Re: [systemd-devel] [PATCH] cdrom_id: unmount media on --eject-media if media mounted

2015-01-15 Thread Martin Pitt
Hey Robert, thanks for working on this! Robert Milasan [2015-01-15 15:24 +0100]: > +err = execl("/bin/umount", "/bin/umount", > node, NULL); If this succeeds, umount will completely "take over" the process, and cdrom_id is gone. This also isn't sufficient if there are mu

[systemd-devel] [PATCH] cdrom_id: unmount media on --eject-media if media mounted

2015-01-15 Thread Robert Milasan
Signed-off-by: Robert Milasan --- src/udev/cdrom_id/cdrom_id.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/src/udev/cdrom_id/cdrom_id.c b/src/udev/cdrom_id/cdrom_id.c index 6052f6a..72a1357 100644 --- a/src/udev/cdrom_id/cdrom_id.c +++ b/src/udev/cdrom

Re: [systemd-devel] Readahead collect - root filesystem only?

2015-01-15 Thread Nikolai Zhubr
Hi, 15.01.2015 16:31, Reindl Harald: [...] it was completly removed with no replacement by assuming eveorybody in a short term will use only SSD drives http://lists.freedesktop.org/archives/systemd-devel/2014-August/022002.html Thanks. The reasoning may well be valid, but this still does not

Re: [systemd-devel] Readahead collect - root filesystem only?

2015-01-15 Thread Tom Gundersen
On Thu, Jan 15, 2015 at 2:38 PM, Reindl Harald wrote: > > Am 15.01.2015 um 14:33 schrieb Zbigniew Jędrzejewski-Szmek: >> >> On Thu, Jan 15, 2015 at 02:31:22PM +0100, Reindl Harald wrote: >>> >>> Am 15.01.2015 um 14:40 schrieb Nikolai Zhubr: 15.01.2015 16:07, Cristian Rodríguez: > >>>

Re: [systemd-devel] Readahead collect - root filesystem only?

2015-01-15 Thread Cristian Rodríguez
El 15/01/15 a las 10:40, Nikolai Zhubr escribió: Hi, 15.01.2015 16:07, Cristian Rodríguez: The readahead collector is no longer included in systemd. Hm. It is still there in not-very-old opensuse 13.2 ... for whatever reason, current openSUSE releases have systemd 210.. that's old. Anyw

Re: [systemd-devel] Readahead collect - root filesystem only?

2015-01-15 Thread Pacho Ramos
El jue, 15-01-2015 a las 14:38 +0100, Reindl Harald escribió: > Am 15.01.2015 um 14:33 schrieb Zbigniew Jędrzejewski-Szmek: > > On Thu, Jan 15, 2015 at 02:31:22PM +0100, Reindl Harald wrote: > >> Am 15.01.2015 um 14:40 schrieb Nikolai Zhubr: > >>> 15.01.2015 16:07, Cristian Rodríguez: > The re

Re: [systemd-devel] Readahead collect - root filesystem only?

2015-01-15 Thread Reindl Harald
Am 15.01.2015 um 14:33 schrieb Zbigniew Jędrzejewski-Szmek: On Thu, Jan 15, 2015 at 02:31:22PM +0100, Reindl Harald wrote: Am 15.01.2015 um 14:40 schrieb Nikolai Zhubr: 15.01.2015 16:07, Cristian Rodríguez: The readahead collector is no longer included in systemd. Hm. It is still there in n

Re: [systemd-devel] Readahead collect - root filesystem only?

2015-01-15 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jan 15, 2015 at 02:31:22PM +0100, Reindl Harald wrote: > > Am 15.01.2015 um 14:40 schrieb Nikolai Zhubr: > >15.01.2015 16:07, Cristian Rodríguez: > >>The readahead collector is no longer included in systemd. > > > >Hm. It is still there in not-very-old opensuse 13.2 ... > >Anyway. Where ha

Re: [systemd-devel] Readahead collect - root filesystem only?

2015-01-15 Thread Reindl Harald
Am 15.01.2015 um 14:40 schrieb Nikolai Zhubr: 15.01.2015 16:07, Cristian Rodríguez: The readahead collector is no longer included in systemd. Hm. It is still there in not-very-old opensuse 13.2 ... Anyway. Where has it gone then? Is it a separate tool now or got obsoleted by something else? I

Re: [systemd-devel] Readahead collect - root filesystem only?

2015-01-15 Thread Nikolai Zhubr
Hi, 15.01.2015 16:07, Cristian Rodríguez: The readahead collector is no longer included in systemd. Hm. It is still there in not-very-old opensuse 13.2 ... Anyway. Where has it gone then? Is it a separate tool now or got obsoleted by something else? I actually just started to like it... Quit

Re: [systemd-devel] [PATCH udev v5] udev: Add builtin/rule to export evdev information as udev properties

2015-01-15 Thread David Herrmann
Hi On Mon, Jan 12, 2015 at 5:52 AM, Zbigniew Jędrzejewski-Szmek wrote: > On Sun, Jan 11, 2015 at 08:47:19PM +0100, Carlos Garnacho wrote: >> This rule is only run on tablet/touchscreen devices, and extracts their size >> in millimeters, as it can be found out through their struct input_absinfo. >

Re: [systemd-devel] Readahead collect - root filesystem only?

2015-01-15 Thread Cristian Rodríguez
El 15/01/15 a las 09:38, Nikolai Zhubr escribió: Hi all, Is it true that readahead collector defaults to only collect files within root filesystem? If so, is it possible to instruct it to also collect for e.g. /home (mounted on a separate media)? This is not mentioned anywhere in the docs. It

Re: [systemd-devel] systemctl status not showing still running processes in inactive .mount unit cgroups (NFS specifically)

2015-01-15 Thread Simon McVittie
On 15/01/15 09:28, Colin Guthrie wrote: > Although if the script is in bash I'd use "if [ -d ..." rather than "if > test -d ..." as (and bash experts (Harald?) can correct me here if I'm > wrong) I believe [ is a bash built in (even if it is a binary in > /usr/bin/), whereas it would have to fork

[systemd-devel] Readahead collect - root filesystem only?

2015-01-15 Thread Nikolai Zhubr
Hi all, Is it true that readahead collector defaults to only collect files within root filesystem? If so, is it possible to instruct it to also collect for e.g. /home (mounted on a separate media)? This is not mentioned anywhere in the docs. It probably should be? Thank you, Nikolai _

Re: [systemd-devel] systemctl status not showing still running processes in inactive .mount unit cgroups (NFS specifically)

2015-01-15 Thread Harald Hoyer
On 15.01.2015 10:28, Colin Guthrie wrote: > Although if the script is in bash I'd use "if [ -d ..." rather than "if > test -d ..." as (and bash experts (Harald?) can correct me here if I'm > wrong) I believe [ is a bash built in (even if it is a binary in > /usr/bin/), whereas it would have to for

Re: [systemd-devel] cdrom_id and 60-cdrom_id.rules behavior

2015-01-15 Thread Robert Milasan
On Thu, 15 Jan 2015 12:22:50 +0100 "Robert Milasan" wrote: > On Thu, 15 Jan 2015 12:00:15 +0100 > "Oliver Neukum" wrote: > > > On Thu, 2015-01-15 at 11:38 +0100, Martin Pitt wrote: > > > Oliver Neukum [2015-01-15 11:31 +0100]: > > > > No, the events are generated. And it is processed. > > > > T

Re: [systemd-devel] systemd-networkd quietly ignores DHCPv6 leases

2015-01-15 Thread Barbara Lazarowicz-Steube
On 2015-01-15 09:58, Patrik Flykt wrote: > Indeed. I so thought I had a patch applied that set the DHCPv6 address > for the interface. Apparently such functionality has gone into /dev/null > instead, and as a result you will need the next version of the DHCPv6 > address assignment patch recently p

Re: [systemd-devel] cdrom_id and 60-cdrom_id.rules behavior

2015-01-15 Thread Robert Milasan
On Thu, 15 Jan 2015 12:00:15 +0100 "Oliver Neukum" wrote: > On Thu, 2015-01-15 at 11:38 +0100, Martin Pitt wrote: > > Oliver Neukum [2015-01-15 11:31 +0100]: > > > No, the events are generated. And it is processed. > > > There is just no unmounting. > > > > That sounds like a bug/missing feature

Re: [systemd-devel] [PATCH 0/3] Miscellaneous systemd changes (v2)

2015-01-15 Thread Steve Dickson
On 01/14/2015 10:46 AM, Steve Dickson wrote: > v2: > * Corrected the numerous BindTo typos > > Here are a few systemd changes that were suggested > by the systemd folks: > >* Bind the nfs-idmap service to the nfs server. >* Correctly bind nfs-mountd service to the nfs server. >*

Re: [systemd-devel] cdrom_id and 60-cdrom_id.rules behavior

2015-01-15 Thread Oliver Neukum
On Thu, 2015-01-15 at 11:38 +0100, Martin Pitt wrote: > Oliver Neukum [2015-01-15 11:31 +0100]: > > No, the events are generated. And it is processed. > > There is just no unmounting. > > That sounds like a bug/missing feature in cdrom_id --eject-media then. > You could try and replace it with /us

Re: [systemd-devel] cdrom_id and 60-cdrom_id.rules behavior

2015-01-15 Thread Robert Milasan
On Thu, 15 Jan 2015 11:38:33 +0100 "Martin Pitt" wrote: > Oliver Neukum [2015-01-15 11:31 +0100]: > > No, the events are generated. And it is processed. > > There is just no unmounting. > > That sounds like a bug/missing feature in cdrom_id --eject-media then. > You could try and replace it with

Re: [systemd-devel] cdrom_id and 60-cdrom_id.rules behavior

2015-01-15 Thread Robert Milasan
On Thu, 15 Jan 2015 11:39:36 +0100 "Robert Milasan" wrote: > On Thu, 15 Jan 2015 11:31:48 +0100 > "Oliver Neukum" wrote: > > > On Thu, 2015-01-15 at 09:03 +0100, Martin Pitt wrote: > > > - udev rules (60-cdrom_id.rules) picks that up and calls "eject > > >/dev/srX" on the device; the eject

Re: [systemd-devel] cdrom_id and 60-cdrom_id.rules behavior

2015-01-15 Thread Robert Milasan
On Thu, 15 Jan 2015 11:31:48 +0100 "Oliver Neukum" wrote: > On Thu, 2015-01-15 at 09:03 +0100, Martin Pitt wrote: > > - udev rules (60-cdrom_id.rules) picks that up and calls "eject > >/dev/srX" on the device; the eject program takes care to unmount > >everything before physical ejection

Re: [systemd-devel] cdrom_id and 60-cdrom_id.rules behavior

2015-01-15 Thread Martin Pitt
Oliver Neukum [2015-01-15 11:31 +0100]: > No, the events are generated. And it is processed. > There is just no unmounting. That sounds like a bug/missing feature in cdrom_id --eject-media then. You could try and replace it with /usr/bin/eject, which does the unmounting of all partitions first, fa

Re: [systemd-devel] cdrom_id and 60-cdrom_id.rules behavior

2015-01-15 Thread Martin Pitt
Andrei Borzenkov [2015-01-15 11:24 +0300]: > So what's the point of locking tray in the first place if it will be > unlocked as soon as you press eject button? So that we can do a clean unmount and avoid the situation in the original post :-) Also, we can delay or fail the unlocking and ejection i

Re: [systemd-devel] cdrom_id and 60-cdrom_id.rules behavior

2015-01-15 Thread Oliver Neukum
On Thu, 2015-01-15 at 09:03 +0100, Martin Pitt wrote: > - udev rules (60-cdrom_id.rules) picks that up and calls "eject >/dev/srX" on the device; the eject program takes care to unmount >everything before physical ejection. > > Note that the kernel will *not* generate DISK_EJECT_REQUEST u

Re: [systemd-devel] systemctl status not showing still running processes in inactive .mount unit cgroups (NFS specifically)

2015-01-15 Thread Colin Guthrie
Ross Lagerwall wrote on 14/01/15 22:41: > On Mon, Jan 12, 2015 at 09:04:35PM +0300, Andrei Borzenkov wrote: >> В Mon, 12 Jan 2015 10:34:07 + >> Colin Guthrie пишет: >> >>> >>> Anyway, assuming the process is in the .mount unit cgroup, should >>> systemd detect the umount and kill the processes

Re: [systemd-devel] systemctl status not showing still running processes in inactive .mount unit cgroups (NFS specifically)

2015-01-15 Thread Colin Guthrie
Steve Dickson wrote on 15/01/15 00:50: > Hello, > > On 01/12/2015 04:43 PM, Colin Guthrie wrote: >> >> But FWIW, your check for whether systemctl is installed via calling >> "systemctl --help" is IMO not very neat. >> >> If you're using bash here anyway, you might as well just do a: >> >> if [ -d

Re: [systemd-devel] systemd-networkd quietly ignores DHCPv6 leases

2015-01-15 Thread Patrik Flykt
Hi, On Wed, 2015-01-14 at 16:37 +0100, Barbara Lazarowicz-Steube wrote: > As you can see in it, having received the RA networkd correctly > identifies the local network as managed and fires up the DHCPv6 > client. The client then receives a reply from the server and... does > absolutely n

Re: [systemd-devel] [PATCH] LLDP: Support locally assigned port subtype

2015-01-15 Thread Mantas Mikulėnas
On Thu, Jan 15, 2015 at 9:11 AM, Susant Sahani wrote: > The Zyxel switch sends port subtype as Locally assigned (7). > Add LLDP_PORT_SUBTYPE_LOCALLY_ASSIGNED as supported type > > reported by Mantas Mikulėnas > --- > src/libsystemd-network/lldp-internal.c | 1 + > 1 file changed, 1 insertion(+)

Re: [systemd-devel] cdrom_id and 60-cdrom_id.rules behavior

2015-01-15 Thread Andrei Borzenkov
On Thu, Jan 15, 2015 at 11:03 AM, Martin Pitt wrote: > Hello all, > > Robert Milasan [2015-01-12 9:39 +0100]: >> 1. add a CD/DVD into the driver >> 2. mount the driver: mount /dev/sr0 /mnt/my_cd (ensure you don't >> use the Gnome/KDE auto-mounting or reproduce this in a server setup) >> 3. eject

Re: [systemd-devel] cdrom_id and 60-cdrom_id.rules behavior

2015-01-15 Thread Martin Pitt
Hello all, Robert Milasan [2015-01-12 9:39 +0100]: > 1. add a CD/DVD into the driver > 2. mount the driver: mount /dev/sr0 /mnt/my_cd (ensure you don't > use the Gnome/KDE auto-mounting or reproduce this in a server setup) > 3. eject the media (using the hardware button) and add a new one media >