[systemd-devel] [PATCH 4/4] Add binary password agent protocol

2014-02-03 Thread David Härdeman
Add binary string handling functions and extend the password agent protocol to support binary strings (using "=" as a string prefix instead of "+"). --- Makefile.am|2 src/ask-password/ask-password.c| 33 +-- src/cryptsetup/cryptse

[systemd-devel] [PATCH 3/4] Fix askpass buffer overflow

2014-02-03 Thread David Härdeman
Fix askpass overflow in reading a passphrase from a tty. Doesn't seem security sensitive, but add a check for correctness. --- src/shared/ask-password-api.c |5 + 1 file changed, 5 insertions(+) diff --git a/src/shared/ask-password-api.c b/src/shared/ask-password-api.c index 553debc..499e

[systemd-devel] [PATCH 2/4] Fix keysize handling in cryptsetup (bits vs. bytes)

2014-02-03 Thread David Härdeman
The command line key-size is in bits but the libcryptsetup API expects bytes. --- src/cryptsetup/cryptsetup.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/cryptsetup/cryptsetup.c b/src/cryptsetup/cryptsetup.c index 4a32856..c01ed01 100644 --- a/src/cryptsetup/

[systemd-devel] [PATCH 1/4] Add more password agent information

2014-02-03 Thread David Härdeman
Add (optional) "Purpose" and "Target" keys in the password agent .ask files. These are used to provide more information on what the requested passphrase is to be used for (which e.g. allows an agent to only listen to cryptsetup requests). --- src/ask-password/ask-password.c | 22

[systemd-devel] [PATCH 0/4] Preparation series for binary passphrases

2014-02-03 Thread David Härdeman
The following series contains some preparatory patches to support binary strings as passphrases when using password agents (my goal is to implement support for the "keyscript=" parameter for cryptsetup using an agent). These patches are very lightly tested since I wanted to get some feedback and s

Re: [systemd-devel] Patch to fix hint message

2014-02-03 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Feb 03, 2014 at 04:24:02PM -0500, Jason St. John wrote: > On Feb 3, 2014 1:10 PM, "[email protected]" > wrote: > > > > The use of the ... (ellipsis) is to "elide" text. > > Ellipsized is not in the dictionary. In principle we can and do make up words quite often. But I agree that 'to

Re: [systemd-devel] [PATCH] s390/getty-generator: initialize essential system terminals/consoles

2014-02-03 Thread Kay Sievers
On Mon, Feb 3, 2014 at 2:44 PM, Hannes Reinecke wrote: > On 01/31/2014 05:08 PM, Hendrik Brueckner wrote: >> Ensure to start getty programs on all essential system consoles on Linux on >> System z. Add these essential devices to the list of virtualization_consoles >> to always generate getty conf

Re: [systemd-devel] Patch to fix hint message

2014-02-03 Thread Jason St. John
On Feb 3, 2014 1:10 PM, "[email protected]" wrote: > > The use of the ... (ellipsis) is to "elide" text. > Ellipsized is not in the dictionary. > > If you are willing to take this fix I could develop a patch to fix the > variables used in the code as well. > > Barry > > > --- systemd-208/src/

Re: [systemd-devel] [PATCH] udev: Adding zram to inappropriate block device

2014-02-03 Thread Greg KH
On Mon, Feb 03, 2014 at 10:36:58AM +0100, Holger Schurig wrote: > > with unit type ending in .zswap > > No, not another unit type. Instead better amend .swap unit types to > also know about ZRAM. > > However, isn't this a bit early? Shouldn't move ZRAM first move out of > staging? It was moved

[systemd-devel] Patch to fix hint message

2014-02-03 Thread [email protected]
The use of the ... (ellipsis) is to "elide" text. Ellipsized is not in the dictionary. If you are willing to take this fix I could develop a patch to fix the variables used in the code as well. Barry --- systemd-208/src/systemctl/systemctl.c.orig 2014-02-03 17:02:32.830744599 + +++ syste

Re: [systemd-devel] [PATCH] s390/getty-generator: initialize essential system terminals/consoles

2014-02-03 Thread Hendrik Brueckner
On Mon, Feb 03, 2014 at 02:44:43PM +0100, Hannes Reinecke wrote: > On 01/31/2014 05:08 PM, Hendrik Brueckner wrote: > > Ensure to start getty programs on all essential system consoles on Linux on > > System z. Add these essential devices to the list of > > virtualization_consoles > > to always ge

Re: [systemd-devel] [PATCH] udev: Adding zram to inappropriate block device

2014-02-03 Thread Holger Schurig
> with unit type ending in .zswap No, not another unit type. Instead better amend .swap unit types to also know about ZRAM. However, isn't this a bit early? Shouldn't move ZRAM first move out of staging? ___ systemd-devel mailing list systemd-devel@list

Re: [systemd-devel] StartTransientService problems

2014-02-03 Thread [email protected]
On Fri 31 Jan 2014 16:42:04 Barry Scott wrote: > I have finally managed to get StartTransientService to run a process for me > but I'm encountering issues: > > we start a daemon that calls StartTransientService as required. The daemon > does not run as root, it runs as "onelan". We configure dbus

Re: [systemd-devel] [PATCH] s390/getty-generator: initialize essential system terminals/consoles

2014-02-03 Thread Hannes Reinecke
On 01/31/2014 05:08 PM, Hendrik Brueckner wrote: > Ensure to start getty programs on all essential system consoles on Linux on > System z. Add these essential devices to the list of virtualization_consoles > to always generate getty configurations. > > For the sake of completion, the list of esse

Re: [systemd-devel] [PATCH] s390/getty-generator: initialize essential system terminals/consoles

2014-02-03 Thread Dr. Werner Fink
On Mon, Feb 03, 2014 at 03:07:04PM +0100, Hendrik Brueckner wrote: > On Mon, Feb 03, 2014 at 02:44:43PM +0100, Hannes Reinecke wrote: > > > But that's not a requirement anywhere in the console code. > > Quite the contrary; tty drivers have the 'first_minor' entry > > to explicit request an offset

Re: [systemd-devel] [PATCH] Fix a typo

2014-02-03 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Feb 03, 2014 at 09:20:01AM +0100, Stefan Beller wrote: > On 03.02.2014 05:55, Zbigniew Jędrzejewski-Szmek wrote: > > On Sun, Feb 02, 2014 at 11:03:06PM +0100, Stefan Beller wrote: > >> --- > >> src/libsystemd/sd-bus/PORTING-DBUS1 | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [systemd-devel] [PATCH] udev: Adding zram to inappropriate block device

2014-02-03 Thread Jóhann B. Guðmundsson
On 02/03/2014 09:36 AM, Holger Schurig wrote: with unit type ending in .zswap No, not another unit type. Instead better amend .swap unit types to also know about ZRAM. However, isn't this a bit early? Shouldn't move ZRAM first move out of staging? Ofcourse but when it does move out of stagin

Re: [systemd-devel] [PATCH] Fix a typo

2014-02-03 Thread Stefan Beller
On 03.02.2014 05:55, Zbigniew Jędrzejewski-Szmek wrote: > On Sun, Feb 02, 2014 at 11:03:06PM +0100, Stefan Beller wrote: >> --- >> src/libsystemd/sd-bus/PORTING-DBUS1 | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/libsystemd/sd-bus/PORTING-DBUS1 >> b/src/libsystem