Re: [systemd-devel] [PATCH] util, utf8: recognize wide characters in wellipsize_mem()

2013-08-28 Thread Shawn
here is the test runner I am using, doesn't really make sense to add this to the tree as it has to be visually inspected diff --git a/Makefile.am b/Makefile.am index cdbfdea..8813299 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1124,6 +1124,7 @@ tests += \ test-unit-file \ test-u

[systemd-devel] [PATCH] util, utf8: recognize wide characters in wellipsize_mem()

2013-08-28 Thread Shawn Landden
--- src/shared/utf8.c | 64 +++ src/shared/utf8.h | 4 +++- src/shared/util.c | 19 ++--- src/shared/util.h | 1 + 4 files changed, 84 insertions(+), 4 deletions(-) diff --git a/src/shared/utf8.c b/src/shared/utf8.c index 8a37c3a..

[systemd-devel] [PATCH] util, utf8: new wellipsize and wellipsize_mem that take into account multi-byte characters

2013-08-28 Thread Shawn Landden
This version counts all multibyte characters as 1 width, not taking into account double width cjk characters and zerowidth characters --- TODO | 4 --- src/shared/utf8.c | 56 +++ src/shared/utf8.h | 98 +

Re: [systemd-devel] [PATCH] util: ellipsize_mem: do not print partial utf-8 characters

2013-08-28 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Aug 28, 2013 at 12:36:10PM -0700, Shawn Landden wrote: > --- > src/shared/util.c | 13 ++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/src/shared/util.c b/src/shared/util.c > index 1dde8af..9af99aa 100644 > --- a/src/shared/util.c > +++ b/src/shared/util.

[systemd-devel] [PATCH resend] getty-generator: Enable getty on all active serial consoles.

2013-08-28 Thread Michael Marineau
This enables a getty on active kernel consoles even when they are not the last one specified on the kernel command line and mapped to /dev/console. Now the order "console=ttyS0 console=tty0" works in addition to "console=tty0 console=ttyS0". --- src/getty-generator/getty-generator.c | 37 +

[systemd-devel] [PATCH] util: ellipsize_mem: do not print partial utf-8 characters

2013-08-28 Thread Shawn Landden
--- src/shared/util.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/shared/util.c b/src/shared/util.c index 1dde8af..9af99aa 100644 --- a/src/shared/util.c +++ b/src/shared/util.c @@ -3286,7 +3286,7 @@ int running_in_chroot(void) { } char *ellipsize_mem

[systemd-devel] [PATCH] service: remove pidfile after exit of a service

2013-08-28 Thread Lukas Nykryn
--- TODO | 2 -- src/core/service.c | 4 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/TODO b/TODO index fe305ec..3527970 100644 --- a/TODO +++ b/TODO @@ -60,8 +60,6 @@ Features: * better error message if you run systemctl without systemd running -* unlink

Re: [systemd-devel] Fedora 19 hangs on startup: A start job is running for Monitoring of LVM2 mirror...rogress polling

2013-08-28 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Aug 22, 2013 at 09:07:09AM -0700, Ben Greear wrote: > I have a E5 processor system with 128GB SSD freshly installed and updated > with Fedora 19. After the initial boot, I added MATE, put system at runlevel > 3, > removed 'initial-setup' package, and so forth. System is > configured for

Re: [systemd-devel] [206] Using `systemd --user` to manage user's session -- is it still possible?

2013-08-28 Thread Mantas Mikulėnas
Partial reply: On Wed, Aug 28, 2013 at 10:15 AM, Ivan Shapovalov wrote: > With v206, that stopped working. It seems that `systemd --user` now must be > launched > 1) with PAMName=systemd-shared > […] > 3) with /etc/pam.d/systemd-shared symlinked to system-login or whatever >(see https://bugs.

Re: [systemd-devel] [PATCH] cgroup: only check once when mode is UNIT_CHECK

2013-08-28 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Aug 26, 2013 at 10:36:45AM +0800, Gao feng wrote: > If the mode is UNIT_CHECK,it means we only want to check if > the paramaters are valid. the first round of cycle already > did this check, no need to check again. Applied. Zbyszek ___ systemd-de

Re: [systemd-devel] [PATCH v2] device cgroup: don't create a new CGroupDeviceAllow when it already in the list

2013-08-28 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Aug 28, 2013 at 09:49:11AM +0800, Gao feng wrote: > If a device node is already in the device_allow list of > CGroupContext, we should replace it instead of create a > new one and append this new one to the end of device_allow > list. > > change from v1: use streq to replace !strcmp Applie

Re: [systemd-devel] [PATCH] blcokio bandwidth: add missing set of CGroupBlockIODeviceBandwidth's read

2013-08-28 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Aug 28, 2013 at 12:10:16PM +0800, Gao feng wrote: > BlockIOReadBandwidth and BlockIOWriteBandwidth both use > config_parse_blockio_bandwidth to set up CGroupBlockIODeviceBandwidth, > We should set the read value based on the left values > in config files. Applied. Zbyszek _

Re: [systemd-devel] implies "MemoryAccounting=true"

2013-08-28 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Aug 26, 2013 at 11:19:54AM +0800, Gao feng wrote: > Hi > > The SYSTEMD.CGROUP(5) said if MemoryLimit=bytes is set for unit, it > implies MemeoryAccounting=true for this unit. > > But seems systemd didn't implement this hint. CPUShares & BlockIO have > the same problem, this is a shortage?

Re: [systemd-devel] Convert Inittab-Entry to systemd

2013-08-28 Thread Colin Guthrie
'Twas brillig, and Daniel Spannbauer at 28/08/13 07:36 did gyre and gimble: > Here is the service-file: > > [Unit] > Description=marco Autologin > After=getty.target > > [Service] > ExecStart=/usr/bin/xinit /home/xalz/.xsession -- /usr/bin/X :1 vt08 -r > -br -dpms -s off > User=xalz > PAMName=xal

[systemd-devel] [206] Using `systemd --user` to manage user's session -- is it still possible?

2013-08-28 Thread Ivan Shapovalov
Hello! With systemd v204 and earlier, I used `systemd --user` to manage my complete session, including X server (via xorg-launch-helper) and all related things. I used a slightly modified [email protected] unit to start the `systemd --user` instance in its own session to get PolicyKit workin