Re: [systemd-devel] how to start a service when another sevice stops

2012-11-30 Thread Reindl Harald
Am 30.11.2012 23:28, schrieb Khem Raj: > I have a scenario where, I have foo.service which runs on boot and later > bar.service runs and it has to stop > foo.service which I achieved by declaring it as Conflicts= in the unit file > but I would like to restart foo.service > when bar.service is s

[systemd-devel] how to start a service when another sevice stops

2012-11-30 Thread Khem Raj
Hi I have a scenario where, I have foo.service which runs on boot and later bar.service runs and it has to stop foo.service which I achieved by declaring it as Conflicts= in the unit file but I would like to restart foo.service when bar.service is stopped. I have run out of ideas on how to achieve

Re: [systemd-devel] 4 failing tests

2012-11-30 Thread Timothy Pepper
On Fri 30 Nov at 19:26:21 +0100 [email protected] said: > > > > It would be nice to at least do an overmount in cases where something > > sane for a default could be created at boot. > > We obviously cannot over mount a non-existing file :) You have to > leave it empty, then we will do that. I suppos

Re: [systemd-devel] [PATCH] *.py: don't hardcode /usr/bin/python

2012-11-30 Thread Colin Walters
On Fri, 2012-11-30 at 21:49 +0100, Michael Biebl wrote: > 2012/11/30 Ramkumar Ramachandra : > > Execute python using "/usr/bin/env python" instead of hard-coding the > > I'm not really a fan of using /usr/bin/env, as you can pick up a > random python version depending on how your PATH is setup. >

Re: [systemd-devel] [PATCH] *.py: don't hardcode /usr/bin/python

2012-11-30 Thread Michael Biebl
2012/11/30 Ramkumar Ramachandra : > Execute python using "/usr/bin/env python" instead of hard-coding the I'm not really a fan of using /usr/bin/env, as you can pick up a random python version depending on how your PATH is setup. Besides, you need to spawn an additional binary. I would assume that

Re: [systemd-devel] 4 failing tests

2012-11-30 Thread Kay Sievers
On Fri, Nov 30, 2012 at 6:43 PM, Timothy Pepper wrote: > On Fri 30 Nov at 13:58:43 +0100 [email protected] said: >> On Fri, Nov 30, 2012 at 1:45 PM, Ramkumar Ramachandra >> wrote: >> > Kay Sievers wrote: >> >> On Fri, Nov 30, 2012 at 1:28 PM, Zbigniew Jędrzejewski-Szmek >> >> wrote: >> >> >> >>> It'

Re: [systemd-devel] 4 failing tests

2012-11-30 Thread Timothy Pepper
On Fri 30 Nov at 13:58:43 +0100 [email protected] said: > On Fri, Nov 30, 2012 at 1:45 PM, Ramkumar Ramachandra > wrote: > > Kay Sievers wrote: > >> On Fri, Nov 30, 2012 at 1:28 PM, Zbigniew Jędrzejewski-Szmek > >> wrote: > >> > >>> It'll be created by systemd during init if not present. So we _do_ a

[systemd-devel] [PATCH v3] Skip tests that depend on /etc/machine-id if it is not present

2012-11-30 Thread Ramkumar Ramachandra
The following tests fail if /etc/machine-id is not present: $ ./test-id128 random: a08ea8ed34594d4bbd953dd182ec86f9 Assertion 'sd_id128_get_machine(&id) == 0' failed at src/test/test-id128.c:41, function main(). Aborting. [1]8017 abort (core dumped) ./test-id128 $ ./test-journal

[systemd-devel] [PATCH v2] Skip tests that depend on /etc/machine-id if it is not present

2012-11-30 Thread Ramkumar Ramachandra
The following tests fail if /etc/machine-id is not present: $ ./test-id128 random: a08ea8ed34594d4bbd953dd182ec86f9 Assertion 'sd_id128_get_machine(&id) == 0' failed at src/test/test-id128.c:41, function main(). Aborting. [1]8017 abort (core dumped) ./test-id128 $ ./test-journal

Re: [systemd-devel] [PATCH 1/3] LICENSE.LGPL2.1: update license

2012-11-30 Thread Kay Sievers
On Fri, Nov 30, 2012 at 2:23 PM, Ramkumar Ramachandra wrote: > Kay Sievers wrote: >> On Thu, Nov 29, 2012 at 8:06 PM, Ramkumar Ramachandra >> wrote: >>> Update the license with the copy found on >>> http://www.gnu.org/licenses/old-licenses/lgpl-2.1.txt >> >> Applied. > > Thanks. I noticed that y

Re: [systemd-devel] [PATCH 1/3] LICENSE.LGPL2.1: update license

2012-11-30 Thread Ramkumar Ramachandra
Kay Sievers wrote: > On Thu, Nov 29, 2012 at 8:06 PM, Ramkumar Ramachandra > wrote: >> Update the license with the copy found on >> http://www.gnu.org/licenses/old-licenses/lgpl-2.1.txt > > Applied. Thanks. I noticed that you dropped the signoff on all three patches. Should I send future patches

Re: [systemd-devel] [PATCH] Skip tests that depend on /etc/machine-id if it is not present

2012-11-30 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Nov 30, 2012 at 06:47:42PM +0530, Ramkumar Ramachandra wrote: > The following tests fail if /etc/machine-id is not present: > +if (journal_file_open("one.journal", O_RDWR|O_CREAT, 0666, true, > false, NULL, NULL, NULL, &one) == -128) { > +printf("skipping test: /etc

Re: [systemd-devel] 4 failing tests

2012-11-30 Thread Ramkumar Ramachandra
Kay Sievers wrote: > On Fri, Nov 30, 2012 at 1:45 PM, Ramkumar Ramachandra > wrote: >> Where is the creation code? The systemd-machine-id-setup binary does >> _not_ create it, and my patch proposes to fix that. > > We overmount an empty file if needed. We do not want to create > anything if we do

[systemd-devel] [PATCH] Skip tests that depend on /etc/machine-id if it is not present

2012-11-30 Thread Ramkumar Ramachandra
The following tests fail if /etc/machine-id is not present: $ ./test-id128 random: a08ea8ed34594d4bbd953dd182ec86f9 Assertion 'sd_id128_get_machine(&id) == 0' failed at src/test/test-id128.c:41, function main(). Aborting. [1]8017 abort (core dumped) ./test-id128 $ ./test-journal

Re: [systemd-devel] [PATCH 3/3] man: fix some spelling mistakes

2012-11-30 Thread Kay Sievers
On Thu, Nov 29, 2012 at 8:06 PM, Ramkumar Ramachandra wrote: > Fix some minor spelling mistakes in the manpages. Applied. Thanks, Kay ___ systemd-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/syste

Re: [systemd-devel] [PATCH 2/3] DISTRO_PORTING: correct location of hostname-setup.c

2012-11-30 Thread Kay Sievers
On Thu, Nov 29, 2012 at 8:06 PM, Ramkumar Ramachandra wrote: > f33d3ec1 (move more common files to shared/ and add them to shared.la, > 2012-04-12) moved src/hostname-setup.c to src/shared/hostname-setup.c, > but did not update DISTRO_PORTING accordingly. Fix this. Applied. Thanks, Kay

Re: [systemd-devel] [PATCH 1/3] LICENSE.LGPL2.1: update license

2012-11-30 Thread Kay Sievers
On Thu, Nov 29, 2012 at 8:06 PM, Ramkumar Ramachandra wrote: > Update the license with the copy found on > http://www.gnu.org/licenses/old-licenses/lgpl-2.1.txt Applied. Thanks, Kay ___ systemd-devel mailing list [email protected] htt

Re: [systemd-devel] 4 failing tests

2012-11-30 Thread Kay Sievers
On Fri, Nov 30, 2012 at 1:45 PM, Ramkumar Ramachandra wrote: > Kay Sievers wrote: >> On Fri, Nov 30, 2012 at 1:28 PM, Zbigniew Jędrzejewski-Szmek >> wrote: >> >>> It'll be created by systemd during init if not present. So we _do_ a >>> kind of around. > > Where is the creation code? The systemd-

Re: [systemd-devel] 4 failing tests

2012-11-30 Thread Ramkumar Ramachandra
Kay Sievers wrote: > It is mandatory for systemd systems. We just require it to be around, > and do not work around it. Specifically, which package installs /etc/machine-id? Is it a build dependency for systemd? Ram ___ systemd-devel mailing list syste

Re: [systemd-devel] 4 failing tests

2012-11-30 Thread Ramkumar Ramachandra
Kay Sievers wrote: > On Fri, Nov 30, 2012 at 1:28 PM, Zbigniew Jędrzejewski-Szmek > wrote: > >> It'll be created by systemd during init if not present. So we _do_ a >> kind of around. Where is the creation code? The systemd-machine-id-setup binary does _not_ create it, and my patch proposes to f

Re: [systemd-devel] 4 failing tests

2012-11-30 Thread Kay Sievers
On Fri, Nov 30, 2012 at 1:28 PM, Zbigniew Jędrzejewski-Szmek wrote: > It'll be created by systemd during init if not present. So we _do_ a > kind of around. I haven't looked at the details of the patch, but > I think that it would be nice to support testing before the first run > with systemd: th

[systemd-devel] [PATCH] Fix some typos

2012-11-30 Thread Eelco Dolstra
--- man/udevadm.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/man/udevadm.xml b/man/udevadm.xml index 3bd7738..7791028 100644 --- a/man/udevadm.xml +++ b/man/udevadm.xml @@ -429,9 +429,9 @@ --update -Compile the hardware

Re: [systemd-devel] 4 failing tests

2012-11-30 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Nov 30, 2012 at 01:09:01PM +0100, Kay Sievers wrote: > On Fri, Nov 30, 2012 at 11:43 AM, Ramkumar Ramachandra > wrote: > > Ramkumar Ramachandra wrote: > >> $ ./test-journal > >> Assertion 'journal_file_open("test.journal", O_RDWR|O_CREAT, 0666, > >> true, true, NULL, NULL, NULL, &f) == 0'

Re: [systemd-devel] 4 failing tests

2012-11-30 Thread Kay Sievers
On Fri, Nov 30, 2012 at 11:43 AM, Ramkumar Ramachandra wrote: > Ramkumar Ramachandra wrote: >> $ ./test-journal >> Assertion 'journal_file_open("test.journal", O_RDWR|O_CREAT, 0666, >> true, true, NULL, NULL, NULL, &f) == 0' failed at >> src/journal/test-journal.c:46, function main(). Aborting. >>

Re: [systemd-devel] ExecRestart

2012-11-30 Thread Colin Guthrie
'Twas brillig, and Brandon Black at 29/11/12 04:41 did gyre and gimble: > The daemon's "fast restart" code does all of the expensive startup > operations in the new daemon first (e.g. parsing large data input), then > signals the existing daemon to shut itself down, waits for it to release > its cr

Re: [systemd-devel] 4 failing tests

2012-11-30 Thread Ramkumar Ramachandra
Ramkumar Ramachandra wrote: > $ ./test-journal > Assertion 'journal_file_open("test.journal", O_RDWR|O_CREAT, 0666, > true, true, NULL, NULL, NULL, &f) == 0' failed at > src/journal/test-journal.c:46, function main(). Aborting. > [1]8059 abort (core dumped) ./test-journal > > $ ./test-journal-

[systemd-devel] [PATCH] machine-id-setup: generate /etc/machine-id if it doesn't exist

2012-11-30 Thread Ramkumar Ramachandra
/etc/machine-id does not exist on all distributions, and DBus puts its machine-id in /var/lib/dbus/machine-id. One test in test-id128 fails if the file isn't present. Make systemd-machine-id-setup create the file if it doesn't exist, and fix a failing test in test-id128. Signed-off-by: Ramkumar

[systemd-devel] [PATCH] *.py: don't hardcode /usr/bin/python

2012-11-30 Thread Ramkumar Ramachandra
Execute python using "/usr/bin/env python" instead of hard-coding the path of the Python binary. Signed-off-by: Ramkumar Ramachandra --- Minor fix. src/analyze/systemd-analyze |2 +- src/locale/generate-kbd-model-map |2 +- test/rule-syntax-check.py |2 +- 3 files cha