On Fri, Nov 30, 2012 at 01:09:01PM +0100, Kay Sievers wrote: > On Fri, Nov 30, 2012 at 11:43 AM, Ramkumar Ramachandra > <[email protected]> wrote: > > Ramkumar Ramachandra wrote: > >> $ ./test-journal > >> Assertion 'journal_file_open("test.journal", O_RDWR|O_CREAT, 0666, > >> true, true, NULL, NULL, NULL, &f) == 0' failed at > >> src/journal/test-journal.c:46, function main(). Aborting. > >> [1] 8059 abort (core dumped) ./test-journal > >> > >> $ ./test-journal-stream > >> Assertion 'journal_file_open("one.journal", O_RDWR|O_CREAT, 0666, > >> true, false, NULL, NULL, NULL, &one) == 0' failed at > >> src/journal/test-journal-stream.c:88, function main(). Aborting. > >> [1] 8107 abort (core dumped) ./test-journal-stream > >> > >> $ ./test-journal-verify > >> Generating... > >> Assertion 'journal_file_open("test.journal", O_RDWR|O_CREAT, 0666, > >> true, !!verification_key, NULL, NULL, NULL, &f) == 0' failed at > >> src/journal/test-journal-verify.c:87, function main(). Aborting. > >> [1] 8154 abort (core dumped) ./test-journal-verify > > > > These tests fail due to the code in src/journal-file.c:167, which > > again checks for /etc/machine-id. Why do you expect this file to be > > present? > > It is mandatory for systemd systems. We just require it to be around, > and do not work around it.
It'll be created by systemd during init if not present. So we _do_ a kind of around. I haven't looked at the details of the patch, but I think that it would be nice to support testing before the first run with systemd: the tests should support missing /etc/machine-id. Zbyszek _______________________________________________ systemd-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/systemd-devel
