Re: StandardDirectoryReader.java:: applyAllDeletes, writeAllDeletes

2017-05-29 Thread Michael McCandless
If you are not using NRT readers then the applyAllDeletes/writeAllDeletes boolean values are completely unused (and should have no impact on your performance). Mike McCandless http://blog.mikemccandless.com On Sun, May 28, 2017 at 8:34 PM, Nawab Zada Asad Iqbal wrote: > After reading some more

Re: StandardDirectoryReader.java:: applyAllDeletes, writeAllDeletes

2017-05-28 Thread Nawab Zada Asad Iqbal
After reading some more code it seems if we are sure that there are no deletes in this segment/index, then setting applyAllDeletes and writeAllDeletes both to false will achieve similar to what I was getting in 4.5.0 However, after I read the comment from IndexWriter::DirectoryReader getReader(bo

Re: StandardDirectoryReader.java:: applyAllDeletes, writeAllDeletes

2017-05-28 Thread Nawab Zada Asad Iqbal
Thanks Michael and Shawn for the detailed response. I was later able to pull the full history using gitk; and found the commits behind this patch. Mike: So, in solr 4.5.0 ; some earlier developer has added code and config to set applyAllDeletes to false when we reindex all the data. At the momen

Re: StandardDirectoryReader.java:: applyAllDeletes, writeAllDeletes

2017-05-28 Thread Michael McCandless
Sorry, yes, that commit was one of many on a feature branch I used to work on LUCENE-5438, which added near-real-time index replication to Lucene. Before this change, Lucene's replication module required a commit in order to replicate, which is a heavy operation. The writeAllDeletes boolean option

Re: StandardDirectoryReader.java:: applyAllDeletes, writeAllDeletes

2017-05-28 Thread Shawn Heisey
On 5/27/2017 8:35 PM, Nawab Zada Asad Iqbal wrote: > I am looking at following change in lucene-solr which doen't mention any > JIRA. How can I know more about it? > > "1ae7291 Mike McCandless on 1/24/16 at 3:17 PM current patch" The reason that there's no Jira issue mentioned is that the commit w

StandardDirectoryReader.java:: applyAllDeletes, writeAllDeletes

2017-05-27 Thread Nawab Zada Asad Iqbal
Hi all I am looking at following change in lucene-solr which doen't mention any JIRA. How can I know more about it? "1ae7291 Mike McCandless on 1/24/16 at 3:17 PM current patch" Specifically, I am interested in what 'writeAllDeletes' does in the following method. Let me know if it is very stupi