On 5/27/2017 8:35 PM, Nawab Zada Asad Iqbal wrote: > I am looking at following change in lucene-solr which doen't mention any > JIRA. How can I know more about it? > > "1ae7291 Mike McCandless on 1/24/16 at 3:17 PM current patch"
The reason that there's no Jira issue mentioned is that the commit was first made on an entirely separate git branch -- the one for LUCENE-5438. I think I would argue that even commits on special branches should have the Jira issue in the commit text, because eventually those commits get merged back to master, where information about the source branch seems to disappear. https://issues.apache.org/jira/browse/LUCENE-5438 LUCENE-5438 added an HTTP-based replication capability that Lucene users could leverage, similar to what Solr already had. > Specifically, I am interested in what 'writeAllDeletes' does in the > following method. Let me know if it is very stupid question and I should > have done something else before emailing here. > > static DirectoryReader open(IndexWriter writer, SegmentInfos infos, > boolean applyAllDeletes, boolean writeAllDeletes) throws IOException { > > Background: We are running solr4.5 and upgrading to 6.5.1. We have > some custom code in this area, which we need to merge. I found this commit in the archive for the commits mailing list. The full commit hash is 1ae7291429bad742715344f86cfa5200229b3698. https://git1-us-west.apache.org/repos/asf?p=lucene-solr.git;a=commit;h=1ae72914 This was a change in Lucene code, Solr code wasn't touched. The author of that change, Mike McCandless, is a participant on this list. There are posts from him as recently as April 2017. Because of that, I hesitate to have you ask your question on the dev list, but if you don't get a useful reply from somebody soon, you may want to do that. I wish I could offer you some advice myself, but I'm not familiar with the low-level Lucene code. Thanks, Shawn
