Merged #5953 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5953#event-17423282967
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5952)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5952#issuecomment-2833360519
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#3107)
> you're integrating Swagger by writing **RSpec tests that double as
> documentation**
So only the one small problem then - we don't use RSpec.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstree
Merged #5955 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5955#event-17423282965
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5953)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5953#issuecomment-2833359693
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#5955)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5955#issuecomment-2833361152
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#5957)
Looks great to me - thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5957#issuecomment-2833363078
You are receiving this because you are subscribed to this
Merged #5957 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5957#event-17423282970
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #5441 as completed via #5957.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5441#event-17423283057
You are receiving this because you are subscribed to this thread.
Message ID:
_
Merged #5952 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5952#event-17423282963
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes pushed 1 commit.
7e6315a8895b45416a8234b1519b6df26e5320dc Add frozen_string_literal comments to
ruby files
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5932/files/33c0a0e830f06f9f2c50f8d71d2817d1088808fc..7e6315a8895b45416a8234b1519b6df26e5320dc
@tomhughes requested changes on this pull request.
The changes I've suggested fix the failing tests, but they also reveal a
problem as they show that the structure of the JSON returned by the two methods
is not consistent - one has a top level hash with a `osm` member pointing at
the details an
tomhughes left a comment (openstreetmap/openstreetmap-website#5966)
Do you have some reason to think it's license is different to the rest of the
repository?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5966#issuecomment-284
tomhughes left a comment (openstreetmap/openstreetmap-website#5966)
In other words GPLv2 as documented in
https://github.com/openstreetmap/openstreetmap-website/blob/master/LICENSE.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issu
tomhughes left a comment (openstreetmap/openstreetmap-website#5967)
This looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5967#issuecomment-2842884428
You are receiving this because you are subscribed to t
@tomhughes commented on this pull request.
> this._highlightLayer.clearLayers();
for (const changeset of this._changesets.values()) {
- const rect = L.rectangle(changeset.bounds,
this._getInteractiveStyle(changeset));
+ const rect = L.rectangle(changeset.bounds,
this._get
tomhughes left a comment (openstreetmap/openstreetmap-website#5963)
This looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5963#issuecomment-2842701161
You are receiving this because you are subscribed to t
tomhughes left a comment (openstreetmap/openstreetmap-website#5969)
Looks fine to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5969#issuecomment-2842721840
You are receiving this because you are subscribed to this t
@tomhughes approved this pull request.
Thanks for the work on this... I think it looks good to merge now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5915#pullrequestreview-2807998341
You are receiving this because you are s
Merged #5967 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5967#event-17477964811
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5915 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5915#event-17477964853
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5965)
Looks good to me and as you say any change to the semantics is a larger issue
that would need to be discussed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/59
Merged #5969 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5969#event-17477390676
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5963 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5963#event-17477390710
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5965 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5965#event-17477390671
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes commented on this pull request.
> this._highlightLayer.clearLayers();
for (const changeset of this._changesets.values()) {
- const rect = L.rectangle(changeset.bounds,
this._getInteractiveStyle(changeset));
+ const rect = L.rectangle(changeset.bounds,
this._get
tomhughes left a comment (openstreetmap/openstreetmap-website#5906)
Well as far as I know it doesn't if you're using sprockets so it means moving
to a whole new asset toolchain.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/590
This refactors our trace file format detection so that we only do it in one and
then adjusts that code to work around https://bugs.astron.com/view.php?id=643
which otherwise means that we fail to identify zip files on systems using
version 5.46 of the file command.
You can view, comment on, or m
tomhughes left a comment (openstreetmap/openstreetmap-website#5931)
Oh I see - the problem is you used the term "rendered" which is something we
normally use when talking about the underlying map.
The code that draws data layer objects (the orange highlight) is just a very
basic heuristic and d
tomhughes left a comment (openstreetmap/openstreetmap-website#5935)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5935#issuecomment-2810184640
You are receiving this because you are subscribed to this t
Merged #5936 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5936#event-17292905055
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5935 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5935#event-17292905056
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5936)
Looks fine to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5936#issuecomment-2810194282
You are receiving this because you are subscribed to this t
Merged #5121 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5121#event-17293034843
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #3887 as completed via #5121.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/3887#event-17293035417
You are receiving this because you are subscribed to this thread.
Message ID:
_
There doesn't seem to be anything in the new defaults that is likely to
cause us a problem.
* `to_time_preserves_timezone` should have no effect as we always work with UTC
times, and the production servers run in UTC time
* `strict_freshness` at worse could mean sending fewer 304 responses but i
tomhughes left a comment (openstreetmap/openstreetmap-website#5121)
Thanks - that looks like a much nicer solution than what I was imagining! I
think this is good to merge now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5121
Closed #5931 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5931#event-17244810736
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
tomhughes left a comment (openstreetmap/openstreetmap-website#5931)
The menu you saw when you opened this bug should have included an option for
reporting map style issues:
--
Reply to this email directly
Merged #5982 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5982#event-17521797024
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5982)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5982#issuecomment-2851386193
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#5983)
I think if this was generally true then we would have a lot more reports so
there must be something unusual about your browser - thousands of people use iD
every day without any problem after all.
--
Reply to this email direct
tomhughes left a comment (openstreetmap/openstreetmap-website#5983)
I actually use Firefox 138 on Fedora 42 myself and I just tested it and this is
what I see in the inspector for the response to the CORS preflight check:
What extensions do you have installed? Please try disabling anything that might
be interfering with requests and see if that helps.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstre
tomhughes left a comment (openstreetmap/openstreetmap-website#5983)
Which request exactly is that the response to? Because I can't see any request
with a response like that :-(
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/59
Closed #5984 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5984#event-17522504452
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
tomhughes left a comment (openstreetmap/openstreetmap-website#5984)
I have no idea what any of this has to do with POTUS or why you think it might
appear to be subversive in any case it's not really relevant as this seems like
an end user feature so is out of scope for openstreetmap.org which ex
tomhughes left a comment (openstreetmap/openstreetmap-website#2799)
I believe the problem is that if an app opens a webview on osm.org to let the
user login and authorise a token then that is considered part of the app so
needs to follow those rules.
--
Reply to this email directly or view it
tomhughes left a comment (openstreetmap/openstreetmap-website#2799)
Whatever arguments there are for this they don't come from that requirement as
people can always use a local OSM account to authenticate which would meet the
requirements surely?
--
Reply to this email directly or view it on G
tomhughes left a comment (openstreetmap/openstreetmap-website#5979)
By using `/api/versions`?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5979#issuecomment-2850058200
You are receiving this because you are subscribed to this t
Merged #5977 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5977#event-17511193890
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5977)
This looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5977#issuecomment-2849353121
You are receiving this because you are subscribed to t
tomhughes left a comment (openstreetmap/openstreetmap-website#5976)
Thanks for the changes - this looks good to me now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5976#issuecomment-2849340493
You are receiving this because yo
tomhughes left a comment (openstreetmap/openstreetmap-website#5978)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5978#issuecomment-2849341499
You are receiving this because you are subscribed to this t
Merged #5978 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5978#event-17511140103
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5976 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5976#event-17511140102
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5980)
Looks OK to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5980#issuecomment-2850836871
You are receiving this because you are subscribed to this thr
@tomhughes commented on this pull request.
>
-for (const layer of this._bboxLayers) {
- layer.updateChangesetLayerBounds(changeset);
This updating of the bounds got removed at the point where you merged
`updateChangesetLocations` into `updateChangesetsGeometry` but it's not
tomhughes left a comment (openstreetmap/openstreetmap-website#5979)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5979#issuecomment-2850880174
You are receiving this because you are subscribed to this t
Merged #5980 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5980#event-17518809729
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5979 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5979#event-17518809730
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5966)
Only if you can identify the creators of the files and get their permission.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5966#issuecomment-2844957453
You ar
Merged #5972 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5972#event-17490034896
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes commented on this pull request.
> @@ -119,14 +119,12 @@ OSM.HistoryChangesetsLayer = L.FeatureGroup.extend({
const changeset = this._changesets.get(id);
if (!changeset) return;
-let highlightRect = this._highlightLayer.getLayer(id);
-if (!state && highlightRect) {
tomhughes left a comment (openstreetmap/openstreetmap-website#5972)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5972#issuecomment-2845248220
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#5960)
I certainly don't understand the point of having the button present but
invisible so that it can only be navigated to with tab - what is supposed to be
the use case for that?
--
Reply to this email directly or view it on GitHu
Closed #5971 as completed via #5972.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5971#event-17490035243
You are receiving this because you are subscribed to this thread.
Message ID:
_
tomhughes left a comment (openstreetmap/openstreetmap-website#5983)
I'm looking at it through cloudflare as well... Obviously there could be one
cache doing something weird but it seems unlikely especially with only one
report.
--
Reply to this email directly or view it on GitHub:
https://gith
tomhughes left a comment (openstreetmap/openstreetmap-website#5987)
What's the logic behind the suitcase icon for company? Is that something that's
commonly used for this purpose?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5
tomhughes left a comment (openstreetmap/openstreetmap-website#5981)
With those clarifications I think this looks good now, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5981#issuecomment-2855425233
You are receiving this
Merged #5981 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5981#event-17541887379
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes commented on this pull request.
> @@ -23,6 +23,12 @@ def result_to_html(result)
safe_join(html)
end
+ def map_hash(params)
+return "" unless params[:lat].present? && params[:lon].present?
+
+"#map=#{params[:zoom].to_i ||
17}/#{params[:lat].to_f}/#{params[:lon].to_f
@tomhughes commented on this pull request.
> @@ -23,6 +23,12 @@ def result_to_html(result)
safe_join(html)
end
+ def map_hash(params)
+return "" unless params[:lat].present? && params[:lon].present?
+
+"#map=#{params[:zoom].to_i ||
17}/#{params[:lat].to_f}/#{params[:lon].to_f
@tomhughes commented on this pull request.
> @@ -81,7 +81,8 @@
<% if params[:oauth_return_url] %>
<%= t
".continue_authorization" %>
<% else %>
- <%= t
".start_mapping" %>
+ <%= editor_query = "?editor=#{params[:editor].to_s.split(/\W/)[0]}" if
params[:editor].present?
Same here, I co
@tomhughes commented on this pull request.
> +return "" unless params[:lat].present? && params[:lon].present?
+
+"#map=#{params[:zoom] || 17}/#{params[:lat]}/#{params[:lon]}"
I suggest just returning the target:
```suggestion
return nil unless params[:lat].present? && params[:lon].p
tomhughes left a comment (openstreetmap/openstreetmap-website#5943)
The top level boilerplate can be added with:
```ruby
json.partial! "api/root_attributes"
```
which you'll find in other json.builder views.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/
@tomhughes approved this pull request.
Thanks for all this work - this looks good to me now.
I did push a small change to tidy up the commit message and I'll merge it now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5943#pu
Merged #5943 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5943#event-17395360686
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #5646 as completed via #5943.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5646#event-17395360959
You are receiving this because you are subscribed to this thread.
Message ID:
_
Merged #5840 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5840#event-17395360665
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5840)
This has been going for a while now and the latest version looks reasonable to
me so I'm going to merge it - if anybody does think there are further
improvements possible then they can be addressed in followup PRs.
--
Reply to
@tomhughes pushed 1 commit.
4c44df5fdf01c6d4f758c997b7f402fb512af4ca Add support for JSON traces API
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5943/files/43b312166ce3e2e3db5749d5e6398d780376f82f..4c44df5fdf01c6d4f758c997b7f402fb512af4ca
You are receiving
Merged #5949 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5949#event-17409227119
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5948 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5948#event-17409227147
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5950)
Plus we don't do releases, we just deploy continually - usually multiple times
a week and sometimes multiple times a day!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-webs
Closed #5950 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5950#event-17406172425
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
tomhughes left a comment (openstreetmap/openstreetmap-website#5950)
I know @1ec5 has plans to start publicising some of the more significant
changes but it's not going to take this form.
I would dispute the claim that 99.99% of FOSS projects work like that anyway -
there are a wide variety of d
Merged #5302 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302#event-17409438001
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5302)
I think this is looking good now - thanks for all the work on it!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302#issuecomment-2830921005
You are receiving t
Closed #5947 as completed via #5951.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5947#event-17410377508
You are receiving this because you are subscribed to this thread.
Message ID:
_
Merged #5951 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5951#event-17410377240
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5951)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5951#issuecomment-2831096638
You are receiving this because you are subscribed to this t
@tomhughes pushed 5 commits.
5037ae2dde6ab2bcfa20835e9b20d2736a847893 Update to omniauth 2.1, puma 6 and
rack 3
35022c47f97be69fd2dab75f7c3dfe1c8bd8af30 Avoid trying to rewind the request
body
ca3b7fd33270ca0d5fc7999f66db47ff0f85 Pass correct headers to requests
83dae8ca11cdc23c86e9e1a9b1
tomhughes left a comment (openstreetmap/openstreetmap-website#5815)
So what's the `note_comment_id` in the versions table for?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5815#issuecomment-2807249264
You are receiving this bec
Merged #5933 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5933#event-17273307606
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5933)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5933#issuecomment-2806860845
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#5932)
The problem with that is that it will also affect any gems we use so if any of
them try to modify a constant string (for example
https://github.com/chef/ffi-libarchive/pull/90) then what is currently a
deprecation warning will
@tomhughes pushed 1 commit.
13a8386008b8d7cddf3b28a9200d4f677b700599 Add frozen_string_literal comments to
ruby files
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5932/files/03a09611f9a81a216d8aff53b048b09717eab3f3..13a8386008b8d7cddf3b28a9200d4f677b700599
tomhughes left a comment (openstreetmap/openstreetmap-website#5923)
So I did manage to reproduce the problem you're referring to and it turns out
we don't actually need that code any more as `Rack::Cors` has supported caching
properly for eight years now, by setting `Vary: Origin` which is bette
@tomhughes pushed 1 commit.
317e4807512470453db6cf66ec148a21544d0224 Drop custom CORS rack module
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5923/files/2c76e090e0c6498bee2692d0ea4a2b0cf55bdf30..317e4807512470453db6cf66ec148a21544d0224
You are receiving thi
1101 - 1200 of 2185 matches
Mail list logo
