Re: [openstreetmap/openstreetmap-website] Integrate human-readable wikidata browser plugin (PR #6127)

@1ec5 commented on this pull request. > @@ -1,10 +1,18 @@ (function () { + let abortController = null; + const languagesToRequest = [...new Set([...OSM.preferred_languages.map(l => l.toLowerCase()), "mul", "en"])]; @lucaswerkmeister [suggested](https://wikis.world/@LucasWerkmeister/1148761

Re: [openstreetmap/openstreetmap-website] Image download with user feedback (PR #6192)

@mmd-osm commented on this pull request. > +async function handleExportSuccess(fetchResponse) { + try { +const blob = await fetchResponse.response.blob(); +const filename = OSM.i18n.t("javascripts.share.filename"); +downloadBlob(blob, filename); + } catch (e

Re: [openstreetmap/openstreetmap-website] Replace custom role icon helpers with inline_svg_tag (PR #6215)

hlfan left a comment (openstreetmap/openstreetmap-website#6215) The `svg.role-icon.inactive` rule could be generalized into bootstrap-style `.fill-none`. Probably better than much custom stuff. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-

Re: [openstreetmap/openstreetmap-website] Replace custom role icon helpers with inline_svg_tag (PR #6215)

@AntonKhorev commented on this pull request. > @@ -20,3 +20,13 @@ $table-border-factor: .1; $list-group-hover-bg: rgba(var(--bs-emphasis-color-rgb), .075); $enable-negative-margins: true; + +.role-icon-administrator { + color: #f69e42; +} +.role-icon-moderator { + color: #447eff; +} +.role

Re: [openstreetmap/openstreetmap-website] Replace custom role icon helpers with inline_svg_tag (PR #6215)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6215) Here's a version with one svg where fill is altered. No inline_svg_tag transforms are required for that because you can change svg properties using css. -- Reply to this email directly or view it on GitHub: https://github.co

Re: [openstreetmap/openstreetmap-website] Replace custom role icon helpers with inline_svg_tag (PR #6215)

@AntonKhorev pushed 3 commits. 71c502f43fdebc4971b92f24a786fe3839eb93c8 Move role colors to css 022ea851507dc6abf1aa14c17013960f61d3a042 Replace role_icon_svg_tag helper with inline_svg_tag 0b409818b99ca5551b01f719b7bf5748a38278e0 Gather together i18n strings of role icons -- View it on Git

Re: [openstreetmap/openstreetmap-website] Add Shortbread-based vector tile layer (PR #6137)

pnorman left a comment (openstreetmap/openstreetmap-website#6137) I'm happy on the server side -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6137#issuecomment-3097953074 You are receiving this because you are subscribed to this

Re: [openstreetmap/openstreetmap-website] Image download with user feedback (PR #6192)

@hlfan commented on this pull request. > +async function handleExportSuccess(fetchResponse) { + try { +const blob = await fetchResponse.response.blob(); +const filename = OSM.i18n.t("javascripts.share.filename"); +downloadBlob(blob, filename); + } catch (err

Re: [openstreetmap/openstreetmap-website] Remove temporary debug code (PR #6217)

Merged #6217 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6217#event-18733657682 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Remove temporary debug code (PR #6217)

tomhughes left a comment (openstreetmap/openstreetmap-website#6217) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6217#issuecomment-3097665622 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] Image download with user feedback (PR #6192)

@mmd-osm pushed 1 commit. edbc9dae43da1d3bf94a294505c6aa571aa8f7b9 Image download with user feedback -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/7370d311b26655911f0cf09390beddb1e9f2b7a7..edbc9dae43da1d3bf94a294505c6aa571aa8f7b9 You are receiving

Re: [openstreetmap/openstreetmap-website] Remove temporary debug code (PR #6217)

@hlfan pushed 1 commit. 6050ebdf427f94a3c0acad40c2e8f8c7e17fcb02 Remove temporary debug code -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6217/files/180f5c68a0d8517d96e65fbecfd6d21f1de4abad..6050ebdf427f94a3c0acad40c2e8f8c7e17fcb02 You are receiving this bec

Re: [openstreetmap/openstreetmap-website] Use Rails's logger for logging (PR #6217)

hlfan left a comment (openstreetmap/openstreetmap-website#6217) Not quite, f4e29905263efbb2eafdedad6a5c050ba559efd8 just moved it, it has been there since API 0.5 in commit 78b440ffc1e0448f8a6d73c8821dd58634ffb475. -- Reply to this email directly or view it on GitHub: https://github.com/openstr

Re: [openstreetmap/openstreetmap-website] Use Rails's logger for logging (PR #6217)

tomhughes left a comment (openstreetmap/openstreetmap-website#6217) One was introduced in f4e29905263efbb2eafdedad6a5c050ba559efd8 and the second in 75a49786f8bcb76715cf4009ba807a844baae282. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-web

Re: [openstreetmap/openstreetmap-website] Use Rails's logger for logging (PR #6217)

tomhughes left a comment (openstreetmap/openstreetmap-website#6217) I'm not really sure that code should be there at all - it looks like temporary debug code that somebody has made permanent but putting it behind `$VERBOSE` but when I write such code I normally take it out again when I'm done.

Re: [openstreetmap/openstreetmap-website] Replace custom role icon helpers with inline_svg_tag (PR #6215)

@hlfan commented on this pull request. > @@ -20,3 +20,13 @@ $table-border-factor: .1; $list-group-hover-bg: rgba(var(--bs-emphasis-color-rgb), .075); $enable-negative-margins: true; + +.role-icon-administrator { + color: #f69e42; +} +.role-icon-moderator { + color: #447eff; +} +.role-icon-

Re: [openstreetmap/openstreetmap-website] Replace custom role icon helpers with inline_svg_tag (PR #6215)

@tomhughes commented on this pull request. > @@ -20,3 +20,13 @@ $table-border-factor: .1; $list-group-hover-bg: rgba(var(--bs-emphasis-color-rgb), .075); $enable-negative-margins: true; + +.role-icon-administrator { + color: #f69e42; +} +.role-icon-moderator { + color: #447eff; +} +.role-i

[openstreetmap/openstreetmap-website] Use Rails's logger for logging (PR #6217)

Making RuboCop happier You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6217 -- Commit Summary -- * Use Rails's logger for logging -- File Changes -- M test/controllers/api/maps_controller_test.rb (8) -- Patch

Re: [openstreetmap/openstreetmap-website] Update "Latest diaries" icons (PR #6216)

@hlfan approved this pull request. Ah yes, the bootstrap icons, where `A7.5 6.5 0 0 1 .5 8 7.5 6.5 0 1 1 8 14.5a7.5 6.5 0 0 1-2.4-.34` is for some reason written as the combination of `A9 9 0 0 0 8 15c4.418 0 8-3.134 8-7s-3.582-7-8-7-8 3.134-8 7c0 1.76.743 3.37 1.97 4.6` and `A8 8 0 0 0 8 14c3.

Re: [openstreetmap/openstreetmap-website] Replace custom role icon helpers with inline_svg_tag (PR #6215)

hlfan left a comment (openstreetmap/openstreetmap-website#6215) Does it matter that the colors you define (wherever) are not the colors that end up on the screen due to the resulting lower opacity? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreet

Re: [openstreetmap/openstreetmap-website] Replace custom role icon helpers with inline_svg_tag (PR #6215)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6215) I remove `SvgFillOverrideTransform` in another pull request. It doesn't matter much how unfilled role icons look because only admins are going to see them. -- Reply to this email directly or view it on GitHub: https://github

Re: [openstreetmap/openstreetmap-website] Replace custom role icon helpers with inline_svg_tag (PR #6215)

hlfan left a comment (openstreetmap/openstreetmap-website#6215) Given your preference for fills and strokes lining up on the pixel grid, as you've stated in https://github.com/openstreetmap/openstreetmap-website/pull/5866#issuecomment-2764695781, the stroke width of 1.5 for blank role icons tha

[openstreetmap/openstreetmap-website] Update "Latest diaries" icons (PR #6216)

Before: After: You can view,

Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)

petr-hajek left a comment (openstreetmap/openstreetmap-website#4042) @tomhughes PM sent from https://www.openstreetmap.org/user/bananaboy on OSM - in case you want to use a different means of communication, please let me know there -- Reply to this email directly or view it on GitHub: https://

Re: [openstreetmap/openstreetmap-website] use JOSM/tag2link to linkify tag values (PR #6197)

@k-yle pushed 1 commit. 981d9750bab9f9dd548103d3ab0f783cca68adf0 use JOSM/tag2link to linkify tag values -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6197/files/34fa250b24be7655e7be6f2c2acc2c3cf1063541..981d9750bab9f9dd548103d3ab0f783cca68adf0 You are recei

Re: [openstreetmap/openstreetmap-website] use JOSM/tag2link to linkify tag values (PR #6197)

@k-yle pushed 1 commit. 34fa250b24be7655e7be6f2c2acc2c3cf1063541 use JOSM/tag2link to linkify tag values -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6197/files/55f68d5a48b35ac68966c36d12efb96a7c97cf7d..34fa250b24be7655e7be6f2c2acc2c3cf1063541 You are recei

Re: [openstreetmap/openstreetmap-website] use JOSM/tag2link to linkify tag values (PR #6197)

@k-yle pushed 1 commit. 55f68d5a48b35ac68966c36d12efb96a7c97cf7d use JOSM/tag2link to linkify tag values -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6197/files/bd1f6aecf812046ae653ffc74b8b613b4cf4079c..55f68d5a48b35ac68966c36d12efb96a7c97cf7d You are recei

[openstreetmap/openstreetmap-website] Replace custom role icon helpers with inline_svg_tag (PR #6215)

I'm doing this also to check where it's best to store color definitions, see https://github.com/openstreetmap/openstreetmap-website/pull/5854#discussion_r2216313135. `parameters.scss` seems like a possible place because we already have some colors in it. You can view, comment on, or merge this

Re: [openstreetmap/openstreetmap-website] use JOSM/tag2link to linkify tag values (PR #6197)

@k-yle commented on this pull request. > +TAG2LINK = lambda { + # the JSON data is an array with duplicate entries, which is not efficient for lookups. + # So, convert it to a hash and only keep the item with the best rank. + array = JSON.parse(Rails.root.join("node_modules/tag2link/index.js

Re: [openstreetmap/openstreetmap-website] Image download with user feedback (PR #6192)

mmd-osm left a comment (openstreetmap/openstreetmap-website#6192) I think I need a DOMParser for this task. Something like: ```javascript let parser = new DOMParser(); let doc = parser.parseFromString(detailMessage, 'text/html'); detailMessage = doc.body ? doc.body.textContent.trim() : "(unknown

Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)

petr-hajek left a comment (openstreetmap/openstreetmap-website#4042) > Thanks @petr-hajek I had in fact already registered a key there I had just > forgotten about it ;-) > > I think this is good to merge now - what do you want to do about a key for us > to use in production? Am I OK just to re