hlfan left a comment (openstreetmap/openstreetmap-website#6215)
Given your preference for fills and strokes lining up on the pixel grid, as
you've stated in
https://github.com/openstreetmap/openstreetmap-website/pull/5866#issuecomment-2764695781,
the stroke width of 1.5 for blank role icons that you introduced in #4771
seems like something to take a closer look at:
| stroke width 1.5px | stroke width 2px |
|-|-|
| <img width="160" height="160" alt="image"
src="https://github.com/user-attachments/assets/442f1a74-df3e-46bb-ad60-1bb50520e822";
/> | <img width="160" height="160" alt="image"
src="https://github.com/user-attachments/assets/c41e82c4-5229-4d9f-9b9b-7acc8ccc6fc6";
/> |
You may notice the icon is offset on the x-axis by a subpixel, which is why the
pixels are not quite symmetrical. Still, with a 2px stroke, the main horizontal
bar is fully opaque, the 1.5px bar isn't.
I suggest reverting the stroke-width change from #4771, then the only other
change needed can be overwritten by the `SvgFillOverrideTransform` from #5884.
Then there's no need the store essentially the same icon twice.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6215#issuecomment-3096703813
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6215/c3096703...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
