Re: [openstreetmap/openstreetmap-website] Refactor element version navigation tests (PR #6129)

@tomhughes commented on this pull request. > -relation = create(:relation) -create(:relation_member, :relation => relation, :member => member) -sidebar_browse_check :node_path, member.id, "elements/show" -assert_select "a[href='#{relation_path relation}']", :count => 1 - end - -

Re: [openstreetmap/openstreetmap-website] Integrate human-readable wikidata browser plugin (PR #6127)

@hlfan pushed 1 commit. f73f2315b6633fddea8edcb9659bb000b28c1751 Add human-readable wikidata explainations -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6127/files/4bbd8ce05d4c94992e0b996617d2b259b5ded96c..f73f2315b6633fddea8edcb9659bb000b28c1751 You are rec

Re: [openstreetmap/openstreetmap-website] Integrate human-readable wikidata browser plugin (PR #6127)

@hlfan pushed 1 commit. 4bbd8ce05d4c94992e0b996617d2b259b5ded96c Exclude wikidata explainers from extreme wrapping -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6127/files/7fb08eae16c3c08d9669c18a5211905f2ff30d4a..4bbd8ce05d4c94992e0b996617d2b259b5ded96c You

Re: [openstreetmap/openstreetmap-website] Refactor element version navigation tests (PR #6129)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6129) The tests are similar for different types and likely could be refactored, it just wasn't a priority. "over 300 lines" is short when compared to other test files. -- Reply to this email directly or view it on GitHub: https://

Re: [openstreetmap/openstreetmap-website] Rework element versions navigation (PR #6120)

@AntonKhorev pushed 10 commits. 9c972c2f16d60f67142bf73ac1eb742f5aafd99d Show all element version links below breadcrumbs da068d0084520135b868ff4a890d6398e1b9dc2d Prepare to split element version pagination into multiple lists 73127535694b251d5cd53ab5ced94611bcc12bca Split long version lists

[openstreetmap/openstreetmap-website] Element version navigation steps (PR #6134)

Next improvement after #6120, in case there's a lot of skipped versions. Changes version lists like [1, ..., 234, 235, 236, 237] to [1, ..., 50, ..., 100, ..., 150, ..., 200, 234, 235, 236, 237]. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/

Re: [openstreetmap/openstreetmap-website] Fix new rubocop warnings (d6c511b)

Danger doesn't seem to like that: https://github.com/openstreetmap/openstreetmap-website/pull/6127#issuecomment-3001407276 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/commit/d6c511ba68f0d7ad53b7d53d5c0de8c3b150cde9#r160737470 You ar

Re: [openstreetmap/openstreetmap-website] `oauth_return_url` gets lost during registration (Issue #6130)

tomhughes left a comment (openstreetmap/openstreetmap-website#6130) I get further in Chrome which isn't surprising as Chrome and Firefox are known to behave differently when it comes to CORS and redirects. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/op

Re: [openstreetmap/openstreetmap-website] Rework element versions navigation (PR #6120)

@AntonKhorev pushed 28 commits. 2ea42f7a32d5de958ae2f8c8cbdcc40361639930 Remove checks for absence of links to current element versions 7a4c5911db7c876ed08594b8bda0266f4b6903ea Rename element current version system test file 6aa70747979c68e6b8196836f88912bc7d85 Move node ui tests to syste

Re: [openstreetmap/openstreetmap-website] Element version navigation steps (PR #6134)

github-actions[bot] left a comment (openstreetmap/openstreetmap-website#6134) 1 Warning :warning: Number of updated lines of code is too large to be in one PR. Perhaps it should be separated into two or more? Gener

Re: [openstreetmap/openstreetmap-website] Rework element versions navigation (PR #6120)

@AntonKhorev pushed 4 commits. e9ad159d41cb247269dab0e107b83201b215bb02 Limit number of items in version lists 521e042dfec6bd0c128e90faf3af5b84dc003183 Scroll to active version in navigation list on load 38fa7dad4d1d314c2dbd911889ffe54b7013112f Scroll to active version on click in breadcrumbs

Re: [openstreetmap/openstreetmap-website] `oauth_return_url` gets lost during registration (Issue #6130)

tomhughes left a comment (openstreetmap/openstreetmap-website#6130) Do you have any idea when it changed? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6130#issuecomment-3001090968 You are receiving this because you are subscr

Re: [openstreetmap/openstreetmap-website] Bump @types/leaflet from 1.9.18 to 1.9.19 (PR #6132)

Merged #6132 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6132#event-18319947791 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

[openstreetmap/openstreetmap-website] Add banner for State of the Map 2025 (PR #6133)

Also removes the expired banners for sotm 2024, sotm-EU 2024 and the fundraiser in 2023. Looks like this on the website (dark/light mode): Re: [openstreetmap/openstreetmap-website] `oauth_return_url` gets lost during registration (Issue #6130)

2025-06-25 Thread Tobias via rails-dev

tordans left a comment (openstreetmap/openstreetmap-website#6130) Another part that is weird is, that in some tests I have a different return URL after using the confirmation link: Instead of getting the welcome page, I get directed to the map (without flash message and without being logged in).

Re: [openstreetmap/openstreetmap-website] `oauth_return_url` gets lost during registration (Issue #6130)

2025-06-25 Thread Tobias via rails-dev

tordans left a comment (openstreetmap/openstreetmap-website#6130) > Do you have any idea when it changed? Unfortunately not. I know that it worked when we had the old design because that is when we documented the flow in a PDF. I looked at the history a bit but nothing stood out to me. > I thi