Next improvement after #6120, in case there's a lot of skipped versions.

Changes version lists like [1, ..., 234, 235, 236, 237] to [1, ..., 50, ..., 
100, ..., 150, ..., 200, 234, 235, 236, 237].

You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/6134

-- Commit Summary --

  * Load current element in old element controllers
  * Move element and history links to breadcrumbs
  * Add version to breadcrumbs on old element pages
  * Show all element version links below breadcrumbs
  * Prepare to split element version pagination into multiple lists
  * Split long version lists into 3 parts, with middle list scrollable
  * Remove border rounding/duplication between adjacent version lists
  * Reserve horizontal space for focus outlines in middle version list
  * Extend starting/ending version lists containing active items
  * Limit number of items in version lists
  * Scroll to active version in navigation list on load
  * Scroll to active version on click in breadcrumbs
  * Add shadows to floating start/end version lists
  * Add links to versions with a fixed step
  * Fill small version gaps

-- File Changes --

    M app/assets/javascripts/index/element.js (58)
    M app/controllers/old_nodes_controller.rb (3)
    M app/controllers/old_relations_controller.rb (3)
    M app/controllers/old_ways_controller.rb (3)
    A app/helpers/numbered_pagination_helper.rb (85)
    M app/views/elements/show.html.erb (43)
    M app/views/old_elements/_actions.html.erb (42)
    M app/views/old_elements/index.html.erb (39)
    M config/locales/en.yml (10)
    A test/helpers/numbered_pagination_helper_test.rb (414)
    M test/system/element_current_version_test.rb (60)
    M test/system/element_history_test.rb (104)
    M test/system/element_old_version_test.rb (106)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/6134.patch
https://github.com/openstreetmap/openstreetmap-website/pull/6134.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6134
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to