github-actions[bot] left a comment (openstreetmap/openstreetmap-website#6129)
1 Warning
:warning:
Number of updated lines of code is too large to
be in one PR. Perhaps it should be separated into two or more?
Gener
Part 2 of #6120.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6129
-- Commit Summary --
* Remove checks for absence of links to current element versions
* Rename element current version system test file
* Move
Part 1 of #6120.
Creates `element.js` and moves `OSM.Browse` and `OSM.OldBrowse` there.
Everything in `element.js` is wrapped in iife which is currently not required,
but #6120 later adds functions there; this is to avoid reindenting the code
later.
You can view, comment on, or merge this pull
@AntonKhorev pushed 4 commits.
7018c9ba1d5e0de37d34d960ce0ad6e71f7d1820 Remove I18n.t references from user
company system test
f8590b0b21e2a0cf94ad912c31bd51b6f7f96116 Remove Bootstrap icon class checks
from profile tests
3a2e5d6d414c3d19bfeac72d6f9f8da8884bcf30 Test user company record when
Closed #1115 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/1115#event-18283058074
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
AntonKhorev left a comment (openstreetmap/openstreetmap-website#1115)
Language select added in #5201 and #6119, although not Wikimedia one.
Some languages may need their names tuned, see
https://github.com/openstreetmap/openstreetmap-website/issues/1115#issuecomment-609461120.
--
Reply to this
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6119)
> The system test framework just doesn't seem to be able to reliably wait for
> transitions to complete before checking assertions :-(
Not in this case. It loads the page which should have the flash alert
rendereded on rails
github-actions[bot] left a comment (openstreetmap/openstreetmap-website#6120)
1 Warning
:warning:
Number of updated lines of code is too large to
be in one PR. Perhaps it should be separated into two or more?
Gener
@AntonKhorev pushed 31 commits.
3ba2277ab461ec9e53db38012b3dca20638630ed Move Browse and OldBrowse to their
own file
fa25b9d658ac2335a032cca2a8f5e21e824e3a16 Rename Browse javascript controllers
to Element
0814fd0e9b8fa3262a49ef050b2c2c61de8dd6c0 Implement MappedElement as extension
of Eleme
tomhughes left a comment (openstreetmap/openstreetmap-website#6091)
To the repo, yes. Deployment to the live site was always manual but typically
happens multiple times a week - it just happens that this time there was no
deployment for a week or so because I was busy.
--
Reply to this email d
maro-21 left a comment (openstreetmap/openstreetmap-website#6091)
> Well [www.openstreetmap.org](http://www.openstreetmap.org) doesn't just track
> master - it is manually updated by me from time to time.
I see.
Has that changed? I remember that it used to be that the Translatewiki
translation
@hlfan pushed 1 commit.
5089344ab6e3bcf59995623af13403b195af2d7d Invert icons in dark mode with common
class
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6052/files/d80704a265f26ba08ac341132ba58a3e549c1d3e..5089344ab6e3bcf59995623af13403b195af2d7d
You are r
tomhughes left a comment (openstreetmap/openstreetmap-website#6091)
Well www.openstreetmap.org doesn't just track master - it is manually updated
by me from time to time.
I did a deployment a few hours ago though so it should be live now.
--
Reply to this email directly or view it on GitHub:
h
@hlfan approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6124#pullrequestreview-2951615946
You are receiving this because you are subscribed to this thread.
Message ID:
__
Klopklopi left a comment (openstreetmap/openstreetmap-website#6124)
Done with the removal of the merge commit :D
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6124#issuecomment-2998028975
You are receiving this because you are s
tomhughes left a comment (openstreetmap/openstreetmap-website#6124)
Well on `origin/master` then... I was assuming he had created a branch rather
than working on master but hadn't actually checked.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreet
Klopklopi left a comment (openstreetmap/openstreetmap-website#6124)
Why would he rebase on master, he's already on master on his source
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6124#issuecomment-2997998223
You are receiving
Closed #6103.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6103#event-18277387755
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
mmd-osm left a comment (openstreetmap/openstreetmap-website#6127)
According to https://www.mediawiki.org/wiki/Wikibase/API/en the endpoint
supports multiple ids in one request, separated by a pipe character. Since we
anyway know all ids upfront, we could do with a single page update (=less
flic
tomhughes left a comment (openstreetmap/openstreetmap-website#6124)
Now you've managed to add a merge commit... Just do `git rebase -i master` and
then change the second commit from `pick` to `fold` and save and it should
squash the commits together and get rid of the merge. You'll need to `push
@Koreller pushed 1 commit.
5c9584e84b3f4a14e5f4f512845d21f77902ee8c Merge branch 'openstreetmap:master'
into master
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6124/files/1abd5cc73f70c40594927b7a56be7c5e5d111c42..5c9584e84b3f4a14e5f4f512845d21f77902ee8c
Yo
github-actions[bot] left a comment (openstreetmap/openstreetmap-website#6124)
1 Warning
:warning:
Merge commits are found in PR. Please rebase to
get rid of the merge commits in this PR, see CONTRIBUTING.md.
Genera
Merged #6126 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6126#event-18277107992
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
hlfan left a comment (openstreetmap/openstreetmap-website#6091)
You can see which instance is deployed from which commit at
https://git.openstreetmap.org/rails.git/shortlog.
Also particularly helpful to see if a translatewiki update is already mirrored
onto the osm git, which afaict needs to be
@hlfan pushed 1 commit.
2913b5b88a97394a299f6f46a5af2592fb7dcf59 Move more icons to partials
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5938/files/36755c38b16576573101f33469b48d98b1a5994b..2913b5b88a97394a299f6f46a5af2592fb7dcf59
You are receiving this bec
tomhughes left a comment (openstreetmap/openstreetmap-website#6091)
Specifically https://git.openstreetmap.org/rails.git/shortlog/refs/tags/live is
the deployed version.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6091#issu
tomhughes left a comment (openstreetmap/openstreetmap-website#6124)
Please squash the fixup commit into the first one and then we can get this
merged.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6124#issuecomment-2997100110
Y
maro-21 left a comment (openstreetmap/openstreetmap-website#6091)
> That's because the production site hasn't been deployed since that update.
What does it mean?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6091#issuecomment
Merged #6125 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6125#event-18277107986
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
hlfan left a comment (openstreetmap/openstreetmap-website#6127)
> without any input or involvement from me, which I welcome
If you want to count https://c.osm.org/t/131530/55 as input you may.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-w
@hlfan pushed 3 commits.
0d28a301d857ae716db82b2784e3a338db128267 Move diary icons to partials
38d3456e6293e0a869e8ce05abf1a6979b96846e Move social link icons to partials
429c30cbcecd844a2d9dd937cc404f0a183bc71a Move more icons to partials
--
View it on GitHub:
https://github.com/openstreetma
@hlfan pushed 7 commits.
495ea1769d0e5a776269dbcbb10bf83105501a85 Make Rails handle SVG partials
4fe47323c3be7bf913ad319be676bb904b4975df Move search icons to partials
a51a1bcbfd228b04a0c99b20b31be9b3bb779ddf Move about icons to partials
a265238c9b241047ce354ca1e51f02ae45810cf1 Move welcome ic
ZeLonewolf left a comment (openstreetmap/openstreetmap-website#6127)
Thanks for mentioning me. To be clear, @hlfan has taken on this PR without any
input or involvement from me, which I welcome. I made those plugins CC0 so that
someone motivated could work on integrating this functionality into
Merged #6119 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6119#event-18277108055
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
1ec5 left a comment (openstreetmap/openstreetmap-website#6127)
> Copy and pasting certainly isn't the way we want to be interacting with an
> upstream repository...
If this becomes a built-in feature, I assume it would obviate the Chrome and
Firefox plugins, right @ZeLonewolf? So probably no ne
hlfan left a comment (openstreetmap/openstreetmap-website#6127)
> did you use the chrome or firefox version? Why are there different versions?
CSP workaround for chrome that uses a service worker, rest of the files are
identical. But both variations make direct stylings from js, I rewrote that t
tomhughes left a comment (openstreetmap/openstreetmap-website#6103)
Superseded by #6119.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6103#issuecomment-2997153878
You are receiving this because you are subscribed to this thread
tomhughes left a comment (openstreetmap/openstreetmap-website#6127)
I don't understand how this relates to the code in that repository? Have you
just copy and pasted it? Only it doesn't seem to match either file there as far
as I can see but I also don't see how it refers to it... If you have co
tomhughes left a comment (openstreetmap/openstreetmap-website#6125)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6125#issuecomment-2997028940
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#6126)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6126#issuecomment-2997018694
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#6119)
Passes for me locally though, but then before I merged I did a run and got two
system failures then ran again and it passed. The system test framework just
doesn't seem to be able to reliably wait for transitions to complete bef
### Description
See original plugin
[announcement](https://community.openstreetmap.org/t/announcing-human-readable-wikidata-browser-plugins-for-openstreetmap-org/108180/9)
and [codebase](https://github.com/ZeLonewolf/osm-wikidata-greasemonkey) from
@ZeLonewolf.
Updates the CSP and sets the reque
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6119)
They are reliably failing at `ReportDiaryEntryTest#test_missing_report_params`
after a number of reruns.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6119#i
@AntonKhorev pushed 14 commits.
9002c00df33f221fa434f718ceb96956bf54154c Test diary only inside
4a697d4247224d68c69751e4827f265dfdad8854 Test OAuth2 application forms only
inside page content
b989922b2be84a27fa62822cb7bbe9c25cbda8cd Allow to skip preferred editor update
in basic preferences
If you're reporting something and you managed to submit the form without
filling out the required fields[^1], there's a message "Please provide
the required details". The problem is that it's styled as a *success*
message, as if the report was created, while actually it wasn't.
Before:
![image]
tomhughes left a comment (openstreetmap/openstreetmap-website#6119)
They'll probably pass now if rerun - the system tests just aren't reliable and
as we add more of them thing just get worse.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-we
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6119)
Tests were passing when I marked this as ready for review
https://github.com/openstreetmap/openstreetmap-website/actions/runs/15779219028
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/o
If the user somehow manages to open `/reports/new` page without `reportable_id`
and `reportable_type` parameters, send a bad request error instead of
redirection.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6125
-
@AntonKhorev pushed 9 commits.
9312f2ae6b5c5422f9733b9f94087460e31c08e3 Test if language selector changes the
language
50d03fe9bd13d650e85f9038fbdece068f112c85 Change language instead of opening
preferences when logged in
1db1a9a73b36525c9e9a381f3176ac00a4b6f45c Put language select button nex
@AntonKhorev pushed 14 commits.
57bc642952328bcdda56ffebea8f27a6a02aeadd Test diary only inside
02e46b96caec4be2a93dbf05679f450877b0692d Test OAuth2 application forms only
inside page content
d7d49b3d0b20647572f2e74713f3f23b664b391c Allow to skip preferred editor update
in basic preferences
@Koreller pushed 1 commit.
1abd5cc73f70c40594927b7a56be7c5e5d111c42 clean markup and change color to
#212529 of hdyc.svg and hot.svg
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6124/files/a8b87c6e2f85fcfd2d2f5bbd12e1fcaaff41122a..1abd5cc73f70c40594927b7a56
tomhughes left a comment (openstreetmap/openstreetmap-website#6091)
That's because the production site hasn't been deployed since that update.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6091#issuecomment-2994509483
You are
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6119)
> Just one thing... I think the commit message on
> [dc53dc6](https://github.com/openstreetmap/openstreetmap-website/commit/dc53dc65ea5434e98b23d668334d6d4cacd0e9a1)
> is wrong? I'm guessing you meant to say `preferred_editor`
53 matches
Mail list logo
