If you're reporting something and you managed to submit the form without 
filling out the required fields[^1], there's a message "Please provide 
the required details". The problem is that it's styled as a *success* 
message, as if the report was created, while actually it wasn't.

Before:
![image](https://github.com/user-attachments/assets/ef8b3a30-d223-455a-bc4d-305f8eff4d15)

After:
![image](https://github.com/user-attachments/assets/5ae667af-8606-4a11-8e9c-944791d90f64)

[^1]: This shouldn't normally happen, you'll get a javascript error, as 
long as `required` html attributes are there.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/6126

-- Commit Summary --

  * Change incomplete report flash style from success to warning

-- File Changes --

    M app/controllers/reports_controller.rb (2)
    M test/controllers/reports_controller_test.rb (2)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/6126.patch
https://github.com/openstreetmap/openstreetmap-website/pull/6126.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6126
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to