Fortunately, Nominatim does expose `border_type` in the `extratags` field of
the response, and both Overpass queries (for nearby and enclosing features)
include all the element’s tags.
Unfortunately, `border_type=*` values are unlocalized and un-namespaced. We’d
only be able to pretty-print the
Bumps
[leaflet.locatecontrol](https://github.com/domoritz/leaflet-locatecontrol) from
0.82.0 to 0.83.0.
Commits
The `border_type` tag is in [pretty wide
use](https://taginfo.openstreetmap.org/keys/border_type#overview) (45,000
relations, wide geographic coverage). It seems like it would be pretty
sensible to just use the border_type value as the preferred label, and then
fall back to `place=*` or a gene
For Overpass queries, there’s currently a special case that pulls in a
dedicated string based on the `admin_level=*` if it’s present. Maybe instead we
could use the generic “Administrative Boundary” label, using the normal code
path, but add a suffix like “(Level 3)”?
https://github.com/openstr
Even the numbering in admin_level is better than no information at all, as it
at least gives a ballpark for comparing admin boundaries between each other.
Remember that osm.org is useful for mapper feedback first and foremost: Plenty
of places have admin boundaries with the exact same name that
Well the fundamental problem is that the numeric admin_level tagging scheme is,
and always has been, totally insane and just doesn't work in the real world.
There isn't much we as web site developers can do about that though.
Probably we should ignore admin_level and just label them all as admin
@tomhughes commented on this pull request.
> @@ -35,11 +35,13 @@ OSM.NewNote = function (map) {
OSM.router.route("/note/new");
});
- function createNote(marker, form, url) {
-var location = marker.getLatLng().wrap();
+ function createNote(form, url) {
+if (!newNoteMarker) ret
### Problem
As discussed in [this forum
thread](https://community.openstreetmap.org/t/admin-level-boundary-naming-on-osm-org-and-translation/123358/19)
the current naming scheme for boundaries is a peculiar mishmash of terminology
from different English speaking countries that actually applies
The MutationObserver thought came from my tinkering with the site locally
wanting to reduce the reloads, forgetting that a toggle if added would already
have onchange events.
> So maybe you don't want one global watcher.
Yeah, I kinda missed that... Still, having a similar style on such similar
@AntonKhorev pushed 1 commit.
c8a4eec318683f1fd74bd7830fb3c37e281f272b Use resourceful route for user status
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5437/files/0764432abf0b9d534b479efefa1a467da574cd19..c8a4eec318683f1fd74bd7830fb3c37e281f272b
You are re
@hlfan commented on this pull request.
> @@ -31,6 +31,9 @@ L.OSM.layers = function (options) {
var miniMap = L.map(mapContainer[0], { attributionControl: false,
zoomControl: false, keyboard: false })
.addLayer(new layer.constructor(layer.options));
+if (layer.optio
@tomhughes commented on this pull request.
> @@ -31,6 +31,9 @@ L.OSM.layers = function (options) {
var miniMap = L.map(mapContainer[0], { attributionControl: false,
zoomControl: false, keyboard: false })
.addLayer(new layer.constructor(layer.options));
+if (layer.o
@hlfan commented on this pull request.
> @@ -31,6 +31,9 @@ L.OSM.layers = function (options) {
var miniMap = L.map(mapContainer[0], { attributionControl: false,
zoomControl: false, keyboard: false })
.addLayer(new layer.constructor(layer.options));
+if (layer.optio
Using the `edit` action as the revoke all view is a bit weird but I guess if we
ever want to more general edit we can change the title of that page and the
link to it and then just have revoke as one thing you can do from the edit page.
Other than that this looks good to me, thanks.
--
Reply t
Merged #5440 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5440#event-15784250651
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes requested changes on this pull request.
As it stands this only works correctly for the transport layer that has a dark
variant - for all other layers it disables the filtering when in dark mode.
> @@ -31,6 +31,9 @@ L.OSM.layers = function (options) {
var miniMap = L.map(mapCo
@hlfan Are you reporting a bug here or do you want to discuss the details of
how Bootstrap's `$color-mode-type` setting works?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5329#issuecomment-2565379267
You are receiving this b
Or put anything, maybe the entire sentence in `doesnt`. Then it probably should
be renamed to something like `off_the_map_emphasis`.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5432#issuecomment-2565367882
You are receiving
So why have flags in the document at all if you can store the theme entirely by
which stylesheet you load? /s
I haven't seen any other major website load a different CSS file just because
the user changed their color theme preferences.
Are two separate files really necessary also given the comm
Closed #5445.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5445#event-15783685948
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
Superseded by #5447.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5445#issuecomment-2565341490
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails
Also the conditions under which watching `prefers-color-scheme` are different
for this PR and
https://github.com/openstreetmap/openstreetmap-website/pull/5426. Here you need
to watch if the website theme is auto, in
https://github.com/openstreetmap/openstreetmap-website/pull/5426 you need to
w
Why MutationObservers?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5402#issuecomment-2565317228
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
> You don't need to change the theme of the page
I did that for testing, but since listening increased the complexity
unnecessarily, I left that for a second pass.
But suppose the site needs a theme watcher anyway because the cal-heatmap
doesn't want to let CSS do the color mixing theme-agnosti
> Any manual theme change
What do you mean by *manual theme change*?
There are two versions of stylesheets, one that follows `prefers-color-scheme`
and one that doesn't.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5329#iss
> Any other change to the theme of the page without reloading will break most
> of the CSS theming anyway since the stylesheets were split in #5362 by the
> way.
You don't need to change the theme of the page, neither here, nor in
https://github.com/openstreetmap/openstreetmap-website/pull/5426
Keeping `edit` is not without its problems.
Open *My Settings* page. Your location is going to be `/account/edit`. Make an
invalid edit, for example, enter a password and leave *Confirm Password* blank.
Click *Save Changes*. You'll see the form loaded again with errors highlighted.
But look at
`save_new_user` was called from two different places when if was first
introduced. The other was I think save after terms page.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5446#issuecomment-2565225822
You are receiving this be
Any manual theme change without a reload after
`$("html")[0].toggleAttribute("data-bs-theme")` bricks the themes. This
probably has to do with the split distribution of the stylesheets.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/
29 matches
Mail list logo
