Re: [Rd] [PATCH] Fix missing break

2017-07-22 Thread Martin Maechler
> Steve Grubb > on Fri, 21 Jul 2017 13:53:12 -0400 writes: > Hello Martin, > On Friday, July 21, 2017 4:21:21 AM EDT Martin Maechler wrote: >> I have now created an account for you. > Thanks. Is that the preferred method of transferring these patches? in such a case,

Re: [Rd] [PATCH] Fix missing break

2017-07-21 Thread Steve Grubb
Hello Martin, On Friday, July 21, 2017 4:21:21 AM EDT Martin Maechler wrote: > I have now created an account for you. Thanks. Is that the preferred method of transferring these patches? > >> In examples like the one below, if you have R code that shows symptoms, > >> it would really help in the

Re: [Rd] [PATCH] Fix missing break

2017-07-21 Thread Martin Maechler
> Martin Morgan > on Fri, 21 Jul 2017 03:43:48 -0400 writes: > On 07/20/2017 05:02 PM, Steve Grubb wrote: >> Hello, >> >> There appears to be a break missing in the switch/case for the LISTSXP case. >> If this is supposed to fall through, I'd suggest a comment so

Re: [Rd] [PATCH] Fix missing break

2017-07-21 Thread Martin Maechler
> Steve Grubb > on Thu, 20 Jul 2017 22:20:33 -0400 writes: > On Thursday, July 20, 2017 7:41:00 PM EDT Duncan Murdoch wrote: >> Thanks for posting this series of patches. Unfortunately, there's a >> good chance they'll get lost in all the traffic on R-devel. If you >

Re: [Rd] [PATCH] Fix missing break

2017-07-21 Thread Martin Morgan
On 07/20/2017 05:02 PM, Steve Grubb wrote: Hello, There appears to be a break missing in the switch/case for the LISTSXP case. If this is supposed to fall through, I'd suggest a comment so that others know its by design. Signed-off-by: Steve Grubb An example is $ R --vanilla -e "pl = pairli

Re: [Rd] [PATCH] Fix missing break

2017-07-20 Thread Steve Grubb
On Thursday, July 20, 2017 7:41:00 PM EDT Duncan Murdoch wrote: > Thanks for posting this series of patches. Unfortunately, there's a > good chance they'll get lost in all the traffic on R-devel. If you > don't hear that they've been fixed in the next couple of weeks, could > you post them to bug

Re: [Rd] [PATCH] Fix missing break

2017-07-20 Thread Duncan Murdoch
Thanks for posting this series of patches. Unfortunately, there's a good chance they'll get lost in all the traffic on R-devel. If you don't hear that they've been fixed in the next couple of weeks, could you post them to bugs.r-project.org, and post future patches there as well? In examples

[Rd] [PATCH] Fix missing break

2017-07-20 Thread Steve Grubb
Hello, There appears to be a break missing in the switch/case for the LISTSXP case. If this is supposed to fall through, I'd suggest a comment so that others know its by design. Signed-off-by: Steve Grubb Index: src/main/builtin.c