On 07/20/2017 05:02 PM, Steve Grubb wrote:
Hello,

There appears to be a break missing in the switch/case for the LISTSXP case.
If this is supposed to fall through, I'd suggest a comment so that others
know its by design.

Signed-off-by: Steve Grubb <sgr...@redhat.com>

An example is

$ R --vanilla -e "pl = pairlist(1, 2); length(pl) = 1; pl"
> pl = pairlist(1, 2); length(pl) = 1; pl
Error in length(pl) = 1 :
  SET_VECTOR_ELT() can only be applied to a 'list', not a 'pairlist'
Execution halted

fixed in r72936 (R-devel) / 72937 (R-3-4-branch).

Martin Morgan


Index: src/main/builtin.c
===================================================================
--- src/main/builtin.c  (revision 72935)
+++ src/main/builtin.c  (working copy)
@@ -888,6 +888,7 @@
            SETCAR(t, CAR(x));
            SET_TAG(t, TAG(x));
        }
+       break;
      case VECSXP:
        for (i = 0; i < len; i++)
            if (i < lenx) {

______________________________________________
R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel



This email message may contain legally privileged and/or...{{dropped:2}}

______________________________________________
R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel

Reply via email to