Re: [Rd] R CMD check issue

2019-08-28 Thread Hugh Parsonage
The warning is that the vignette failed to be rebuilt due to an error in its code. The error log was truncated. Of course for practical purposes errors and warnings both constitute check failures On Thu, 29 Aug 2019 at 1:56 am, Therneau, Terry M., Ph.D. via R-devel < r-devel@r-project.org> wrote:

Re: [Rd] Conventions: Use of globals and main functions

2019-08-28 Thread Cyclic Group Z_1 via R-devel
I meant that using a script both as a script and a library (sourcing into other files to serve as a package) is bad practice. I don't think having any functions in a script is necessarily bad practice. Best, CG __ R-devel@r-project.org mailing list ht

Re: [Rd] Conventions: Use of globals and main functions

2019-08-28 Thread Peter Meissner
The point is, that there are several possible problems. But. One the one hand they are not really problematic in my opinion (I do not care if my function has potential access to objects outside of its environment because this access is read-only at worst and it's not common practice to use this p

Re: [Rd] Conventions: Use of globals and main functions

2019-08-28 Thread Cyclic Group Z_1 via R-devel
I appreciate the well-thought-out comments. To your first point, I am not sure what "glattering" means precisely (a Google search revealed nothing useful), but I assume it means something to the effect of overfilling the main namespace with too many names. Per Norm Matloff's counterpoint in The

[Rd] R CMD check issue

2019-08-28 Thread Therneau, Terry M., Ph.D. via R-devel
I'm running "R CMD check" for 600+ of the packages that depend on survival, and at the end look for     grep Status *.Rcheck/00check.log  | grep ERROR to find any that failed.   But by accident I just looked at the log for the Greg package, which finishes with the lines found below.  Is the f

Re: [Rd] What is the best way to loop over an ALTREP vector?

2019-08-28 Thread Gabriel Becker
Jiefei, I've been meaning to write up something about this so hopefully this will be an impetus for me to actually do that, but until then, responses inline. On Tue, Aug 27, 2019, 7:22 PM Wang Jiefei wrote: > Hi devel team, > > I'm working on C/C++ level ALTREP compatibility for a package. The

Re: [Rd] Conventions: Use of globals and main functions

2019-08-28 Thread Peter Meissner
Firtst, I think that thinking about best practice advise and beeing able to accomandate different usage scenarios is a good thing despite me arguing against introducing the main()-idiom. Let's have another turn on the global-environment is bad argument. It has two parts: (1) Glattering namespace