Re: [PULL 00/21] Test updates (tuxrun tests, new QTest maintainer, ...)

2024-10-21 Thread Peter Maydell
On Mon, 21 Oct 2024 at 14:55, Thomas Huth wrote: > > On 21/10/2024 15.18, Thomas Huth wrote: > > On 21/10/2024 15.00, Peter Maydell wrote: > >> On Mon, 21 Oct 2024 at 12:35, Thomas Huth wrote: > >>> > >>> The following changes since commit > >>> f1dd640896ee2b50cb34328f2568aad324702954: > >>> >

Re: [RFC PATCH v2 4/7] target/arm: call plugin trap callbacks

2024-10-21 Thread Peter Maydell
On Sat, 19 Oct 2024 at 17:39, Julian Ganz wrote: > > We recently introduced API for registering callbacks for trap related > events as well as the corresponding hook functions. Due to differences > between architectures, the latter need to be called from target specific > code. > > This change pla

Re: [Question] What is the definition of “private” fields in QOM?

2024-10-21 Thread Peter Maydell
On Mon, 21 Oct 2024 at 15:12, Zhao Liu wrote: > > Hi Peter, > > On Mon, Oct 21, 2024 at 10:25:07AM +0100, Peter Maydell wrote: > > Date: Mon, 21 Oct 2024 10:25:07 +0100 > > From: Peter Maydell > > Subject: Re: [Question] What is the definition of “private” fields in > > QOM? > > > > On Sat, 19 O

Re: [RFC PATCH 00/16] rust: allow older versions of rustc and bindgen

2024-10-21 Thread Paolo Bonzini
On 10/21/24 16:15, Peter Maydell wrote: Very simple - "cargo install bindgen-cli", as already seen in the fedora-rust-nightly container's Dockerfile (note: building QEMU does _not_ need cargo). In fact we could in fact do it via libvirt-ci, and it's quite possible that MacOS or some BSDs will ne

Re: [PATCH v5 19/19] tests/qtest: Add s390x boot order tests to cdrom-test.c

2024-10-21 Thread Thomas Huth
On 20/10/2024 03.29, jro...@linux.ibm.com wrote: From: Jared Rossi Add two new qtests to verify that a valid IPL device can successfully boot after failed IPL attempts from one or more invalid devices. cdrom-test/as-fallback-device: Defines the primary boot target as a device that is invalid f

[PATCH] util: don't set SO_REUSEADDR on client sockets

2024-10-21 Thread Daniel P . Berrangé
Setting the SO_REUSEADDR property on a socket allows binding to a port number that is in the TIMED_WAIT state. This is usually done on listener sockets, to enable a server to restart itself without having to wait for the completion of TIMED_WAIT on the port. It is also possible, but highly unusual

Re: [RFC PATCH 00/16] rust: allow older versions of rustc and bindgen

2024-10-21 Thread Peter Maydell
On Fri, 18 Oct 2024 at 16:43, Paolo Bonzini wrote: > > On 10/18/24 15:31, Daniel P. Berrangé wrote: > > On Tue, Oct 15, 2024 at 03:17:18PM +0200, Paolo Bonzini wrote: > >> Another possibility > >> could be to accept Rust 1.64.0 but require installi

Re: [PATCH 08/16] rust: build tests for the qemu_api crate

2024-10-21 Thread Zhao Liu
On Tue, Oct 15, 2024 at 03:17:26PM +0200, Paolo Bonzini wrote: > Date: Tue, 15 Oct 2024 15:17:26 +0200 > From: Paolo Bonzini > Subject: [PATCH 08/16] rust: build tests for the qemu_api crate > X-Mailer: git-send-email 2.46.2 > > Fix some bitrot in tests.rs, and allow the unit tests to be run via

Re: [PATCH v3 06/12] target/ppc: Split out helper_dbczl for 970 (fwd)

2024-10-21 Thread Guenter Roeck
On 10/21/24 03:43, BALATON Zoltan wrote: (Resend with fixed ppc list address.) On Sun, 20 Oct 2024, Guenter Roeck wrote: Hi, On Fri, Jul 19, 2024 at 11:07:01AM +1000, Richard Henderson wrote: We can determine at translation time whether the insn is or is not dbczl.  We must retain a runtime c

Re: [PATCH v6 00/16] Introduce support for IGVM files

2024-10-21 Thread Roy Hopkins
> Here is v6 of the set of patches to add support for IGVM files to QEMU. This > is > based on commit a5dd9ee060 of qemu. > > This version addresses all of the review comments from v5 [1]. Hi all. I'm just drawing attention to this series again. It has been through a number of review cycles and a

Re: [PATCH 2/3] vfio/migration: Refactor vfio_vmstate_change/_prepare() error reporting

2024-10-21 Thread Cédric Le Goater
Hello Avihai, On 10/20/24 15:01, Avihai Horon wrote: When the VM is shut down vfio_vmstate_change/_prepare() are called to transition the VFIO device state to STOP. They are called after migration_shutdown() and thus, by this time, the migration object is already freed (more specifically, Migrat

Re: [Question] What is the definition of “private” fields in QOM?

2024-10-21 Thread Zhao Liu
On Mon, Oct 21, 2024 at 03:20:39PM +0100, Peter Maydell wrote: > Date: Mon, 21 Oct 2024 15:20:39 +0100 > From: Peter Maydell > Subject: Re: [Question] What is the definition of “private” fields in > QOM? > > On Mon, 21 Oct 2024 at 15:12, Zhao Liu wrote: > > > > Hi Peter, > > > > On Mon, Oct 21,

Re: [RFC V1 04/14] accel: set accelerator and machine props earlier

2024-10-21 Thread Peter Xu
On Thu, Oct 17, 2024 at 08:14:05AM -0700, Steve Sistare wrote: > Make all global and compat properties available before the first objects > are created. Set accelerator compatibility properties in > configure_accelerators, when the accelerator is chosen, and call > configure_accelerators earlier.

[PATCH 0/6] ui: various improvements to VNC SASL code

2024-10-21 Thread Daniel P . Berrangé
This fixes a few minor edge cases noticed when writing the formal specification for the SASL VNC extension. Daniel P. Berrangé (6): ui/vnc: don't return an empty SASL mechlist to the client ui/vnc: don't raise error formatting socket address for non-inet ui/vnc: fix skipping SASL SSF on UNIX

Re: [PULL v2 00/47] riscv-to-apply queue

2024-10-21 Thread Thomas Huth
On 30/09/2024 13.35, Thomas Huth wrote: On 30/09/2024 12.58, Thomas Huth wrote: On 29/09/2024 22.53, Daniel Henrique Barboza wrote: On 9/29/24 12:38 PM, Peter Maydell wrote: On Sat, 28 Sept 2024 at 21:40, Daniel Henrique Barboza wrote: On 9/28/24 8:34 AM, Peter Maydell wrote: The asser

[PATCH 3/6] ui/vnc: fix skipping SASL SSF on UNIX sockets

2024-10-21 Thread Daniel P . Berrangé
The 'is_unix' flag is set on the VNC server during startup, however, a regression in: commit 8bd22f477f68bbd7a9c88e926e7a58bf65605e39 Author: Daniel P. Berrangé Date: Fri Feb 3 12:06:46 2017 + ui: extract code to connect/listen from vnc_display_open meant we stopped setting the

[PATCH 1/6] ui/vnc: don't return an empty SASL mechlist to the client

2024-10-21 Thread Daniel P . Berrangé
The SASL initialization phase may determine that there are no valid mechanisms available to use. This may be because the host OS admin forgot to install some packages, or it might be because the requested SSF level is incompatible with available mechanisms, or other unknown reasons. If we return a

[PATCH 5/6] ui: fix handling of NULL SASL server data

2024-10-21 Thread Daniel P . Berrangé
The code is supposed to distinguish between SASL server data that is NULL, vs non-NULL but zero-length. It was incorrectly checking the 'serveroutlen' variable, rather than 'serverout' though, so failing to distinguish the cases. Fortunately we can fix this without breaking compatibility with clie

[PATCH 4/6] ui/vnc: don't check for SSF after SASL authentication on UNIX sockets

2024-10-21 Thread Daniel P . Berrangé
Although we avoid requesting an SSF when querying SASL mechanisms for a UNIX socket client, we still mistakenly checked for availability of an SSF once the SASL auth process is complete. Signed-off-by: Daniel P. Berrangé --- ui/vnc-auth-sasl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

[PATCH 2/6] ui/vnc: don't raise error formatting socket address for non-inet

2024-10-21 Thread Daniel P . Berrangé
The SASL library requires the connection's local & remote IP address to be passed in, since some mechanism may use this information. Currently QEMU raises an error for non-inet sockets, but it is valid to pass NULL to the SASL library. Doing so makes SASL work on UNIX sockets. Signed-off-by: Danie

Re: [RFC V1 04/14] accel: set accelerator and machine props earlier

2024-10-21 Thread Peter Xu
On Fri, Oct 18, 2024 at 03:15:56PM -0400, Steven Sistare wrote: > I understand this now. The old code worked in this order: > > qemu_create_early_backends() > ... creates "-object can-bus,id=canbus" > qemu_create_machine() > qemu_apply_machine_options() > applies link property "canb

[PATCH 6/6] ui: validate NUL byte padding in SASL client data more strictly

2024-10-21 Thread Daniel P . Berrangé
When the SASL data is non-NULL, the SASL protocol spec requires that it is padded with a trailing NUL byte. QEMU discards the trailing byte, but does not currently validate that it was in fact a NUL. Apply strict validation to better detect any broken clients. Signed-off-by: Daniel P. Berrangé --

[PATCH] target/mips: Introduce ase_3d_available() helper

2024-10-21 Thread Philippe Mathieu-Daudé
Determine if the MIPS-3D ASE is implemented by checking the state of the 3D bit in the FIR CP1 control register. Remove the then unused ASE_MIPS3D definition. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/cpu.h | 6 ++ target/mips/mips-defs.h

[PATCH] tests/tcg: Stop using exit() in the gdbstub testcases

2024-10-21 Thread Ilya Leoshkevich
GDB 15 does not like exit() anymore: (gdb) python exit(0) Python Exception : 0 Error occurred in Python: 0 Use the GDB's own exit command, like it's already done in a couple places, everywhere. Signed-off-by: Ilya Leoshkevich --- tests/guest-debug/test_gdbstub.py |

Re: [PATCH] target/mips: Introduce ase_3d_available() helper

2024-10-21 Thread Philippe Mathieu-Daudé
On 21/10/24 11:58, Philippe Mathieu-Daudé wrote: Determine if the MIPS-3D ASE is implemented by checking the state of the 3D bit in the FIR CP1 control register. Remove the then unused ASE_MIPS3D definition. I forgot to mention: "Note, this allows using MIPS-3D on the 20Kc model." Signed-of

Re: [PATCH] test: make cached assets for functional tests read-only

2024-10-21 Thread Thomas Huth
On 21/10/2024 14.36, Daniel P. Berrangé wrote: This ensures that if a functional test runs QEMU with a writable disk pointing to a cached asset, an error will be reported, rather than silently modifying the cache file. As an example, tweaking test_sbsaref.py to set snapshot=off, results in a cle

Re: [PATCH] test: make cached assets for functional tests read-only

2024-10-21 Thread Philippe Mathieu-Daudé
On 21/10/24 09:36, Daniel P. Berrangé wrote: This ensures that if a functional test runs QEMU with a writable disk pointing to a cached asset, an error will be reported, rather than silently modifying the cache file. As an example, tweaking test_sbsaref.py to set snapshot=off, results in a clear

Re: [Question] What is the definition of “private” fields in QOM?

2024-10-21 Thread Peter Maydell
On Mon, 21 Oct 2024 at 16:02, Zhao Liu wrote: > > On Mon, Oct 21, 2024 at 03:20:39PM +0100, Peter Maydell wrote: > > What I mean by "the private/public markers are unnecessary" is > > that they don't tell the reader anything, because all the fields > > in a QOM device struct are private. > > This

Re: [PATCH] tests/tcg: Stop using exit() in the gdbstub testcases

2024-10-21 Thread Peter Maydell
On Mon, 21 Oct 2024 at 16:02, Ilya Leoshkevich wrote: > > GDB 15 does not like exit() anymore: > > (gdb) python exit(0) > Python Exception : 0 > Error occurred in Python: 0 > > Use the GDB's own exit command, like it's already done in a couple > places, everywhere. This is the same bu

Re: [RFC V1 00/14] precreate phase

2024-10-21 Thread Steven Sistare
On 10/17/2024 11:53 AM, Peter Xu wrote: On Thu, Oct 17, 2024 at 11:19:51AM -0400, Steven Sistare wrote: On 10/17/2024 11:14 AM, Steve Sistare wrote: Define a new qemu initialization phase called 'precreate' which occurs before most backends or devices have been created. The only exception is m

Re: [PULL 00/21] Test updates (tuxrun tests, new QTest maintainer, ...)

2024-10-21 Thread Thomas Huth
On 21/10/2024 17.39, Peter Maydell wrote: On Mon, 21 Oct 2024 at 15:11, Thomas Huth wrote: Looking at the log files of the job, I can see in https://gitlab.com/qemu-project/qemu/-/jobs/8141649069/artifacts/browse/build/tests/functional/aarch64/test_aarch64_tuxrun.TuxRunAarch64Test.test_arm64be/

Re: [PATCH v2] plugins: fix qemu_plugin_reset

2024-10-21 Thread Pierrick Bouvier
On 10/21/24 03:22, Alex Bennée wrote: Pierrick Bouvier writes: 34e5e1 refactored the plugin context initialization. After this change, tcg_ctx->plugin_insn is not reset inconditionnally anymore, but only if one plugin at least is active. When uninstalling the last plugin active, we stopped re

Re: [PATCH] .gitlab-ci.d/cirrus: Remove the macos-15 job

2024-10-21 Thread Philippe Mathieu-Daudé
On 21/10/24 09:47, Thomas Huth wrote: Cirrus-CI stopped providing the possibility to run macOS 15 jobs. Quoting https://cirrus-ci.org/guide/macOS/ : "Cirrus CI Cloud only allows ghcr.io/cirruslabs/macos-runner:sonoma image ..." Odd, Sequoia is still available: https://github.com/cirruslabs/

[PULL v2 13/20] tests/functional: Convert the Avocado x86_64 tuxrun test

2024-10-21 Thread Thomas Huth
Move the tests to a new file so that they can be run via qemu-system-x86_64 in the functional framework. Signed-off-by: Thomas Huth Message-ID: <20241011131937.377223-11-th...@redhat.com> --- MAINTAINERS| 1 + tests/avocado/tuxrun_baselines.py | 18 -

[PULL v2 16/20] tests/functional: Convert the Avocado mips64 tuxrun test

2024-10-21 Thread Thomas Huth
Move the test into a new file so that it can be run via qemu-system-mips64 in the functional framework. Signed-off-by: Thomas Huth Message-ID: <20241011131937.377223-14-th...@redhat.com> --- tests/avocado/tuxrun_baselines.py | 17 - tests/functional/meson.build | 4 ++

[PULL v2 20/20] tests/functional: Convert the Avocado sh4 tuxrun test

2024-10-21 Thread Thomas Huth
Move the test into a new file so that it can be run via qemu-system-sh4 in the functional framework. Signed-off-by: Thomas Huth Message-ID: <20241011131937.377223-18-th...@redhat.com> --- MAINTAINERS | 1 + tests/avocado/tuxrun_baselines.py | 35 -- tes

[PULL v2 17/20] tests/functional: Convert the Avocado mips64el tuxrun test

2024-10-21 Thread Thomas Huth
Move the test into a new file so that it can be run via qemu-system-mips64el in the functional framework. Signed-off-by: Thomas Huth Message-ID: <20241011131937.377223-15-th...@redhat.com> --- MAINTAINERS | 5 ++-- tests/avocado/tuxrun_baselines.py| 16 -

[PULL v2 12/20] tests/functional: Convert the Avocado i386 tuxrun test

2024-10-21 Thread Thomas Huth
Move the tests to a new file so that they can be run via qemu-system-i386 in the functional framework. Signed-off-by: Thomas Huth Message-ID: <20241011131937.377223-10-th...@redhat.com> --- MAINTAINERS | 1 + tests/avocado/tuxrun_baselines.py| 16 - test

Re: [PATCH v3 0/3] build qemu with gcc and tsan

2024-10-21 Thread Pierrick Bouvier
On 9/25/24 03:43, Alex Bennée wrote: Alex Bennée writes: Queued to testing/next, thanks. Gentle ping. I can't see this series on testing/next. Was it lost on the way? Thanks, Pierrick

[PULL v2 15/20] tests/functional: Convert the Avocado mipsel tuxrun test

2024-10-21 Thread Thomas Huth
Move the test into a new file so that it can be run via qemu-system-mipsel in the functional framework. Signed-off-by: Thomas Huth Message-ID: <20241011131937.377223-13-th...@redhat.com> --- tests/avocado/tuxrun_baselines.py | 17 tests/functional/meson.build | 1 +

[PULL v2 09/20] tests/functional: Convert the Avocado arm tuxrun tests

2024-10-21 Thread Thomas Huth
Move the tests to a new file so that they can be run via qemu-system-arm in the functional framework. Signed-off-by: Thomas Huth Message-ID: <20241011131937.377223-7-th...@redhat.com> --- MAINTAINERS | 1 + tests/avocado/tuxrun_baselines.py | 56 ---

[PULL v2 18/20] tests/functional: Convert the Avocado ppc32 tuxrun test

2024-10-21 Thread Thomas Huth
Move the test into a new file so that it can be run via qemu-system-ppc in the functional framework. Signed-off-by: Thomas Huth Message-ID: <20241011131937.377223-16-th...@redhat.com> --- MAINTAINERS | 1 + tests/avocado/tuxrun_baselines.py | 16 - tests/fu

[PULL v2 00/20] Test updates (tuxrun tests, new QTest maintainer, ...)

2024-10-21 Thread Thomas Huth
The following changes since commit f1dd640896ee2b50cb34328f2568aad324702954: Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2024-10-18 10:42:56 +0100) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-request-2024-10-21 for you t

Re: [PATCH v2 0/3] crypto: fix regression in hash result buffer handling

2024-10-21 Thread Daniel P . Berrangé
On Wed, Oct 16, 2024 at 07:33:56PM +0600, Dorjoy Chowdhury wrote: > On Wed, Oct 16, 2024 at 4:20 PM Daniel P. Berrangé > wrote: > > > > > > > > Daniel P. Berrangé (3): > > crypto/hash: avoid overwriting user supplied result pointer > > tests: correctly validate result buffer in hash/hmac test

[PULL v2 14/20] tests/functional: Convert the Avocado mips tuxrun test

2024-10-21 Thread Thomas Huth
Move the test into a new file so that it can be run via qemu-system-mips in the functional framework. Signed-off-by: Thomas Huth Message-ID: <20241011131937.377223-12-th...@redhat.com> --- tests/avocado/tuxrun_baselines.py| 18 -- tests/functional/meson.build | 1 + test

Re: [PATCH v3 1/4] qemu-ga: 'Null' check for mandatory parameters

2024-10-21 Thread Konstantin Kostiuk
On Mon, Oct 21, 2024 at 7:45 PM Daniel P. Berrangé wrote: > On Mon, Oct 21, 2024 at 09:28:36PM +0800, Dehan Meng wrote: > > sscanf return values are checked and add 'Null' check for > > mandatory parameters. > > > > Signed-off-by: Dehan Meng > > --- > > qga/commands-linux.c | 12 +++- >

Re: [PATCH] target/mips: Remove unused CPUMIPSState::current_fpu field

2024-10-21 Thread Pierrick Bouvier
On 10/21/24 08:12, Philippe Mathieu-Daudé wrote: The 'current_fpu' field is unused since commit f01be154589 ("Move the active FPU registers into env again, and use more TCG registers to access them"). Signed-off-by: Philippe Mathieu-Daudé --- target/mips/cpu.h| 1 - target/mips/s

Re: [PATCH] target/i386: Do not re-compute new pc with CF_PCREL

2024-10-21 Thread Pierrick Bouvier
On 1/1/24 15:06, Richard Henderson wrote: With PCREL, we have a page-relative view of EIP, and an approximation of PC = EIP+CSBASE that is good enough to detect page crossings. If we try to recompute PC after masking EIP, we will mess up that approximation and write a corrupt value to EIP. We a

Re: [PATCH] target/mips: Introduce ase_3d_available() helper

2024-10-21 Thread Richard Henderson
On 10/21/24 08:02, Philippe Mathieu-Daudé wrote: On 21/10/24 11:58, Philippe Mathieu-Daudé wrote: Determine if the MIPS-3D ASE is implemented by checking the state of the 3D bit in the FIR CP1 control register. Remove the then unused ASE_MIPS3D definition. I forgot to mention:  "Note, this a

Re: [PATCH v4] scripts/symlink-install-tree.py: Fix MESONINTROSPECT parsing

2024-10-21 Thread Pierrick Bouvier
On 10/18/24 06:08, Peter Maydell wrote: From: Akihiko Odaki The arguments in MESONINTROSPECT are quoted with shlex.quote() so it must be parsed with shlex.split(). Otherwise the script will fail if the build directory has a character like "~" in it. Note: this fix cannot be backported directl

Re: [PATCH 0/2] arm: Add collie and sx functional tests

2024-10-21 Thread Thomas Huth
On 17/10/2024 18.32, Peter Maydell wrote: This patchset adds new functional tests for the collie and sx1 boards, which are the only remaining ones that survived the culling of the OMAP/PXA2xx/strongarm machines. For these tests I'm indebted to Guenter Roeck, who has kindly built and made availab

Re: [PATCH 05/16] rust: fix cfgs of proc-macro2 for 1.63.0

2024-10-21 Thread Zhao Liu
On Tue, Oct 15, 2024 at 03:17:23PM +0200, Paolo Bonzini wrote: > Date: Tue, 15 Oct 2024 15:17:23 +0200 > From: Paolo Bonzini > Subject: [PATCH 05/16] rust: fix cfgs of proc-macro2 for 1.63.0 > X-Mailer: git-send-email 2.46.2 > > Replay the configuration that would be computed by build.rs when com

Re: [PULL 08/20] virtio-net: Add only one queue pair when realizing

2024-10-21 Thread Jason Wang
On Sat, Oct 19, 2024 at 8:38 PM Akihiko Odaki wrote: > > On 2024/10/18 13:50, Jason Wang wrote: > > On Thu, Oct 17, 2024 at 5:42 PM Akihiko Odaki > > wrote: > >> > >> On 2024/10/17 18:17, Laurent Vivier wrote: > >>> On 17/10/2024 11:07, Akihiko Odaki wrote: > On 2024/10/17 16:32, Laurent Vi

Re: [PATCH] rust: introduce alternative implementation of offset_of!

2024-10-21 Thread Junjie Mao
Paolo Bonzini writes: > On 10/21/24 07:40, Junjie Mao wrote: >> offset_of! was stabilized in Rust 1.77.0. Use an alternative implemenation >> that was found on the Rust forums, and whose author agreed to license as >> MIT for use in QEMU. >> The alternative allows only one level of field access

Re: [PATCH 6/7] virtio-net: Copy received header to buffer

2024-10-21 Thread Jason Wang
On Sun, Sep 15, 2024 at 9:07 AM Akihiko Odaki wrote: > > receive_header() used to cast the const qualifier of the pointer to the > received packet away to modify the header. Avoid this by copying the > received header to buffer. > > Signed-off-by: Akihiko Odaki > --- > hw/net/virtio-net.c | 85

Re: [PATCH 3/7] virtio-net: Do not check for the queue before RSS

2024-10-21 Thread Jason Wang
On Sun, Sep 15, 2024 at 9:07 AM Akihiko Odaki wrote: > > virtio_net_can_receive() checks if the queue is ready, but RSS will > change the queue to use so, strictly speaking, we may still be able to > receive the packet even if the queue initially provided is not ready. > Perform RSS before virtio_

Re: [PATCH] dockerfiles: fix default targets for debian-loongarch-cross

2024-10-21 Thread Alex Bennée
Pierrick Bouvier writes: > fix system target name, and remove --disable-system (which deactivates > system target). > > Found using: make docker-test-build@debian-loongarch-cross V=1 > > Signed-off-by: Pierrick Bouvier > --- > tests/docker/dockerfiles/debian-loongarch-cross.docker | 4 ++-- > 1

Re: [PATCH] qemu-ga: Fix a SIGSEGV on guest-set-time command

2024-10-21 Thread Daniel P . Berrangé
On Fri, Oct 18, 2024 at 03:34:39PM +0530, Sunil Nimmagadda wrote: > qemu-ga on a NetBSD -current VM terminates with a SIGSEGV upon receiving > 'guest-set-time' command... > > Core was generated by `qemu-ga'. > Program terminated with signal SIGSEGV, Segmentation fault. > #0 0x0cd37a40 in

Re: [PATCH] sockets: Remove deadcode

2024-10-21 Thread Daniel P . Berrangé
On Sat, Oct 19, 2024 at 12:02:01PM +, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > On Thu, Sep 19, 2024 at 12:26:33AM +0100, d...@treblig.org wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > socket_remote_address hasn't been used since it was ad

Re: [PATCH] tests/tcg/aarch64: Use raw strings for regexes in test-mte.py

2024-10-21 Thread Alex Bennée
Gustavo Romero writes: > Use Python's raw string notation instead of string literals for regex so > it's not necessary to double backslashes when regex special forms are > used. Raw notation is preferred for regex and easier to read. > > Signed-off-by: Gustavo Romero Queued to gdbstub/next, tha

Re: [PATCH 6/7] virtio-net: Copy received header to buffer

2024-10-21 Thread Jason Wang
On Mon, Oct 21, 2024 at 4:21 PM Jason Wang wrote: > > On Sun, Sep 15, 2024 at 9:07 AM Akihiko Odaki > wrote: > > > > receive_header() used to cast the const qualifier of the pointer to the > > received packet away to modify the header. Avoid this by copying the > > received header to buffer. > >

Re: [PATCH] testing: Enhance gdb probe script

2024-10-21 Thread Alex Bennée
Gustavo Romero writes: > Use list and set comprehension to simplify code. Also, gently handle > invalid gdb filenames. > > Signed-off-by: Gustavo Romero Queued to gdbstub/next, thanks. -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v2] spapr: nested: Add support for DPDES SPR in GSB for TCG L0

2024-10-21 Thread Harsh Prateek Bora
On 10/18/24 22:08, Amit Machhiwal wrote: The DPDES support for doorbell emulation and handling for KVM on PAPR guests was added in Linux via [1]. Subsequently, a new GSB (Guest State Buffer) element for DPDES was added in Linux; the same has been missing in TCG L0 implementation. Add support f

Re: [PATCH] rust: introduce alternative implementation of offset_of!

2024-10-21 Thread Paolo Bonzini
Il lun 21 ott 2024, 09:24 Junjie Mao ha scritto: > > Thanks. I still prefer to keep the procedural macro code minimal, and > have the > > code generation in a separate macro, but this is a nice start! > > > > I'm not sure if I get your point right. > > My understanding is that preferring minimiz

Re: [PATCH V1 0/4] Arch agnostic ACPI changes to support vCPU Hotplug (on Archs like ARM)

2024-10-21 Thread Miguel Luis
Hi Gustavo, > On 18 Oct 2024, at 17:57, Gustavo Romero wrote: > > Hi Miguel, > > On 10/15/24 15:41, Miguel Luis wrote: >> Hi Salil, >> I’ve ran the usual tests successfully of hotplug/unplug from the number of >> cold-booted cpus up to maxcpus and migration on ARM. Please feel free to add: >

Re: [PATCH] qemu-ga: Fix a SIGSEGV on guest-set-time command

2024-10-21 Thread Konstantin Kostiuk
Reviewed-by: Konstantin Kostiuk On Fri, Oct 18, 2024 at 1:14 PM Sunil Nimmagadda wrote: > qemu-ga on a NetBSD -current VM terminates with a SIGSEGV upon receiving > 'guest-set-time' command... > > Core was generated by `qemu-ga'. > Program terminated with signal SIGSEGV, Segmentation fault. > #

Re: [RFC V1 13/14] net: cleanup for precreate phase

2024-10-21 Thread Peter Xu
On Thu, Oct 17, 2024 at 08:14:14AM -0700, Steve Sistare wrote: > Guard against unconfigured state if cleanup is called early, such as > during the precreate phase. > > Signed-off-by: Steve Sistare Reviewed-by: Peter Xu One nitpick.. > --- > net/net.c | 4 +++- > 1 file changed, 3 insertions(

Re: [RFC V1 01/14] accel: encapsulate search state

2024-10-21 Thread Fabiano Rosas
Steve Sistare writes: > Save the state of the search for a working machine accelerator in > the new structure AccelSearch. No functional change. > > Signed-off-by: Steve Sistare Reviewed-by: Fabiano Rosas

Re: [PATCH] target/mips: Remove unused CPUMIPSState::current_fpu field

2024-10-21 Thread Richard Henderson
On 10/21/24 08:12, Philippe Mathieu-Daudé wrote: The 'current_fpu' field is unused since commit f01be154589 ("Move the active FPU registers into env again, and use more TCG registers to access them"). Signed-off-by: Philippe Mathieu-Daudé --- target/mips/cpu.h| 1 - target/mips/sy

Re: [PATCH 1/2] ui: Allow injection of vnc display name

2024-10-21 Thread Andrew Keesler
Hi Marc-André - The ability to set the name with QMP qom-set seems like a nice behavior. Note that the ultimate goal of this name is to propagate it downstream to a device (see next patch[0] for a sample propagation to virtio-gpu). In order to accomplish this, would it work to expose this new "h

Re: [RFC PATCH v2 3/7] contrib/plugins: add plugin showcasing new trap related API

2024-10-21 Thread Julian Ganz
October 21, 2024 at 8:07 PM, "Pierrick Bouvier" wrote: > On 10/19/24 09:39, Julian Ganz wrote: > > + max_vcpus = info->system.max_vcpus; > > + traps = calloc(max_vcpus, sizeof(TrapCounters)); > > > Instead of allocating data for max number of vcpu, you can use a > qemu_plugin_scoreboard, which

Re: [PATCH V1 1/4] hw/acpi: Initialize ACPI Hotplug CPU Status with Support for vCPU `Persistence`

2024-10-21 Thread Salil Mehta
Hi Gustavo On Thu, Oct 17, 2024 at 9:25 PM Gustavo Romero wrote: > Hi Salil, > > On 10/14/24 16:22, Salil Mehta wrote: > > Certain CPU architecture specifications [1][2][3] prohibit changes to CPU > > presence after the kernel has booted. This limitation exists because > many system > > initiali

Re: [PATCH V1 1/4] hw/acpi: Initialize ACPI Hotplug CPU Status with Support for vCPU `Persistence`

2024-10-21 Thread Salil Mehta
Hi Igor, Thanks for taking time to review and sorry for not being prompt. I was in transit due to some difficult personal situation. On Fri, Oct 18, 2024 at 3:11 PM Igor Mammedov wrote: > On Mon, 14 Oct 2024 20:22:02 +0100 > Salil Mehta wrote: > > > Certain CPU architecture specifications [1][

[PATCH] migration: Deprecate query-migrationthreads command

2024-10-21 Thread Peter Xu
Per previous discussion [1,2], this patch deprecates query-migrationthreads command. To summarize, the major reason of the deprecation is due to no sensible way to consume the API properly: (1) The reported list of threads are incomplete (ignoring destination threads and non-multifd threa

Re: [PATCH] virtio-net: Avoid indirection_table_mask overflow

2024-10-21 Thread Jason Wang
On Tue, Oct 8, 2024 at 2:51 PM Akihiko Odaki wrote: > > We computes indirections_len by adding 1 to indirection_table_mask, but > it may overflow indirection_table_mask is UINT16_MAX. Check if > indirection_table_mask is small enough before adding 1. > > Fixes: 590790297c0d ("virtio-net: implement

[PULL v1 0/1] Xen Queue

2024-10-21 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" The following changes since commit f1dd640896ee2b50cb34328f2568aad324702954: Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2024-10-18 10:42:56 +0100) are available in the Git repository at: https://gitlab.com/edgar.iglesias/qemu.git t

Re: [PATCH v5 07/19] pc-bios/s390-ccw: Remove panics from ISO IPL path

2024-10-21 Thread Thomas Huth
On 20/10/2024 03.29, jro...@linux.ibm.com wrote: From: Jared Rossi Remove panic-on-error from IPL ISO El Torito specific functions so that error recovery may be possible in the future. Functions that would previously panic now provide a return code. Signed-off-by: Jared Rossi --- pc-bios/s

Re: [PATCH v4] hw/ppc: Implement -dtb support for PowerNV

2024-10-21 Thread Aditya Gupta
Hi all, Just a ping for this. Any comments ? Thanks, Aditya Gupta On 20/08/24 16:00, Aditya Gupta wrote: Currently any device tree passed with -dtb option in QEMU, was ignored by the PowerNV code. Read and pass the passed -dtb to the kernel, thus enabling easier debugging with custom DTBs.

Re: [PATCH 08/16] rust: build tests for the qemu_api crate

2024-10-21 Thread Zhao Liu
On Tue, Oct 15, 2024 at 03:17:26PM +0200, Paolo Bonzini wrote: > Date: Tue, 15 Oct 2024 15:17:26 +0200 > From: Paolo Bonzini > Subject: [PATCH 08/16] rust: build tests for the qemu_api crate > X-Mailer: git-send-email 2.46.2 > > Fix some bitrot in tests.rs, and allow the unit tests to be run via

Re: [Question] What is the definition of “private” fields in QOM?

2024-10-21 Thread Daniel P . Berrangé
On Sun, Oct 20, 2024 at 12:10:14AM +0800, Zhao Liu wrote: > Hi maintainers and list, > > In the QOM structure, the class and object structs have two members: > parent_class and parent_obj, which are often marked as "< private >" in > the comment. > > I couldn’t find information on why to define ‘

Re: [PULL 08/20] virtio-net: Add only one queue pair when realizing

2024-10-21 Thread Akihiko Odaki
On 2024/10/21 16:23, Jason Wang wrote: On Sat, Oct 19, 2024 at 8:38 PM Akihiko Odaki wrote: On 2024/10/18 13:50, Jason Wang wrote: On Thu, Oct 17, 2024 at 5:42 PM Akihiko Odaki wrote: On 2024/10/17 18:17, Laurent Vivier wrote: On 17/10/2024 11:07, Akihiko Odaki wrote: On 2024/10/17 16:32

Re: [PATCH 08/16] rust: build tests for the qemu_api crate

2024-10-21 Thread Paolo Bonzini
On Mon, Oct 21, 2024 at 10:50 AM Zhao Liu wrote: > > +rust.test('rust-qemu-api-tests', _qemu_api_rs) > > It seems the change will bring a warning for "./configure --enable-rust": > > WARNING: Unknown keyword argument(s) in target rust-qemu-api-tests: rust_abi, > prelink, pic. This is a Meson bug

Re: [PATCH v3] tests/functional: Convert most Aspeed machine tests

2024-10-21 Thread Thomas Huth
On 18/10/2024 09.17, Cédric Le Goater wrote: This is a simple conversion of the tests with some cleanups and adjustments to match the new test framework. Replace the zephyr image MD5 hashes with SHA256 hashes while at it. The SDK tests depend on a ssh class from avocado.utils which is difficult

Re: [SPAM] [PATCH v1 03/16] hw/block:m25p80: Support write status register 2 command (0x31) for w25q01jvq

2024-10-21 Thread Cédric Le Goater
On 10/18/24 07:30, Jamin Lin wrote: According to the w25q01jv datasheet at page 16, it is required to set QE bit in "Status Register 2" to enable quad mode. Currently, m25p80 support users utilize "Write Status Register 1(0x01)" command to set QE bit in "Status Register 2" and utilize "Read Stat

Re: [SPAM] [PATCH v1 05/16] hw/arm/aspeed: Correct spi_model w25q256 for ast1030-a1 EVB.

2024-10-21 Thread Cédric Le Goater
On 10/18/24 07:31, Jamin Lin wrote: Currently, the default spi_model was "sst25vf032b" whose size was 4MB for ast1030-a1 EVB. However, according to the schematic of ast1030-a1 EVB, ASPEED shipped default flash of spi1 and spi2 were w25q256 whose size was 32MB. Correct spi_model default flash to

Re: [Question] What is the definition of “private” fields in QOM?

2024-10-21 Thread Zhao Liu
Hi Daniel, On Mon, Oct 21, 2024 at 09:35:22AM +0100, Daniel P. Berrangé wrote: > Date: Mon, 21 Oct 2024 09:35:22 +0100 > From: "Daniel P. Berrangé" > Subject: Re: [Question] What is the definition of “private” fields in > QOM? > > On Sun, Oct 20, 2024 at 12:10:14AM +0800, Zhao Liu wrote: > > Hi

Re: [SPAM] [PATCH v1 06/16] hw/arm/aspeed: Correct fmc_model w25q80bl for ast1030-a1 EVB

2024-10-21 Thread Cédric Le Goater
On 10/18/24 07:31, Jamin Lin wrote: Currently, the default fmc_model was "sst25vf032b" whose size was 4MB for ast1030-a1 EVB. However, according to the schematic of ast1030-a1 EVB, ASPEED shipped default flash of fmc_cs0 and fmc_cs1 were "w25q80bl" and "w25q256", respectively. The size of w25q80b

Re: [SPAM] [PATCH v1 04/16] hw/block/m25p80: Add SFDP table for w25q80bl flash

2024-10-21 Thread Cédric Le Goater
On 10/18/24 07:31, Jamin Lin wrote: Add the SFDP table for the Windbond w25q80bl flash. Signed-off-by: Jamin Lin capabilities exposed to Linux look correct : root@ast2600-default:~# cat /sys/kernel/debug/spi-nor/spi0.1/* Supported read modes by the flash 1S-1S-1S opc

Re: [PATCH v5 08/19] pc-bios/s390-ccw: Remove panics from ECKD IPL path

2024-10-21 Thread Thomas Huth
On 20/10/2024 03.29, jro...@linux.ibm.com wrote: From: Jared Rossi Remove panic-on-error from ECKD block device IPL specific functions so that error recovery may be possible in the future. Functions that would previously panic now provide a return code. Signed-off-by: Jared Rossi --- pc-bi

Re: [PATCH 0/2] arm: Add collie and sx functional tests

2024-10-21 Thread Thomas Huth
On 21/10/2024 09.15, Thomas Huth wrote: On 17/10/2024 18.32, Peter Maydell wrote: This patchset adds new functional tests for the collie and sx1 boards, which are the only remaining ones that survived the culling of the OMAP/PXA2xx/strongarm machines. For these tests I'm indebted to Guenter Roe

Re: [PATCH v2] tests/vm: update openbsd image to 7.6

2024-10-21 Thread Daniel P . Berrangé
On Sun, Oct 13, 2024 at 02:19:41AM -0400, Brad Smith wrote: > tests/vm: update openbsd image to 7.6 > > Remove tomli as Python has been updated to 3.11. > > Signed-off-by: Brad Smith > --- > tests/vm/openbsd | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tests/v

[PULL v1 1/1] hw/xen: Avoid use of uninitialized bufioreq_evtchn

2024-10-21 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Avoid use of uninitialized bufioreq_evtchn. It should only be used if buffered IOREQs are enabled. Resolves: Coverity CID 1563383 Reported-by: Peter Maydell Acked-by: Stefano Stabellini Signed-off-by: Edgar E. Iglesias --- hw/xen/xen-hvm-common.c | 7 --- 1 file

Re: [PATCH] vhost-user: fix shared object return values

2024-10-21 Thread Albert Esteve
On Thu, Oct 17, 2024 at 11:38 AM Stefano Garzarella wrote: > > On Thu, Oct 17, 2024 at 10:27:30AM +0200, Albert Esteve wrote: > >Albert Esteve > > > >Senior Software Engineer > > > >Red Hat > > > >aest...@redhat.com > > > > > > > >On Thu, Oct 17, 2024 at 9:38 AM Stefano Garzarella > >wrote: > >>

Re: [PATCH v5 11/19] pc-bios/s390-ccw: Remove panics from Netboot IPL path

2024-10-21 Thread Thomas Huth
On 20/10/2024 03.29, jro...@linux.ibm.com wrote: From: Jared Rossi Remove panic-on-error from Netboot specific functions so that error recovery may be possible in the future. Functions that would previously panic now provide a return code. Signed-off-by: Jared Rossi --- pc-bios/s390-ccw/s3

Re: [PATCH v3] tests/functional: Convert most Aspeed machine tests

2024-10-21 Thread Thomas Huth
On 21/10/2024 11.31, Cédric Le Goater wrote: Hello Thomas, On 10/21/24 10:53, Thomas Huth wrote: On 18/10/2024 09.17, Cédric Le Goater wrote: This is a simple conversion of the tests with some cleanups and adjustments to match the new test framework. Replace the zephyr image MD5 hashes with S

Re: [PATCH v3] tests/functional: Convert most Aspeed machine tests

2024-10-21 Thread Cédric Le Goater
Hello Thomas, On 10/21/24 10:53, Thomas Huth wrote: On 18/10/2024 09.17, Cédric Le Goater wrote: This is a simple conversion of the tests with some cleanups and adjustments to match the new test framework. Replace the zephyr image MD5 hashes with SHA256 hashes while at it. The SDK tests depen

Re: [PATCH v4 1/9] target/riscv: fix henvcfg potentially containing stale bits

2024-10-21 Thread Clément Léger
On 21/10/2024 02:46, Alistair Francis wrote: > On Fri, Oct 18, 2024 at 12:55 AM Clément Léger wrote: >> >> With the current implementation, if we had the current scenario: >> - set bit x in menvcfg >> - set bit x in henvcfg >> - clear bit x in menvcfg >> then, the internal variable env->henvcfg

Re: [PATCH 0/2] arm: Add collie and sx functional tests

2024-10-21 Thread Thomas Huth
On 21/10/2024 11.17, Peter Maydell wrote: On Mon, 21 Oct 2024 at 09:01, Thomas Huth wrote: On 21/10/2024 09.15, Thomas Huth wrote: On 17/10/2024 18.32, Peter Maydell wrote: This patchset adds new functional tests for the collie and sx1 boards, which are the only remaining ones that survived

Re: [PATCH v5 09/19] pc-bios/s390-ccw: Remove panics from SCSI IPL path

2024-10-21 Thread Thomas Huth
On 20/10/2024 03.29, jro...@linux.ibm.com wrote: From: Jared Rossi Remove panic-on-error from virtio-scsi IPL specific functions so that error recovery may be possible in the future. Functions that would previously panic now provide a return code. Signed-off-by: Jared Rossi --- pc-bios/s39

Re: [Question] What is the definition of “private” fields in QOM?

2024-10-21 Thread Peter Maydell
On Sat, 19 Oct 2024 at 16:54, Zhao Liu wrote: > > Hi maintainers and list, > > In the QOM structure, the class and object structs have two members: > parent_class and parent_obj, which are often marked as "< private >" in > the comment. > > I couldn’t find information on why to define ‘private’ an

  1   2   3   4   >