On Sat, 19 Oct 2024 at 16:54, Zhao Liu <zhao1....@intel.com> wrote: > > Hi maintainers and list, > > In the QOM structure, the class and object structs have two members: > parent_class and parent_obj, which are often marked as "< private >" in > the comment. > > I couldn’t find information on why to define ‘private’ and ‘public’, > even in the earliest QOM commits and the patch emails I could find.
This is a rather old thing which I think was originally borrowed from glib's commenting convention. I'm fairly sure that we decided a while back that they were entirely unnecessary, so you don't need to add them in new code. (I can't actually find anything with a quick list search about that though so maybe I'm misremembering.) Either way, there's still a lot of them floating around in the codebase that were added before we made that decision. thanks -- PMM