[PATCH 0/7] hw/cxl: Round up of fixes.

2024-10-14 Thread Jonathan Cameron via
A mixed bag of fixes that have all been on the list already with the exception of: "hw/pci-bridge: Make pxb_dev_realize_common() return if it succeeded" (so that's the one that needs more eyes). I've tweaked the others to fix typos and correct Fixes tags (adding them where missing and fixing forma

Re: [PATCH] configure, meson: synchronize defaults for configure and Meson Rust options

2024-10-14 Thread Peter Maydell
On Mon, 14 Oct 2024 at 13:09, Peter Maydell wrote: > > On Mon, 14 Oct 2024 at 12:45, Peter Maydell wrote: > > > > On Mon, 14 Oct 2024 at 12:01, Paolo Bonzini wrote: > > > > > > If the defaults for --enable-rust ($rust in configure) and Meson's rust > > > option are out of sync, incremental build

Re: [PATCH] migration: Remove interface query-migrationthreads

2024-10-14 Thread Daniel P . Berrangé
On Mon, Oct 14, 2024 at 11:22:21AM -0300, Fabiano Rosas wrote: > Daniel P. Berrangé writes: > > > On Fri, Oct 11, 2024 at 11:34:17AM -0400, Peter Xu wrote: > >> This reverts two commits: > >> > >> 671326201dac8fe91222ba0045709f04a8ec3af4 > >> 1b1f4ab69c41279a45ccd0d3178e83471e6e4ec1 > >> > >> M

Re: [PATCH] meson: check in main meson.build for native Rust compiler

2024-10-14 Thread Paolo Bonzini
On Mon, Oct 14, 2024 at 4:41 PM Peter Maydell wrote: > > On Mon, 14 Oct 2024 at 15:38, Peter Maydell wrote: > > > > On Mon, 14 Oct 2024 at 15:36, Paolo Bonzini wrote: > > > > > > A working native Rust compiler is always needed in order to compile Rust > > > code, even when cross compiling, in or

Re: [PATCH v6 0/5] target/riscv: Add Smrnmi support.

2024-10-14 Thread Daniel Henrique Barboza
On 10/14/24 6:04 AM, Frank Chang wrote: Clément Léger 於 2024年10月14日 週一 下午3:36寫道: On 11/10/2024 13:38, Daniel Henrique Barboza wrote: Hi Tommy, Do you plan to send a new version of this work soon? This series is a prerequisite of "target/riscv: Add support for Smdbltrp and Ssdbltrp exte

Re: [PATCH] configure, meson: synchronize defaults for configure and Meson Rust options

2024-10-14 Thread Peter Maydell
On Mon, 14 Oct 2024 at 12:01, Paolo Bonzini wrote: > > If the defaults for --enable-rust ($rust in configure) and Meson's rust > option are out of sync, incremental builds will pick Meson's default. > > This happens because, on an incremental build, configure does not run > Meson, Make does instea

Re: [RFC PATCH 2/4] arm/tcg: add decodetree entry for DSB nXS variant

2024-10-14 Thread Richard Henderson
On 10/14/24 03:48, Manos Pitsidianakis wrote: +static bool trans_DSB_nXS(DisasContext *ctx, arg_DSB_nXS *a) +{ +tcg_gen_mb(TCG_BAR_SC | TCG_MO_ALL); +return true; +} This is missing the feature test: if (!dc_isar_feature(aa64_xs, ctx)) { return false; } r~

Re: [RFC PATCH 3/4] arm/tcg/cpu64: add FEAT_XS feat in max cpu

2024-10-14 Thread Richard Henderson
On 10/14/24 03:48, Manos Pitsidianakis wrote: Add FEAT_XS feature report value in max cpu's ID_AA64ISAR1 sys register. Signed-off-by: Manos Pitsidianakis --- target/arm/tcg/cpu64.c | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Richard Henderson r~

Re: [RFC PATCH 3/4] arm/tcg/cpu64: add FEAT_XS feat in max cpu

2024-10-14 Thread Richard Henderson
On 10/14/24 03:48, Manos Pitsidianakis wrote: Add FEAT_XS feature report value in max cpu's ID_AA64ISAR1 sys register. Signed-off-by: Manos Pitsidianakis --- target/arm/tcg/cpu64.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/arm/tcg/cpu64.c b/target/arm/tcg/cpu64.c index 0168

Re: [RFC PATCH 4/4] tests/tcg/aarch64: add system test for FEAT_XS

2024-10-14 Thread Richard Henderson
On 10/14/24 03:48, Manos Pitsidianakis wrote: Add system test to make sure FEAT_XS is enabled for max cpu emulation and that QEMU doesn't crash when encountering an NXS instruction variant. Signed-off-by: Manos Pitsidianakis --- tests/tcg/aarch64/system/feat-xs.c | 27 +

Re: [PATCH v16 02/13] hw/ppc/spapr_pci: Do not create DT for disabled PCI device

2024-10-14 Thread Shivaprasad G Bhat
On 10/11/24 10:52 PM, Shivaprasad G Bhat wrote: On 9/18/24 7:57 PM, Cédric Le Goater wrote: Hello, Adding :   Harsh for QEMU/PPC pseries machine,   Shivaprasad for KVM/PPC VFIO and IOMMU support. Could you please give us your feedback on these changes ? Thanks, C.  On 9/13/24 05:44, A

Re: [PATCH] tests: update lcitool to fix freebsd py311-yaml rename

2024-10-14 Thread Peter Maydell
On Mon, 14 Oct 2024 at 14:03, Daniel P. Berrangé wrote: > > This addresses the py311-yaml -> py311-pyyaml rename in FreeBSD. > > The change to the OpenSUSE dockerfile is something that will allow > QEMU to access rust bindgen in future. > > Signed-off-by: Daniel P. Berrangé > --- Applied directl

Re: [PATCH v16 03/13] hw/ppc/spapr_pci: Do not reject VFs created after a PF

2024-10-14 Thread Shivaprasad G Bhat
On 10/12/24 5:40 PM, Akihiko Odaki wrote: On 2024/10/12 2:22, Shivaprasad G Bhat wrote: On 9/18/24 7:57 PM, Cédric Le Goater wrote: Adding :   Harsh for QEMU/PPC pseries machine,   Shivaprasad for KVM/PPC VFIO and IOMMU support. Thanks, C. On 9/13/24 05:44, Akihiko Odaki wrote: A PF may

Re: [RFC PATCH 1/4] arm: Add FEAT_XS's TLBI NXS variants

2024-10-14 Thread Richard Henderson
On 10/14/24 03:48, Manos Pitsidianakis wrote: Signed-off-by: Manos Pitsidianakis --- target/arm/cpu-features.h | 5 + target/arm/helper.c | 366 +++--- 2 files changed, 218 insertions(+), 153 deletions(-) diff --git a/target/arm/cpu-features.h

Re: [RFC PATCH 0/4] No-op support for Arm FEAT_XS, feedback needed

2024-10-14 Thread Gustavo Romero
Hi Manos, On 10/14/24 07:48, Manos Pitsidianakis wrote: This series is an initial incomplete attempt at adding support for the FEAT_XS feature in aarch64 TCG. This feature was introduced in ARMv8.7: it adds a new memory attribute XS which indicates that a memory access could take longer than usu

Re: [RFC PATCH 4/4] tests/tcg/aarch64: add system test for FEAT_XS

2024-10-14 Thread Gustavo Romero
Hi Manos, On 10/14/24 07:48, Manos Pitsidianakis wrote: Add system test to make sure FEAT_XS is enabled for max cpu emulation and that QEMU doesn't crash when encountering an NXS instruction variant. Signed-off-by: Manos Pitsidianakis --- tests/tcg/aarch64/system/feat-xs.c | 27 +

Re: What is the status of the performance of D-Bus? Should it be used?

2024-10-14 Thread Marc-André Lureau
Hi Anston On Sun, Oct 13, 2024 at 5:23 AM Anston Sorensen wrote: > > Normally, D-Bus should be used for direct input/output with QEMU (if only > local access is needed). The driver is not in a good state and needs to be > replaced though, correct? Should I still use D-Bus, or is there an > alt

Re: [PATCH v2 1/4] sscanf return values are checked to ensure correct parsing.

2024-10-14 Thread Daniel P . Berrangé
On Fri, Oct 11, 2024 at 11:19:34AM +0800, Dehan Meng wrote: > Signed-off-by: Dehan Meng > --- > qga/commands-linux.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/qga/commands-linux.c b/qga/commands-linux.c > index 51d5e3d927..2c2b5f4ff2 100644 > --- a/qga/commands-

Re: [PATCH v2 2/4] Proper initialization of n to 0 for getline to function correctly.

2024-10-14 Thread Daniel P . Berrangé
On Fri, Oct 11, 2024 at 11:19:35AM +0800, Dehan Meng wrote: > Signed-off-by: Dehan Meng > --- > qga/commands-linux.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé > > diff --git a/qga/commands-linux.c b/qga/commands-linux.c > index 2c2b5f4ff2..b905f33

Re: [PATCH v2 3/4] Avoiding freeing line prematurely. It's now only freed at the end of the function.

2024-10-14 Thread Daniel P . Berrangé
The subject line is too long - put the second sentance on a line of its own in the commit message, separated from the 1st line by a blank line. On Fri, Oct 11, 2024 at 11:19:36AM +0800, Dehan Meng wrote: > Signed-off-by: Dehan Meng > --- > qga/commands-linux.c | 6 ++ > 1 file changed, 2 ins

Re: [PATCH v2 4/4] For correcting code style: Variable declarations moved to the beginning of blocks Followed the coding style of using snake_case for variable names. And merged redundant route and ne

2024-10-14 Thread Daniel P . Berrangé
Same comment about $SUBJECT being too long. You need a blank line after the 1st line in the commit message. On Fri, Oct 11, 2024 at 11:19:37AM +0800, Dehan Meng wrote: > Signed-off-by: Dehan Meng > --- > qga/commands-linux.c | 116 --- > 1 file changed, 53

Re: [PATCH 1/1] hw/cxl/cxl-mailbox-utils: Fix for device DDR5 ECS control feature tables

2024-10-14 Thread Jonathan Cameron via
On Fri, 27 Sep 2024 10:17:43 +0100 wrote: > From: Shiju Jose > > CXL spec 3.1 section 8.2.9.9.11.2 describes the DDR5 Error Check Scrub (ECS) > control feature. > > ECS log capabilities field in following ECS tables, which is common for all > memory media FRUs in a CXL device. > > Fix struct

Re: [PATCH v1] hw/cxl: Fix background completion percentage calculation

2024-10-14 Thread Jonathan Cameron via
On Sat, 14 Sep 2024 16:50:21 +0530 wrote: > From: Ajay Joshi > > The current completion percentage calculation > does not account for the relative time since > the start of the background activity, this leads > to showing incorrect start percentage vs what has > actually been completed. > > Th

Re: [PULL v3 00/18] Rust initial PoC + meson changes for 2024-10-07

2024-10-14 Thread Peter Maydell
On Fri, 11 Oct 2024 at 18:13, Paolo Bonzini wrote: > > The following changes since commit b5ab62b3c0050612c7f9b0b4baeb44ebab42775a: > > Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging > (2024-10-04 19:28:37 +0100) > > are available in the Git repository at: > > https:

Re: [PATCH 00/17] Convert the Avocado tuxrun tests into new functional tests

2024-10-14 Thread Daniel P . Berrangé
On Mon, Oct 14, 2024 at 08:12:39AM +0200, Thomas Huth wrote: > On 13/10/2024 17.27, Alex Bennée wrote: > > Thomas Huth writes: > > > > > This patch series converts the tests/avocado/tuxrun_baselines.py > > > to the new functional test framework. While converting the sh4 test, > > > I noticed that

Re: [PATCH] configure, meson: synchronize defaults for configure and Meson Rust options

2024-10-14 Thread Peter Maydell
On Mon, 14 Oct 2024 at 12:45, Peter Maydell wrote: > > On Mon, 14 Oct 2024 at 12:01, Paolo Bonzini wrote: > > > > If the defaults for --enable-rust ($rust in configure) and Meson's rust > > option are out of sync, incremental builds will pick Meson's default. > > > > This happens because, on an i

[PATCH qemu 5/7] hw/cxl/cxl-mailbox-utils: Fix for device DDR5 ECS control feature tables

2024-10-14 Thread Jonathan Cameron via
From: Shiju Jose CXL spec 3.1 section 8.2.9.9.11.2 describes the DDR5 Error Check Scrub (ECS) control feature. ECS log capabilities field in following ECS tables, which is common for all memory media FRUs in a CXL device. Fix struct CXLMemECSReadAttrs and struct CXLMemECSWriteAttrs to make log

[PATCH qemu 4/7] hw/mem/cxl_type3: Fix More flag setting for dynamic capacity event records

2024-10-14 Thread Jonathan Cameron via
From: Fan Ni Per cxl spec r3.1, for multiple dynamic capacity event records grouped via the More flag, the last record in the sequence should clear the More flag. Before the change, the More flag of the event record is cleared before the loop of inserting records into the event log, which will l

[PATCH v4 13/13] ppc/spapr: remove deprecated machine pseries-2.12

2024-10-14 Thread Harsh Prateek Bora
Commit 0cac0f1b964 marked pseries-2.12 machines as deprecated with reasons mentioned in its commit log. Removing pseries-2.12 specific code with this patch. While at it, also remove pre-3.0-migration hacks introduced for backward compatibility which are now turned useless. Suggested-by: Cédric Le

Re: [PATCH 0/7] hw/cxl: Round up of fixes.

2024-10-14 Thread Jonathan Cameron via
On Mon, 14 Oct 2024 13:18:55 +0100 Jonathan Cameron wrote: > A mixed bag of fixes that have all been on the list already with the > exception of: > "hw/pci-bridge: Make pxb_dev_realize_common() return if it succeeded" > (so that's the one that needs more eyes). > > I've tweaked the others to fix

Re: [PATCH 4/4] hw/net/lan9118_phy: Add missing 100 mbps full duplex advertisement

2024-10-14 Thread Peter Maydell
On Sat, 5 Oct 2024 at 21:58, Bernhard Beschow wrote: > > The real device advertises this mode and the device model already advertises > 100 mbps half duplex and 10 mbps full+half duplex. So advertise this mode to > make the model more realistic. > > Signed-off-by: Bernhard Beschow > --- > hw/net

Re: [PATCH 3/4] hw/net/lan9118_phy: Reuse MII constants

2024-10-14 Thread Peter Maydell
On Sat, 5 Oct 2024 at 21:58, Bernhard Beschow wrote: > > Prefer named constants over magic values for better readability. > > Signed-off-by: Bernhard Beschow Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH] tests: update lcitool to fix freebsd py311-yaml rename

2024-10-14 Thread Peter Maydell
On Mon, 14 Oct 2024 at 14:03, Daniel P. Berrangé wrote: > > This addresses the py311-yaml -> py311-pyyaml rename in FreeBSD. > > The change to the OpenSUSE dockerfile is something that will allow > QEMU to access rust bindgen in future. That sounds like it should be in a separate patch? thanks -

Re: [PATCH] tests: update lcitool to fix freebsd py311-yaml rename

2024-10-14 Thread Daniel P . Berrangé
On Mon, Oct 14, 2024 at 02:26:28PM +0100, Peter Maydell wrote: > On Mon, 14 Oct 2024 at 14:03, Daniel P. Berrangé wrote: > > > > This addresses the py311-yaml -> py311-pyyaml rename in FreeBSD. > > > > The change to the OpenSUSE dockerfile is something that will allow > > QEMU to access rust bindg

Re: [PATCH] ppc/pnv: Add support for TPM with SPI interface

2024-10-14 Thread Stefan Berger
On 10/13/24 10:36 PM, dan tan wrote: Hi Stefan, Thank you for the review comments! Please see my response below. thank you, --- dan tan power simulation phone:+1.7373.099.138 email:dan...@linux.ibm.com On 2024-09-12 13:02, Stefan Berger wrote: On 9/12/24 12:09 PM, dan tan wrote: From: da

[PATCH v4 08/13] ppc/spapr: remove deprecated machine pseries-2.8

2024-10-14 Thread Harsh Prateek Bora
Commit 1392617d3576 intended to tag pseries-2.1 - 2.11 machines as deprecated with reasons mentioned in its commit log. Removing pseries-2.8 specific code with this patch for now. Suggested-by: Cédric Le Goater Reviewed-by: Cédric Le Goater Signed-off-by: Harsh Prateek Bora --- hw/ppc/spapr.c

[PATCH v4 02/13] ppc/spapr: remove deprecated machine pseries-2.2

2024-10-14 Thread Harsh Prateek Bora
Commit 1392617d3576 intended to tag pseries-2.1 - 2.11 machines as deprecated with reasons mentioned in its commit log. Removing pseries-2.2 specific code with this patch for now. Suggested-by: Cédric Le Goater Reviewed-by: Cédric Le Goater Signed-off-by: Harsh Prateek Bora --- include/hw/boar

Re: [PATCH 2/2] log: Suggest using -d guest_error,memaccess instead of guest_errors

2024-10-14 Thread Peter Maydell
On Sun, 6 Oct 2024 at 17:49, BALATON Zoltan wrote: > > Rename guest_errors to guest_error to match the log constant I don't think this is a good reason to change the user-facing behaviour. Also, I don't think the existing names are so bad: -d guest_errors this is plural because we are asking

Re: ALSA support in qemu-user?

2024-10-14 Thread Andrew Randrianasulu
On Mon, Oct 14, 2024 at 12:21 PM Thomas Huth wrote: > On 14/10/2024 11.06, Peter Maydell wrote: > > On Mon, 14 Oct 2024 at 02:13, Andrew Randrianasulu > > wrote: > >> > >> some 8 years ago this patch was sent to qemu-devel: > >> > >> https://lists.gnu.org/archive/html/qemu-devel/2016-06/msg0533

Re: [PATCH v2] dma: Fix function names in documentation

2024-10-14 Thread Peter Maydell
On Sat, 12 Oct 2024 at 07:50, Akihiko Odaki wrote: > > Ensure the function names match. > > Signed-off-by: Akihiko Odaki Applied to target-arm.next, thanks. -- PMM

Re: [PATCH] migration: Remove interface query-migrationthreads

2024-10-14 Thread Fabiano Rosas
Daniel P. Berrangé writes: > On Fri, Oct 11, 2024 at 11:34:17AM -0400, Peter Xu wrote: >> This reverts two commits: >> >> 671326201dac8fe91222ba0045709f04a8ec3af4 >> 1b1f4ab69c41279a45ccd0d3178e83471e6e4ec1 >> >> Meanwhile it adds an entry to removed-features.rst for the >> query-migrationthrea

Re: [PATCH 1/4] hw/net/lan9118: Extract lan9118_phy

2024-10-14 Thread Peter Maydell
On Sat, 5 Oct 2024 at 21:57, Bernhard Beschow wrote: > > A very similar implementation of the same device exists in imx_fec. Prepare > for > a common implementation by extracting the code into its own files. > > Signed-off-by: Bernhard Beschow > --- > include/hw/net/lan9118_phy.h | 31

[PULL 12/20] ui/surface: allocate shared memory on !win32

2024-10-14 Thread marcandre . lureau
From: Marc-André Lureau Use qemu_memfd_alloc() to allocate the display surface memory, which will fallback on tmpfile/mmap() on systems without memfd, and allow to share the display with other processes. This is similar to how display memory is allocated on win32 since commit 09b4c198 ("console/

[PULL 05/20] ui/dbus: fix filtering all update messages

2024-10-14 Thread marcandre . lureau
From: Marc-André Lureau Filtering pending messages when a new scanout is given shouldn't discard pending cursor changes, for example. Since filtering happens in a different thread, use atomic set/get. Fixes: fa88b85dea ("ui/dbus: filter out pending messages when scanout") Signed-off-by: Marc-A

Re: [PATCH] configure, meson: synchronize defaults for configure and Meson Rust options

2024-10-14 Thread Peter Maydell
On Mon, 14 Oct 2024 at 13:09, Peter Maydell wrote: > > On Mon, 14 Oct 2024 at 12:45, Peter Maydell wrote: > > > > On Mon, 14 Oct 2024 at 12:01, Paolo Bonzini wrote: > > > > > > If the defaults for --enable-rust ($rust in configure) and Meson's rust > > > option are out of sync, incremental build

Re: [PATCH] tests: update lcitool to fix freebsd py311-yaml rename

2024-10-14 Thread Thomas Huth
On 14/10/2024 15.02, Daniel P. Berrangé wrote: This addresses the py311-yaml -> py311-pyyaml rename in FreeBSD. The change to the OpenSUSE dockerfile is something that will allow QEMU to access rust bindgen in future. Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.d/cirrus/freebsd-14.vars

Re: [PATCH v3 1/7] chardev/char: rename `char-mux.c` to `char-mux-fe.c`

2024-10-14 Thread Marc-André Lureau
Hi Roman, On Thu, Oct 10, 2024 at 2:21 PM Roman Penyaev wrote: > In the following patches backend multiplexer will be > introduced and the implementation will be named as > follows: `char-mux-be.c`. This patch renames the > frontend multiplexer from `char-mux.c` to > `char-mux-fe.c`. > > Signed-

Re: [PATCH 6/8] chardev/mux: switch mux frontends management to bitset

2024-10-14 Thread Roman Penyaev
On Mon, Oct 14, 2024 at 3:20 PM Marc-André Lureau wrote: > > > > On Mon, Oct 14, 2024 at 3:45 PM Roman Penyaev wrote: >> >> Frontends can be attached and detached during run-time (although detach >> is not implemented, but will follow). Counter variable of muxes is not >> enough for proper attach

Re: [PATCH 7/8] chardev/mux: implement detach of frontends from mux

2024-10-14 Thread Roman Penyaev
On Mon, Oct 14, 2024 at 3:22 PM Marc-André Lureau wrote: [cut] >> >> +bool mux_chr_detach_frontend(MuxChardev *d, unsigned int tag) >> +{ >> +unsigned int bit; >> + >> +bit = find_next_bit(&d->mux_bitset, MAX_MUX, tag); >> +if (bit >= MAX_MUX) { > > > if (bit != tag) instead? Right,

Re: [PATCH] meson: check in main meson.build for native Rust compiler

2024-10-14 Thread Peter Maydell
On Mon, 14 Oct 2024 at 15:36, Paolo Bonzini wrote: > > A working native Rust compiler is always needed in order to compile Rust > code, even when cross compiling, in order to build the procedural macros > that QEMU uses. > > Right now, the check is done in rust/qemu-api-macros/meson.build, but thi

[PATCH] tests: update lcitool to fix freebsd py311-yaml rename

2024-10-14 Thread Daniel P . Berrangé
This addresses the py311-yaml -> py311-pyyaml rename in FreeBSD. The change to the OpenSUSE dockerfile is something that will allow QEMU to access rust bindgen in future. Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.d/cirrus/freebsd-14.vars | 2 +- tests/docker/dockerfiles/opensus

Re: [PATCH 7/8] chardev/mux: implement detach of frontends from mux

2024-10-14 Thread Marc-André Lureau
Hi On Mon, Oct 14, 2024 at 3:46 PM Roman Penyaev wrote: > With bitset management now it becomes feasible to implement > the logic of detaching frontends from multiplexer. > > Signed-off-by: Roman Penyaev > Cc: "Marc-André Lureau" > Cc: qemu-devel@nongnu.org > --- > chardev/char-fe.c

Re: [PATCH 0/8] chardev/mux: implement frontend detach

2024-10-14 Thread Marc-André Lureau
Hi On Mon, Oct 14, 2024 at 3:47 PM Roman Penyaev wrote: > Frontend device can be detached in run-time, which can lead to a > "Chardev 'MUX' is busy" error (see the last patch with the test case > implementation). This series implements frontend detach for the > multiplexer based on bitset, which

Re: [PATCH 2/2] tpm_emulator: Read control channel response in 2 passes

2024-10-14 Thread Stefan Berger
On 10/11/24 6:35 PM, Stefan Berger wrote: Error responses from swtpm are always only 4 bytes long. Therefore, read the entire response in 2 passes and stop if the first 4 bytes indicate an error response with no subsequent bytes readable. Read the rest in a 2nd pass, if needed. This avoids get

[PATCH] meson: check in main meson.build for native Rust compiler

2024-10-14 Thread Paolo Bonzini
A working native Rust compiler is always needed in order to compile Rust code, even when cross compiling, in order to build the procedural macros that QEMU uses. Right now, the check is done in rust/qemu-api-macros/meson.build, but this has two disadvantages. First, it makes the build fail when t

Re: [PATCH] meson: check in main meson.build for native Rust compiler

2024-10-14 Thread Peter Maydell
On Mon, 14 Oct 2024 at 15:36, Paolo Bonzini wrote: > > A working native Rust compiler is always needed in order to compile Rust > code, even when cross compiling, in order to build the procedural macros > that QEMU uses. > > Right now, the check is done in rust/qemu-api-macros/meson.build, but thi

Re: [PATCH] meson: check in main meson.build for native Rust compiler

2024-10-14 Thread Peter Maydell
On Mon, 14 Oct 2024 at 15:38, Peter Maydell wrote: > > On Mon, 14 Oct 2024 at 15:36, Paolo Bonzini wrote: > > > > A working native Rust compiler is always needed in order to compile Rust > > code, even when cross compiling, in order to build the procedural macros > > that QEMU uses. > > > > Right

Re: [RFC PATCH 0/4] No-op support for Arm FEAT_XS, feedback needed

2024-10-14 Thread Peter Maydell
On Mon, 14 Oct 2024 at 11:50, Manos Pitsidianakis wrote: > > This series is an initial incomplete attempt at adding support for the > FEAT_XS feature in aarch64 TCG. This feature was introduced in ARMv8.7: > it adds a new memory attribute XS which indicates that a memory access > could take longer

Re: [PATCH 2/2] log: Suggest using -d guest_error,memaccess instead of guest_errors

2024-10-14 Thread BALATON Zoltan
On Mon, 14 Oct 2024, Peter Maydell wrote: On Sun, 6 Oct 2024 at 17:49, BALATON Zoltan wrote: Rename guest_errors to guest_error to match the log constant I don't think this is a good reason to change the user-facing behaviour. Also, I don't think the existing names are so bad: -d guest_erro

Re: [PATCH 1/2] log: Add separate debug option for logging invalid memory accesses

2024-10-14 Thread BALATON Zoltan
On Mon, 14 Oct 2024, Peter Maydell wrote: On Sun, 6 Oct 2024 at 17:50, BALATON Zoltan wrote: Currently -d guest_errors enables logging of different invalid actions by the guest such as misusing hardware, accessing missing features or invalid memory areas. The memory access logging can be quite

Re: [PATCH 6/8] chardev/mux: switch mux frontends management to bitset

2024-10-14 Thread Marc-André Lureau
On Mon, Oct 14, 2024 at 5:58 PM Roman Penyaev wrote: > On Mon, Oct 14, 2024 at 3:20 PM Marc-André Lureau > wrote: > > > > > > > > On Mon, Oct 14, 2024 at 3:45 PM Roman Penyaev > wrote: > >> > >> Frontends can be attached and detached during run-time (although detach > >> is not implemented, but

Re: [PATCH v3 1/7] chardev/char: rename `char-mux.c` to `char-mux-fe.c`

2024-10-14 Thread Roman Penyaev
On Mon, Oct 14, 2024 at 3:57 PM Marc-André Lureau wrote: > > Hi Roman, > > On Thu, Oct 10, 2024 at 2:21 PM Roman Penyaev wrote: >> >> In the following patches backend multiplexer will be >> introduced and the implementation will be named as >> follows: `char-mux-be.c`. This patch renames the >> f

Re: [PATCH 1/2] log: Add separate debug option for logging invalid memory accesses

2024-10-14 Thread Peter Maydell
On Sun, 6 Oct 2024 at 17:50, BALATON Zoltan wrote: > > Currently -d guest_errors enables logging of different invalid actions > by the guest such as misusing hardware, accessing missing features or > invalid memory areas. The memory access logging can be quite verbose > which obscures the other me

[PATCH] ui/console-vc: Silence warning about sprintf() on OpenBSD

2024-10-14 Thread Thomas Huth
The linker on OpenBSD complains: ld: warning: console-vc.c:824 (../src/ui/console-vc.c:824)([...]): warning: sprintf() is often misused, please use snprintf() Using snprintf() is certainly better here, so let's switch to that function instead. Signed-off-by: Thomas Huth --- ui/console-vc.c |

Re: [PATCH v4 2/3] xilink-zynq-devcfg: Fix up for memory address range size not set correctly

2024-10-14 Thread Peter Maydell
On Mon, 7 Oct 2024 at 12:25, Chao Liu wrote: > > Signed-off-by: Chao Liu > --- > hw/dma/xlnx-zynq-devcfg.c | 2 +- > include/hw/dma/xlnx-zynq-devcfg.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/dma/xlnx-zynq-devcfg.c b/hw/dma/xlnx-zynq-devcfg.c > index

Re: [PATCH v4 3/3] xilink-zynq-devcfg: Avoid disabling devcfg memory region during initialization

2024-10-14 Thread Peter Maydell
On Mon, 7 Oct 2024 at 12:25, Chao Liu wrote: > > During the initialization phase, we've encountered an issue where the > UNLOCK register is inadvertently cleared. This results in devcfg MR being > disabled, which in turn leads to unexpected memory access exceptions when > attempting subsequent acc

Re: [PATCH] ui/console-vc: Silence warning about sprintf() on OpenBSD

2024-10-14 Thread Daniel P . Berrangé
On Mon, Oct 14, 2024 at 05:10:23PM +0200, Thomas Huth wrote: > The linker on OpenBSD complains: > > ld: warning: console-vc.c:824 (../src/ui/console-vc.c:824)([...]): > warning: sprintf() is often misused, please use snprintf() > > Using snprintf() is certainly better here, so let's switch to t

Re: [PULL 08/20] virtio-net: Add only one queue pair when realizing

2024-10-14 Thread Laurent Vivier
On 14/10/2024 10:30, Laurent Vivier wrote: Hi Akihiko, On 04/06/2024 09:37, Jason Wang wrote: From: Akihiko Odaki Multiqueue usage is not negotiated yet when realizing. If more than one queue is added and the guest never requests to enable multiqueue, the extra queues will not be deleted when

Re: [PATCH v3 09/20] target/hppa: Fix priority of T, D, and B page faults

2024-10-14 Thread Michael Tokarev
On 09.10.2024 03:04, Richard Henderson wrote: Drop the 'else' so that ret is overridden with the highest priority fault. Fixes: d8bc1381250 ("target/hppa: Implement PSW_X") Reviewed-by: Helge Deller Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Is this a qemu-stable m

[PATCH v7 0/5] Add Smrnmi support

2024-10-14 Thread frank . chang
From: Frank Chang This patchset added support for Smrnmi Extension in RISC-V. There are four new CSRs and one new instruction added to allow NMI to be resumable in RISC-V, which are: = * mnscratch (0x740) * mnepc (0x741) * mn

[PATCH v7 3/5] target/riscv: Add Smrnmi CSRs

2024-10-14 Thread frank . chang
From: Tommy Wu The Smrnmi extension adds the 'mnscratch', 'mnepc', 'mncause', 'mnstatus' CSRs. Signed-off-by: Frank Chang Signed-off-by: Tommy Wu Reviewed-by: Alistair Francis --- target/riscv/cpu.c | 5 +++ target/riscv/cpu.h | 4 ++ target/riscv/cpu_bits.h | 11 ++ target/r

[PATCH v7 4/5] target/riscv: Add Smrnmi mnret instruction

2024-10-14 Thread frank . chang
From: Tommy Wu This patch adds a new instruction 'mnret'. 'mnret' is an M-mode-only instruction that uses the values in `mnepc` and `mnstatus` to return to the program counter, privilege mode, and virtualization mode of the interrupted context. Signed-off-by: Frank Chang Signed-off-by: Tommy Wu

[PATCH v7 2/5] target/riscv: Handle Smrnmi interrupt and exception

2024-10-14 Thread frank . chang
From: Tommy Wu Because the RNMI interrupt trap handler address is implementation defined. We add the 'rnmi-interrupt-vector' and 'rnmi-exception-vector' as the property of the harts. It’s very easy for users to set the address based on their expectation. This patch also adds the functionality to

[PATCH v7 1/5] target/riscv: Add 'ext_smrnmi' in the RISCVCPUConfig

2024-10-14 Thread frank . chang
From: Tommy Wu The boolean variable 'ext_smrnmi' is used to determine whether the Smrnmi extension exists. Signed-off-by: Frank Chang Signed-off-by: Tommy Wu Reviewed-by: Alistair Francis --- target/riscv/cpu_cfg.h | 1 + 1 file changed, 1 insertion(+) diff --git a/target/riscv/cpu_cfg.h b/

[PATCH v7 5/5] target/riscv: Add Smrnmi cpu extension

2024-10-14 Thread frank . chang
From: Tommy Wu This adds the properties for ISA extension Smrnmi. Signed-off-by: Frank Chang Signed-off-by: Tommy Wu --- target/riscv/cpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index b3195da512..fed64741d1 100644 --- a/target/riscv/cpu.

[PATCH] hw/net: Changing log error to trace message

2024-10-14 Thread Roque Arcudia Hernandez
From: Nabih Estefan Converting error to trace message to avoid spamming of message when there is nothing to transmit. Signed-off-by: Nabih Estefan Signed-off-by: Roque Arcudia Hernandez --- hw/net/npcm_gmac.c | 5 ++--- hw/net/trace-events | 1 + 2 files changed, 3 insertions(+), 3 deletions

Re: [PATCH 1/4] hw/net/lan9118: Extract lan9118_phy

2024-10-14 Thread Bernhard Beschow
Am 14. Oktober 2024 12:47:52 UTC schrieb Peter Maydell : >On Sat, 5 Oct 2024 at 21:57, Bernhard Beschow wrote: >> >> A very similar implementation of the same device exists in imx_fec. Prepare >> for >> a common implementation by extracting the code into its own files. >> >> Signed-off-by: Be

[PATCH qemu 7/7] hw/pci-bridge: Make pxb_dev_realize_common() return if it succeeded

2024-10-14 Thread Jonathan Cameron via
For the CXL PXB there is additional code after pxb_dev_realize_common() is called. If that realize failed (e.g. due to an out of range numa_node) we will get a segfault. Return a bool so the caller can check if the pxb_dev_realize_common() succeeded or not without having to poke around in the err

[PATCH qemu 6/7] hw/cxl: Fix indent of structure member

2024-10-14 Thread Jonathan Cameron via
Add missing 4 spaces of indent to structure element. Reported-by: Davidlohr Bueso Signed-off-by: Jonathan Cameron --- hw/cxl/cxl-mailbox-utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/cxl/cxl-mailbox-utils.c b/hw/cxl/cxl-mailbox-utils.c index 67041f45d3..5f630997

[PATCH v4 06/13] ppc/spapr: remove deprecated machine pseries-2.6

2024-10-14 Thread Harsh Prateek Bora
Commit 1392617d3576 intended to tag pseries-2.1 - 2.11 machines as deprecated with reasons mentioned in its commit log. Removing pseries-2.6 specific code with this patch for now. Suggested-by: Cédric Le Goater Reviewed-by: Cédric Le Goater Signed-off-by: Harsh Prateek Bora --- hw/ppc/spapr.c

[PATCH v4 07/13] ppc/spapr: remove deprecated machine pseries-2.7

2024-10-14 Thread Harsh Prateek Bora
Commit 1392617d3576 intended to tag pseries-2.1 - 2.11 machines as deprecated with reasons mentioned in its commit log. Removing pseries-2.7 specific code with this patch for now. While at it, also remove pre-2.8-migration and pci/mmio hacks introduced for backward compatibility. Suggested-by: Cé

[PATCH v4 12/13] ppc/spapr: remove deprecated machine pseries-2.12-sxxm

2024-10-14 Thread Harsh Prateek Bora
Commit 0cac0f1b964 marked pseries-2.12 machines as deprecated with reasons mentioned in its commit log. Removing pseries-2.12-sxxm specific code with this patch. Suggested-by: Cédric Le Goater Signed-off-by: Harsh Prateek Bora --- hw/ppc/spapr.c | 14 -- 1 file changed, 14 deletions

Re: Re: [PATCH] hw/char/riscv_htif: Fix htif_mm_write that causes infinite loop in ACT.

2024-10-14 Thread 阎明铸
Thank you for your reply and I'm sorry that I didn't explain it clearly. - ACT is an official riscv test suite to check the riscv support of the DUT(device under test). - Currently ACT support using [sail-riscv](https://github.com/riscv/sail-riscv)(default) or [spike](https://github.com/riscv-s

Re: [Qemu-devel] Assigning network devices to nested VMs results in driver errors in nested VMs

2024-10-14 Thread ryan.l...@qq.com
Hi Jintack, I run into the same issue as you described in https://lists.nongnu.org/archive/html/qemu-devel/2018-02/msg03876.html I try to pass through MLNX VF and NVME to level2-vm, but both these two pci device can display with lspci correctly, but have issue with driver. My env are: Host L

Re: [PATCH 6/8] chardev/mux: switch mux frontends management to bitset

2024-10-14 Thread Marc-André Lureau
On Mon, Oct 14, 2024 at 3:45 PM Roman Penyaev wrote: > Frontends can be attached and detached during run-time (although detach > is not implemented, but will follow). Counter variable of muxes is not > enough for proper attach/detach management, so this patch implements > bitset: if bit is set fo

[PATCH v4 03/13] ppc/spapr: remove deprecated machine pseries-2.3

2024-10-14 Thread Harsh Prateek Bora
Commit 1392617d3576 intended to tag pseries-2.1 - 2.11 machines as deprecated with reasons mentioned in its commit log. Removing pseries-2.3 specific code with this patch for now. While at it, also remove the dynamic-reconfiguration option which was introduced to disable it by default for legacy m

[PATCH v4 00/13] ppc/spapr: remove deprecated machines specific code

2024-10-14 Thread Harsh Prateek Bora
As per Qemu's deprecation policy [1], and the legacy pseries machines being marked as deprecated in earlier commits, this patchset aims at removing the respective code for machines which are now deprecated. [1] https://www.qemu.org/docs/master/about/deprecated.html v4: Removed hw_compat_2_{1,2,3}

[PATCH v4 05/13] ppc/spapr: remove deprecated machine pseries-2.5

2024-10-14 Thread Harsh Prateek Bora
Commit 1392617d3576 intended to tag pseries-2.1 - 2.11 machines as deprecated with reasons mentioned in its commit log. Removing pseries-2.5 specific code with this patch for now. Also drop sPAPRMachineClass::use_ohci_by_default which is now useless. Suggested-by: Cédric Le Goater Reviewed-by: C

[PATCH v4 09/13] ppc/spapr: remove deprecated machine pseries-2.9

2024-10-14 Thread Harsh Prateek Bora
Commit 1392617d3576 intended to tag pseries-2.1 - 2.11 machines as deprecated with reasons mentioned in its commit log. Removing pseries-2.9 specific code with this patch for now. While at it, also remove the pre-2.10 migration hacks which now become obsolete. Suggested-by: Cédric Le Goater Revi

[PATCH v4 01/13] ppc/spapr: remove deprecated machine pseries-2.1

2024-10-14 Thread Harsh Prateek Bora
Commit 1392617d3576 intended to tag pseries-2.1 - 2.11 machines as deprecated with reasons mentioned in its commit log. Removing pseries-2.1 specific code with this patch for now. Suggested-by: Cédric Le Goater Reviewed-by: Cédric Le Goater Signed-off-by: Harsh Prateek Bora --- include/hw/boar

[PATCH v4 04/13] ppc/spapr: remove deprecated machine pseries-2.4

2024-10-14 Thread Harsh Prateek Bora
Commit 1392617d3576 intended to tag pseries-2.1 - 2.11 machines as deprecated with reasons mentioned in its commit log. Removing pseries-2.4 specific code with this patch for now. While at it, also remove SpaprMachineClass::dr_lmb_enabled which is now turned useless. Suggested-by: Cédric Le Goate

[PATCH v4 11/13] ppc/spapr: remove deprecated machine pseries-2.11

2024-10-14 Thread Harsh Prateek Bora
Commit 1392617d3576 intended to tag pseries-2.1 - 2.11 machines as deprecated with reasons mentioned in its commit log. Removing pseries-2.11 specific code with this patch. Suggested-by: Cédric Le Goater Reviewed-by: Cédric Le Goater Signed-off-by: Harsh Prateek Bora --- hw/ppc/spapr.c | 15 --

[PATCH v4 10/13] ppc/spapr: remove deprecated machine pseries-2.10

2024-10-14 Thread Harsh Prateek Bora
Commit 1392617d3576 intended to tag pseries-2.1 - 2.11 machines as deprecated with reasons mentioned in its commit log. Removing pseries-2.10 specific code with this patch for now. Suggested-by: Cédric Le Goater Reviewed-by: Cédric Le Goater Signed-off-by: Harsh Prateek Bora --- hw/ppc/spapr.c

[PULL 09/20] ui/pixman: generalize shared_image_destroy

2024-10-14 Thread marcandre . lureau
From: Marc-André Lureau Learn to free memfd-allocated shared memory. Signed-off-by: Marc-André Lureau Reviewed-by: Akihiko Odaki Message-ID: <20241008125028.1177932-10-marcandre.lur...@redhat.com> --- include/ui/qemu-pixman.h | 2 +- hw/display/virtio-gpu.c | 4 ++-- ui/console.c

[PULL 00/20] UI patches

2024-10-14 Thread marcandre . lureau
From: Marc-André Lureau The following changes since commit 3860a2a8de56fad71db42f4ad120eb7eff03b51f: Merge tag 'pull-tcg-20241013' of https://gitlab.com/rth7680/qemu into staging (2024-10-14 11:12:34 +0100) are available in the Git repository at: https://gitlab.com/marcandre.lureau/qemu.g

[PULL 02/20] hw/audio/hda: fix memory leak on audio setup

2024-10-14 Thread marcandre . lureau
From: Marc-André Lureau When SET_STREAM_FORMAT is called, we should clear the existing setup. Factor out common function to close a stream. Direct leak of 144 byte(s) in 3 object(s) allocated from: #0 0x7f91d38f7350 in calloc (/lib64/libasan.so.8+0xf7350) (BuildId: a4ad7eb954b390cf00f07fa1

[PULL 08/20] util/memfd: report potential errors on free

2024-10-14 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Akihiko Odaki Message-ID: <20241008125028.1177932-9-marcandre.lur...@redhat.com> --- util/memfd.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/util/memfd.c b/util/memfd.c index 4a3c07e0be..8a2

[PULL 07/20] ui/dbus: discard pending CursorDefine on new one

2024-10-14 Thread marcandre . lureau
From: Marc-André Lureau Similar to scanout updates, let's discard pending cursor changes. Signed-off-by: Marc-André Lureau Reviewed-by: Akihiko Odaki Message-ID: <20241008125028.1177932-8-marcandre.lur...@redhat.com> --- ui/dbus-listener.c | 28 1 file changed, 28

[PULL 01/20] hw/audio/hda: free timer on exit

2024-10-14 Thread marcandre . lureau
From: Marc-André Lureau Fixes: 280c1e1cd ("audio/hda: create millisecond timers that handle IO") Signed-off-by: Marc-André Lureau Reviewed-by: Akihiko Odaki Message-ID: <20241008125028.1177932-2-marcandre.lur...@redhat.com> --- hw/audio/hda-codec.c | 2 +- 1 file changed, 1 insertion(+), 1 de

[PULL 16/20] ui/dbus: implement Unix.Map

2024-10-14 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Akihiko Odaki Message-ID: <20241008125028.1177932-17-marcandre.lur...@redhat.com> --- ui/dbus-listener.c | 78 +++--- 1 file changed, 73 insertions(+), 5 deletions(-) diff --git a/ui/

<    1   2   3   >