On 7/15/2025 5:25 PM, Mark Cave-Ayland wrote:
> Use QOM casts to convert between VFIOPCIDevice and PCIDevice instead of
> accessing pdev directly.
>
> Signed-off-by: Mark Cave-Ayland
> ---
> hw/vfio/igd.c | 38 +-
> 1 file changed,
From: Steve Sistare
Use qom-list-get to speed up the qom-tree command.
Signed-off-by: Steve Sistare
Acked-by: Markus Armbruster
Message-ID: <1752248703-217318-3-git-send-email-steven.sist...@oracle.com>
Tested-by: Markus Armbruster
[Lint picked off to mollify make check-minreqs]
Sign
From: Steve Sistare
Add a unit test for qom-list-get.
Signed-off-by: Steve Sistare
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Markus Armbruster
Message-ID: <1752248703-217318-4-git-send-email-steven.sist...@oracle.com>
Signed-off-by: Markus Armbruster
---
tests/qtest/qom-test.c
From: Steve Sistare
Using qom-list and qom-get to get all the nodes and property values in
a QOM tree can take multiple seconds because it requires 1000's of
individual QOM requests. Some managers fetch the entire tree or a
large subset of it when starting a new VM, and this cost
27;s old/bad code, I don't want
> python-qemu-qmp faulting like this.
Reproducer for Fedora 41, current master c079d3a31e4:
Run
$ qemu-system-x86_64 -S -display none -chardev
socket,id=mon1,path=test-qmp,server=on,wait=off -mon
mode=control,id=qmp,chardev=mon1
and
$ scripts/qmp/qom-tree -s test-qmp >/dev/null
Questions?
On 7/15/25 14:55, Mark Cave-Ayland wrote:
Use QOM casts to convert between VFIOContainer and VFIOContainerBase instead
of accessing bcontainer directly.
Signed-off-by: Mark Cave-Ayland
Reviewed-by: Harsh Prateek Bora
---
hw/vfio/spapr.c | 16 ++--
1 file changed, 6
On 7/15/25 14:55, Mark Cave-Ayland wrote:
Use a QOM cast to convert to VFIOContainer instead of accessing bcontainer
directly.
Signed-off-by: Mark Cave-Ayland
Reviewed-by: Harsh Prateek Bora
---
hw/ppc/spapr_pci_vfio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Knowing the QOM type name of a CPU can be useful,
in particular to infer its model name.
Reviewed-by: Richard Henderson
Reviewed-by: Zhao Liu
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Xiaoyao Li
Message-Id: <20250715090624.52377-2-phi...@linaro.org>
---
qapi/machin
From: Fiona Ebner
Signed-off-by: Fiona Ebner
Message-ID: <20250605100938.43133-1-f.eb...@proxmox.com>
[kwolf: Fixed up pylint warnings flagged by 297]
Reviewed-by: Kevin Wolf
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/tests/qom-set-drive | 75 ++
test
On Fri, Jul 11, 2025, 10:47 AM Markus Armbruster wrote:
> Steve Sistare writes:
>
> > Use qom-list-get to speed up the qom-tree command.
> >
> > Signed-off-by: Steve Sistare
>
> Quick test... Differences in output before and after match expectations
> (se
On 7/15/25 11:25, Mark Cave-Ayland wrote:
This series attempts to improve use of QOM within the vfio subsystem which
appears to have been added at a later date. It's mostly mechanical changes
that do the following:
1) Format the QOM structs per our coding guidelines
2) Ensure the p
On 7/15/25 5:26 AM, Mark Cave-Ayland wrote:
> Use QOM casts to cast to VFIOPCIDevice instead of using container_of().
>
> Signed-off-by: Mark Cave-Ayland
> ---
> hw/s390x/s390-pci-vfio.c | 14 +++---
> 1 file changed, 7 insertions(+), 7 deletions(-)
Reviewed-by: Matthew Rosato
On Tue, Jul 15, 2025 at 10:26:00AM +0100, Mark Cave-Ayland wrote:
> Use QOM casts to convert between VFIOPCIDevice and PCIDevice instead of
> accessing pdev directly.
>
> Signed-off-by: Mark Cave-Ayland
> ---
> hw/vfio-user/pci.c | 6 +++---
> 1 file changed, 3 inser
On Tue, Jul 15, 2025 at 10:25:49AM +0100, Mark Cave-Ayland wrote:
> Use QOM casts to convert between VFIOUserContainer and VFIOContainerBase
> instead
> of accessing bcontainer directly.
>
> Signed-off-by: Mark Cave-Ayland
Patch subject should be "vfio-user/container.c&q
On Tue, 2025-07-15 at 10:26 +0100, Mark Cave-Ayland wrote:
> Use QOM casts to cast to VFIOPCIDevice instead of using container_of().
>
> Signed-off-by: Mark Cave-Ayland
> ---
> hw/s390x/s390-pci-vfio.c | 14 +++---
> 1 file changed, 7 insertions(+), 7 deletions(-)
On Tue, Jul 15, 2025 at 10:25:52AM +0100, Mark Cave-Ayland wrote:
> Use QOM casts to convert between VFIOUserPCIDevice and VFIOPCIDevice instead
> of accessing device directly.
>
> Signed-off-by: Mark Cave-Ayland
> ---
> hw/vfio-user/pci.c | 7 ---
> 1 file change
On Tue, 15 Jul 2025, Mark Cave-Ayland wrote:
Use QOM casts to convert between VFIOPCIDevice and PCIDevice instead of
accessing pdev directly.
Signed-off-by: Mark Cave-Ayland
---
hw/vfio/pci.c | 202 ++
1 file changed, 120 insertions(+), 82
On 7/15/2025 5:25 AM, Mark Cave-Ayland wrote:
Use QOM casts to convert between VFIOPCIDevice and PCIDevice instead of
accessing pdev directly.
Signed-off-by: Mark Cave-Ayland
Reviewed-by: Steve Sistare
On 7/15/2025 5:25 AM, Mark Cave-Ayland wrote:
Use QOM casts to convert between VFIOContainer and VFIOContainerBase instead
of accessing bcontainer directly.
Signed-off-by: Mark Cave-Ayland
Reviewed-by: Steve Sistare
Use QOM casts to convert between VFIOContainer and VFIOContainerBase instead
of accessing bcontainer directly.
Signed-off-by: Mark Cave-Ayland
---
hw/vfio/container.c | 31 +--
1 file changed, 13 insertions(+), 18 deletions(-)
diff --git a/hw/vfio/container.c b/hw
Use QOM casts to convert between VFIOPCIDevice and PCIDevice instead of
accessing pdev directly.
Signed-off-by: Mark Cave-Ayland
---
hw/vfio/pci.c | 202 ++
1 file changed, 120 insertions(+), 82 deletions(-)
diff --git a/hw/vfio/pci.c b/hw/vfio
Use QOM casts to convert between VFIOPCIDevice and PCIDevice instead of
accessing pdev directly.
Signed-off-by: Mark Cave-Ayland
---
hw/vfio/pci.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/vfio/pci.h b/hw/vfio/pci.h
index 16f092a0c6..c0c3d68742 100644
--- a/hw/vfio
Use QOM casts to convert between VFIOPCIDevice and PCIDevice instead of
accessing pdev directly.
Signed-off-by: Mark Cave-Ayland
---
hw/vfio/cpr.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/vfio/cpr.c b/hw/vfio/cpr.c
index af0f12a7ad..3e3f4035ab 100644
--- a/hw
Use QOM casts to convert between VFIOPCIDevice and PCIDevice instead of
accessing pdev directly.
Signed-off-by: Mark Cave-Ayland
---
hw/vfio/pci-quirks.c | 48 ++--
1 file changed, 29 insertions(+), 19 deletions(-)
diff --git a/hw/vfio/pci-quirks.c b/hw
Use QOM casts to convert between VFIOUserPCIDevice and VFIOPCIDevice instead
of accessing device directly.
Signed-off-by: Mark Cave-Ayland
---
hw/vfio-user/pci.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/hw/vfio-user/pci.c b/hw/vfio-user/pci.c
index da6fe51809
Use QOM casts to convert between VFIOPCIDevice and PCIDevice instead of
accessing pdev directly.
Signed-off-by: Mark Cave-Ayland
---
hw/vfio-user/pci.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/vfio-user/pci.c b/hw/vfio-user/pci.c
index 9380766548..25a1dc0529
Use QOM casts to convert between VFIOPCIDevice and PCIDevice instead of
accessing pdev directly.
Signed-off-by: Mark Cave-Ayland
---
hw/vfio/igd.c | 38 +-
1 file changed, 21 insertions(+), 17 deletions(-)
diff --git a/hw/vfio/igd.c b/hw/vfio/igd.c
index
Use QOM casts to cast to VFIOPCIDevice instead of using container_of().
Signed-off-by: Mark Cave-Ayland
---
hw/s390x/s390-pci-vfio.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/hw/s390x/s390-pci-vfio.c b/hw/s390x/s390-pci-vfio.c
index aaf91319b4
Use QOM casts to convert between VFIOContainer and VFIOContainerBase instead
of accessing bcontainer directly.
Signed-off-by: Mark Cave-Ayland
---
hw/vfio/spapr.c | 16 ++--
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/hw/vfio/spapr.c b/hw/vfio/spapr.c
index
On 7/15/2025 5:06 PM, Philippe Mathieu-Daudé wrote:
Knowing the QOM type name of a CPU can be useful,
in particular to infer its model name.
Reviewed-by: Richard Henderson
Reviewed-by: Zhao Liu
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Xiaoyao Li
---
qapi/machine.json
Use QOM casts to convert between VFIOUserContainer and VFIOContainerBase instead
of accessing bcontainer directly.
Signed-off-by: Mark Cave-Ayland
---
hw/vfio-user/container.c | 26 +++---
1 file changed, 11 insertions(+), 15 deletions(-)
diff --git a/hw/vfio-user
This series attempts to improve use of QOM within the vfio subsystem which
appears to have been added at a later date. It's mostly mechanical changes
that do the following:
1) Format the QOM structs per our coding guidelines
2) Ensure the parent object is called parent_obj
3) Us
Use a QOM cast to convert to VFIOContainer instead of accessing bcontainer
directly.
Signed-off-by: Mark Cave-Ayland
---
hw/ppc/spapr_pci_vfio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ppc/spapr_pci_vfio.c b/hw/ppc/spapr_pci_vfio.c
index e318d0d912..7e1c71ef59
Use QOM casts to convert between VFIOContainer and VFIOContainerBase instead
of accessing bcontainer directly.
Signed-off-by: Mark Cave-Ayland
---
hw/vfio/cpr-legacy.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/hw/vfio/cpr-legacy.c b/hw/vfio/cpr-legacy.c
Knowing the QOM type name of a CPU can be useful,
in particular to infer its model name.
Reviewed-by: Richard Henderson
Reviewed-by: Zhao Liu
Signed-off-by: Philippe Mathieu-Daudé
---
qapi/machine.json | 3 +++
hw/core/machine-qmp-cmds.c | 1 +
2 files changed, 4 insertions(+)
diff
Am 05.06.2025 um 12:09 hat Fiona Ebner geschrieben:
> Signed-off-by: Fiona Ebner
Thanks, applied to the block branch.
Kevin
From: Steve Sistare
Use qom-list-get to speed up the qom-tree command.
Signed-off-by: Steve Sistare
Acked-by: Markus Armbruster
Message-ID: <1752248703-217318-3-git-send-email-steven.sist...@oracle.com>
Tested-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
python/qemu
From: Steve Sistare
Using qom-list and qom-get to get all the nodes and property values in
a QOM tree can take multiple seconds because it requires 1000's of
individual QOM requests. Some managers fetch the entire tree or a
large subset of it when starting a new VM, and this cost
From: Steve Sistare
Add a unit test for qom-list-get.
Signed-off-by: Steve Sistare
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Markus Armbruster
Message-ID: <1752248703-217318-4-git-send-email-steven.sist...@oracle.com>
Signed-off-by: Markus Armbruster
---
tests/qtest/qom-test.c
--- a/qapi/qom.json
+++ b/qapi/qom.json
@@ -52,7 +52,7 @@
#
# List properties of a object given a path in the object model.
#
-# @path: the path within the object model. See @qom-get for a
+# @path: the path within the object model. See `qom-get` for a
# description of this parameter.
#
# R
Steve Sistare writes:
> Using qom-list and qom-get to get all the nodes and property values in a
> QOM tree can take multiple seconds because it requires 1000's of individual
> QOM requests. Some managers fetch the entire tree or a large subset
> of it when starting a new VM, a
On 7/11/2025 12:50 PM, Markus Armbruster wrote:
Steven Sistare writes:
On 7/11/2025 10:47 AM, Markus Armbruster wrote:
Steve Sistare writes:
Use qom-list-get to speed up the qom-tree command.
Signed-off-by: Steve Sistare
Quick test... Differences in output before and after match
Steven Sistare writes:
> On 7/11/2025 10:47 AM, Markus Armbruster wrote:
>> Steve Sistare writes:
>>
>>> Use qom-list-get to speed up the qom-tree command.
>>>
>>> Signed-off-by: Steve Sistare
>>
>> Quick test... Differences in outpu
On 7/11/2025 11:06 AM, Markus Armbruster wrote:
This feels ready. Have a look at my (few) comments, and tell me what
you think. Happy to apply finishing touches in my tree, without another
respin.
Thanks your your patience!
I'll send V5 with the final changes.
Thank you for your time Markus
Use qom-list-get to speed up the qom-tree command.
Signed-off-by: Steve Sistare
Acked-by: Markus Armbruster
---
python/qemu/utils/qom.py| 43 +++--
python/qemu/utils/qom_common.py | 53 +
2 files changed, 78 insertions
Using qom-list and qom-get to get all the nodes and property values in a
QOM tree can take multiple seconds because it requires 1000's of individual
QOM requests. Some managers fetch the entire tree or a large subset
of it when starting a new VM, and this cost is a substantial fraction of
Using qom-list and qom-get to get all the nodes and property values in
a QOM tree can take multiple seconds because it requires 1000's of
individual QOM requests. Some managers fetch the entire tree or a
large subset of it when starting a new VM, and this cost is a
substantial fraction of
Add a unit test for qom-list-get.
Signed-off-by: Steve Sistare
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Markus Armbruster
---
tests/qtest/qom-test.c | 116 -
1 file changed, 115 insertions(+), 1 deletion(-)
diff --git a/tests/qtest/qom
On 7/11/2025 10:47 AM, Markus Armbruster wrote:
Steve Sistare writes:
Use qom-list-get to speed up the qom-tree command.
Signed-off-by: Steve Sistare
Quick test... Differences in output before and after match expectations
(see appended diff).
New version:
real0m0.446s
On 7/11/2025 11:02 AM, Markus Armbruster wrote:
Steve Sistare writes:
Add a unit test for qom-list-getv.
qom-list-get here and in subject. Could scratch this line, subject
suffices.
Doh, I missed it. Will fix.
(re)names are hard :)
Signed-off-by: Steve Sistare
Reviewed-by: Philippe
On 7/11/2025 10:35 AM, Markus Armbruster wrote:
Steve Sistare writes:
Define the qom-list-get command, which fetches all the properties and
values for a list of paths. This is faster than qom-list plus qom-get,
especially when fetching a large subset of the QOM tree. Some managers
do so
This feels ready. Have a look at my (few) comments, and tell me what
you think. Happy to apply finishing touches in my tree, without another
respin.
Thanks your your patience!
Steve Sistare writes:
> Use qom-list-get to speed up the qom-tree command.
>
> Signed-off-by: Steve Sistare
Quick test... Differences in output before and after match expectations
(see appended diff).
New version:
real0m0.446s
user0m0.062s
sys 0m0.017s
Ol
Steve Sistare writes:
> Add a unit test for qom-list-getv.
qom-list-get here and in subject. Could scratch this line, subject
suffices.
>
> Signed-off-by: Steve Sistare
> Reviewed-by: Philippe Mathieu-Daudé
> ---
> tests/qtes
Steve Sistare writes:
> Define the qom-list-get command, which fetches all the properties and
> values for a list of paths. This is faster than qom-list plus qom-get,
> especially when fetching a large subset of the QOM tree. Some managers
> do so when starting a new VM, and this c
model.
#
-# @path: the path within the object model. See @qom-get for a
+# @path: the path within the object model. See `qom-get` for a
# description of this parameter.
#
# Returns: a list that describe the properties of the object.
@@ -129,12 +129,12 @@
#
# This command will set a property
Use qom-list-get to speed up the qom-tree command.
Signed-off-by: Steve Sistare
---
python/qemu/utils/qom.py| 43 +++--
python/qemu/utils/qom_common.py | 53 +
2 files changed, 78 insertions(+), 18 deletions(-)
diff
Add a unit test for qom-list-getv.
Signed-off-by: Steve Sistare
Reviewed-by: Philippe Mathieu-Daudé
---
tests/qtest/qom-test.c | 116 -
1 file changed, 115 insertions(+), 1 deletion(-)
diff --git a/tests/qtest/qom-test.c b/tests/qtest/qom-test.c
Using qom-list and qom-get to get all the nodes and property values in a
QOM tree can take multiple seconds because it requires 1000's of individual
QOM requests. Some managers fetch the entire tree or a large subset
of it when starting a new VM, and this cost is a substantial fraction of
Define the qom-list-get command, which fetches all the properties and
values for a list of paths. This is faster than qom-list plus qom-get,
especially when fetching a large subset of the QOM tree. Some managers
do so when starting a new VM, and this cost can be a substantial fraction
of start
On 7/10/2025 4:54 AM, Markus Armbruster wrote:
Steven Sistare writes:
On 7/8/2025 6:02 PM, Philippe Mathieu-Daudé wrote:
Hi Steve,
On 8/7/25 19:24, Steve Sistare wrote:
Add a unit test for qom-list-getv.
Signed-off-by: Steve Sistare
---
tests/qtest/qom-test.c | 64
Steven Sistare writes:
> On 7/8/2025 6:02 PM, Philippe Mathieu-Daudé wrote:
>> Hi Steve,
>> On 8/7/25 19:24, Steve Sistare wrote:
>>> Add a unit test for qom-list-getv.
>>>
>>> Signed-off-by: Steve Sistare
On 8/7/25 23:54, Philippe Mathieu-Daudé wrote:
On 8/7/25 19:24, Steve Sistare wrote:
Define the qom-list-getv command, which fetches all the properties and
values for a list of paths. This is faster than qom-tree-get when
fetching a subset of the QOM tree. See qom.json for details.
Signed
On 9/7/25 17:17, Steven Sistare wrote:
On 7/8/2025 6:02 PM, Philippe Mathieu-Daudé wrote:
Hi Steve,
On 8/7/25 19:24, Steve Sistare wrote:
Add a unit test for qom-list-getv.
Signed-off-by: Steve Sistare
---
tests/qtest/qom-test.c | 64
On 7/9/2025 4:39 AM, Markus Armbruster wrote:
Steve Sistare writes:
Define the qom-list-getv command, which fetches all the properties and
values for a list of paths. This is faster than qom-tree-get when
fetching a subset of the QOM tree. See qom.json for details.
Signed-off-by: Steve
On 7/8/2025 6:02 PM, Philippe Mathieu-Daudé wrote:
Hi Steve,
On 8/7/25 19:24, Steve Sistare wrote:
Add a unit test for qom-list-getv.
Signed-off-by: Steve Sistare
---
tests/qtest/qom-test.c | 64 ++
1 file changed, 64 insertions(+)
diff
On Mon, Jul 07, 2025 at 07:20:04PM +0200, Philippe Mathieu-Daudé wrote:
> Date: Mon, 7 Jul 2025 19:20:04 +0200
> From: Philippe Mathieu-Daudé
> Subject: [PATCH-for-10.1 v6 10/14] hw/core/null-machine: Define machine as
> generic QOM type
> X-Mailer: git-send-email 2.
Steve Sistare writes:
> Define the qom-list-getv command, which fetches all the properties and
> values for a list of paths. This is faster than qom-tree-get when
> fetching a subset of the QOM tree. See qom.json for details.
>
> Signed-off-by: Steve Sistare
You cover lette
Philippe Mathieu-Daudé writes:
> Hi Steve,
>
> On 8/7/25 19:24, Steve Sistare wrote:
>> Add a unit test for qom-list-getv.
>> Signed-off-by: Steve Sistare
>> ---
>> tests/qtest/qom-test.c | 64
>> ++
>&g
Hi Steve,
On 8/7/25 19:24, Steve Sistare wrote:
Add a unit test for qom-list-getv.
Signed-off-by: Steve Sistare
---
tests/qtest/qom-test.c | 64 ++
1 file changed, 64 insertions(+)
diff --git a/tests/qtest/qom-test.c b/tests/qtest/qom-test.c
On 8/7/25 19:24, Steve Sistare wrote:
Define the qom-list-getv command, which fetches all the properties and
values for a list of paths. This is faster than qom-tree-get when
fetching a subset of the QOM tree. See qom.json for details.
Signed-off-by: Steve Sistare
---
qapi/qom.json
On 12/5/25 15:47, Steve Sistare wrote:
Add a unit test for qom-tree-get
Signed-off-by: Steve Sistare
---
tests/qtest/qom-test.c | 49 +
1 file changed, 49 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé
Steven Sistare writes:
> On 7/4/2025 8:22 AM, Markus Armbruster wrote:
>> Steve Sistare writes:
>>
>>> Define the qom-tree-get QAPI command, which fetches an entire tree of
>>> properties and values with a single QAPI call. This is much faster
>>>
Steven Sistare writes:
> On 7/4/2025 8:22 AM, Markus Armbruster wrote:
>> Steve Sistare writes:
>>
>>> Define the qom-list-getv command, which fetches all the properties and
>>> values for a list of paths. This is faster than qom-tree-get when
>>&g
On 12/5/25 15:47, Steve Sistare wrote:
Define the qom-tree-get QAPI command, which fetches an entire tree of
properties and values with a single QAPI call. This is much faster
than using qom-list plus qom-get for every node and property of the
tree. See qom.json for details.
Signed-off-by
On 7/8/2025 3:14 AM, Philippe Mathieu-Daudé wrote:
On 12/5/25 15:47, Steve Sistare wrote:
Define the qom-tree-get QAPI command, which fetches an entire tree of
properties and values with a single QAPI call. This is much faster
than using qom-list plus qom-get for every node and property of the
Using qom-list and qom-get to get all the nodes and property values in a
QOM tree can take multiple seconds because it requires 1000's of individual
QOM requests. Some managers fetch the entire tree or a large subset
of it when starting a new VM, and this cost is a substantial fraction of
Add a unit test for qom-list-getv.
Signed-off-by: Steve Sistare
---
tests/qtest/qom-test.c | 64 ++
1 file changed, 64 insertions(+)
diff --git a/tests/qtest/qom-test.c b/tests/qtest/qom-test.c
index 27d70bc..4defff1 100644
--- a/tests/qtest/qom
Markus Armbruster writes:
> Steven Sistare writes:
>
>> On 7/4/2025 8:22 AM, Markus Armbruster wrote:
>>> Steve Sistare writes:
>>>
>>>> Define the qom-tree-get QAPI command, which fetches an entire tree of
>>>> properties and values w
Define the qom-list-getv command, which fetches all the properties and
values for a list of paths. This is faster than qom-tree-get when
fetching a subset of the QOM tree. See qom.json for details.
Signed-off-by: Steve Sistare
---
qapi/qom.json | 50
On 8/7/25 13:50, Steven Sistare wrote:
On 7/8/2025 3:14 AM, Philippe Mathieu-Daudé wrote:
On 12/5/25 15:47, Steve Sistare wrote:
Define the qom-tree-get QAPI command, which fetches an entire tree of
properties and values with a single QAPI call. This is much faster
than using qom-list plus
Use qom-list-getv to speed up the qom-tree command.
Signed-off-by: Steve Sistare
---
python/qemu/utils/qom.py| 43 +++--
python/qemu/utils/qom_common.py | 53 +
2 files changed, 78 insertions(+), 18 deletions(-)
diff
Steve Sistare writes:
> Add a unit test for qom-list-getv.
>
> Signed-off-by: Steve Sistare
Reviewed-by: Fabiano Rosas
On 7/7/25 11:20, Philippe Mathieu-Daudé wrote:
While DEFINE_MACHINE() is a succinct macro, it doesn't
allow registering QOM interfaces to the defined machine.
Convert to the generic DEFINE_TYPES() in preparation to
register interfaces.
Signed-off-by: Philippe Mathieu-Daudé
Review
Define the TYPE_TARGET_ARM_MACHINE and TYPE_TARGET_AARCH64_MACHINE
QOM interface names to allow machines to implement them.
Register these interfaces in common code in target_info-qom.c used
by all binaries because QOM interfaces must be registered before
being checked (see next commit with the
While DEFINE_MACHINE() is a succinct macro, it doesn't
allow registering QOM interfaces to the defined machine.
Convert to the generic DEFINE_TYPES() in preparation to
register interfaces.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Pierrick Bouvier
---
hw/core/null-machine.c
Il gio 3 lug 2025, 06:51 Paolo Bonzini ha scritto:
>
>
> Il mer 2 lug 2025, 23:36 Xiaoyao Li ha scritto:
>
>> The reason why accelerator's instance_init() was moved to post_init, was
>> just it needs to consider other factors. Please see commit 4db4385a7ab6
>> ("i386: run accel_cpu_instance_init
On 7/4/2025 8:26 AM, Markus Armbruster wrote:
Steve Sistare writes:
Using qom-list and qom-get to get all the nodes and property values in a
QOM tree can take multiple seconds because it requires 1000's of individual
QOM requests. Some managers fetch the entire tree or a large subset
On 7/4/2025 8:22 AM, Markus Armbruster wrote:
Steve Sistare writes:
Define the qom-tree-get QAPI command, which fetches an entire tree of
properties and values with a single QAPI call. This is much faster
than using qom-list plus qom-get for every node and property of the
tree. See qom.json
On 7/4/2025 8:22 AM, Markus Armbruster wrote:
Steve Sistare writes:
Define the qom-list-getv command, which fetches all the properties and
values for a list of paths. This is faster than qom-tree-get when
fetching a subset of the QOM tree. See qom.json for details.
Signed-off-by: Steve
On 7/4/2025 8:33 AM, Markus Armbruster wrote:
Steve,
My sincere apologies for the long, long delay.
It wasn't just for the usual reasons. It was also because I had a vague
feeling of unease about qom-tree, and had trouble figuring out why.
I'll try do your work justice before the
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Message-Id: <20250606164418.98655-8-phi...@linaro.org>
---
accel/hvf/hvf-all.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/accel/hvf/hvf-all.c b/accel/hvf/hvf-all.c
index 9e4012e2d10..df95ba74d6e 1006
Steve,
My sincere apologies for the long, long delay.
It wasn't just for the usual reasons. It was also because I had a vague
feeling of unease about qom-tree, and had trouble figuring out why.
I'll try do your work justice before the window for 10.1 closes.
QOM maintainers, ple
Steve Sistare writes:
> Using qom-list and qom-get to get all the nodes and property values in a
> QOM tree can take multiple seconds because it requires 1000's of individual
> QOM requests. Some managers fetch the entire tree or a large subset
> of it when starting a new VM, a
Steve Sistare writes:
> Define the qom-list-getv command, which fetches all the properties and
> values for a list of paths. This is faster than qom-tree-get when
> fetching a subset of the QOM tree. See qom.json for details.
>
> Signed-off-by: Steve Sistare
> ---
> qa
Steve Sistare writes:
> Define the qom-tree-get QAPI command, which fetches an entire tree of
> properties and values with a single QAPI call. This is much faster
> than using qom-list plus qom-get for every node and property of the
> tree. See qom.json for details.
>
> Si
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
---
accel/hvf/hvf-accel-ops.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/accel/hvf/hvf-accel-ops.c b/accel/hvf/hvf-accel-ops.c
index 6af849450e1..c256cdceffb 100644
--- a/accel/hvf/hvf-accel-ops.c
++
Il mer 2 lug 2025, 23:36 Xiaoyao Li ha scritto:
> The reason why accelerator's instance_init() was moved to post_init, was
> just it needs to consider other factors. Please see commit 4db4385a7ab6
> ("i386: run accel_cpu_instance_init as post_init")
>
You're right and this can be a problem with
On 7/3/2025 11:08 AM, Zhao Liu wrote:
On Thu, Jul 03, 2025 at 09:03:10AM +0800, Xiaoyao Li wrote:
Date: Thu, 3 Jul 2025 09:03:10 +0800
From: Xiaoyao Li
Subject: Re: [Regression] Re: [PULL 35/35] qom: reverse order of
instance_post_init calls
On 7/3/2025 2:54 AM, Paolo Bonzini wrote:
Il mer
On Thu, Jul 03, 2025 at 09:03:10AM +0800, Xiaoyao Li wrote:
> Date: Thu, 3 Jul 2025 09:03:10 +0800
> From: Xiaoyao Li
> Subject: Re: [Regression] Re: [PULL 35/35] qom: reverse order of
> instance_post_init calls
>
> On 7/3/2025 2:54 AM, Paolo Bonzini wrote:
> > Il mer 2
1 - 100 of 7751 matches
Mail list logo
