Steven Sistare <steven.sist...@oracle.com> writes:

> On 7/11/2025 10:47 AM, Markus Armbruster wrote:
>> Steve Sistare <steven.sist...@oracle.com> writes:
>> 
>>> Use qom-list-get to speed up the qom-tree command.
>>>
>>> Signed-off-by: Steve Sistare <steven.sist...@oracle.com>
>> 
>> Quick test...  Differences in output before and after match expectations
>> (see appended diff).
>> 
>> New version:
>> 
>>      real    0m0.446s
>>      user    0m0.062s
>>      sys     0m0.017s
>> 
>> Old version barfs a stack backtrace (appended), and is ~18x slower:
>> 
>>      real    0m8.176s
>>      user    0m0.395s
>>      sys     0m0.126s
>> 
>> Did you see the stack backtrace, too?
>> 
>> Regardless
>> Acked-by: Markus Armbruster <arm...@redhat.com>
>
> Thanks.  Do you want a tested-by credit, or is that too little testing
> for you to stand behind that endorsement?

Tested-by: Markus Armbruster <arm...@redhat.com>

> I observe the same expected differences.
>
> My test did not backtrace.  Must be a different VM.

Let's not worry about it.

[...]


Reply via email to