Re: [RFC] cpus: avoid get stuck in pause_all_vcpus

2020-03-13 Thread Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
On 2020/3/13 17:22, Paolo Bonzini wrote: > On 13/03/20 09:36, Longpeng (Mike, Cloud Infrastructure Service Product > Dept.) wrote: >>> You're right, do_vm_stop sets the runstate after pause_all_vcpus. We >>> can move that before and it should fix your case too. >>> >> Uh, it seems to work. So c

Re: [RFC] cpus: avoid get stuck in pause_all_vcpus

2020-03-13 Thread Paolo Bonzini
On 13/03/20 09:36, Longpeng (Mike, Cloud Infrastructure Service Product Dept.) wrote: >> You're right, do_vm_stop sets the runstate after pause_all_vcpus. We >> can move that before and it should fix your case too. >> > Uh, it seems to work. So can I send a patch based on your suggestion ? Or feel

Re: [RFC] cpus: avoid get stuck in pause_all_vcpus

2020-03-13 Thread Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
On 2020/3/13 15:09, Paolo Bonzini wrote: > On 13/03/20 02:43, Longpeng (Mike, Cloud Infrastructure Service Product > Dept.) wrote: >>> diff --git a/cpus.c b/cpus.c >>> index b4f8b84b61..1eb7533a91 100644 >>> --- a/cpus.c >>> +++ b/cpus.c >>> @@ -1899,6 +1899,10 @@ void resume_all_vcpus(void) >>>

Re: [RFC] cpus: avoid get stuck in pause_all_vcpus

2020-03-13 Thread Paolo Bonzini
On 13/03/20 02:43, Longpeng (Mike, Cloud Infrastructure Service Product Dept.) wrote: >> diff --git a/cpus.c b/cpus.c >> index b4f8b84b61..1eb7533a91 100644 >> --- a/cpus.c >> +++ b/cpus.c >> @@ -1899,6 +1899,10 @@ void resume_all_vcpus(void) >> { >> CPUState *cpu; >> >> +if (!runstate_is

Re: [RFC] cpus: avoid get stuck in pause_all_vcpus

2020-03-12 Thread Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
On 2020/3/12 23:28, Paolo Bonzini wrote: > On 10/03/20 10:14, Longpeng(Mike) wrote: >> From: Longpeng >> >> We find an issue when repeat reboot in guest during migration, it cause the >> migration thread never be waken up again. >> >> | >>

Re: [RFC] cpus: avoid get stuck in pause_all_vcpus

2020-03-12 Thread Paolo Bonzini
On 10/03/20 10:14, Longpeng(Mike) wrote: > From: Longpeng > > We find an issue when repeat reboot in guest during migration, it cause the > migration thread never be waken up again. > > | >| > LOCK BQL | > ...

Re: [RFC] cpus: avoid get stuck in pause_all_vcpus

2020-03-10 Thread Longpeng (Mike)
在 2020/3/10 18:20, no-re...@patchew.org 写道: > Patchew URL: > https://patchew.org/QEMU/20200310091443.1326-1-longpe...@huawei.com/ > > > > Hi, > > This series failed the asan build test. Please find the testing commands and > their output below. If you have Docker installed, you can probably re

Re: [RFC] cpus: avoid get stuck in pause_all_vcpus

2020-03-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200310091443.1326-1-longpe...@huawei.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash exp

[RFC] cpus: avoid get stuck in pause_all_vcpus

2020-03-10 Thread Longpeng(Mike)
From: Longpeng We find an issue when repeat reboot in guest during migration, it cause the migration thread never be waken up again. | | LOCK BQL | ...| main_loop_should_exit