Re: [RFC] cpus: avoid get stuck in pause_all_vcpus

[Longpeng (Mike, Cloud Infrastructure Service Product Dept.)]

On 2020/3/13 15:09, Paolo Bonzini wrote:
> On 13/03/20 02:43, Longpeng (Mike, Cloud Infrastructure Service Product
> Dept.) wrote:
>>> diff --git a/cpus.c b/cpus.c
>>> index b4f8b84b61..1eb7533a91 100644
>>> --- a/cpus.c
>>> +++ b/cpus.c
>>> @@ -1899,6 +1899,10 @@ void resume_all_vcpus(void)
>>>  {
>>>      CPUState *cpu;
>>>
>>> +    if (!runstate_is_running()) {
>>> +        return;
>>> +    }
>>> +
>> Hi Paolo,
>>
>> The runstate of my above sketch is running, so maybe your patch can fix some
>> other issues but not mine ?
> 
> You're right, do_vm_stop sets the runstate after pause_all_vcpus.  We
> can move that before and it should fix your case too.
> 
Uh, it seems to work. So can I send a patch based on your suggestion ? Or feel
free to do if you want to fix it by yourself.

> Paolo
> 
> 
---
Regards,
Longpeng(Mike)