Re: [Qemu-devel] bad error message in drive-mirror

2014-08-27 Thread Stefan Hajnoczi
On Mon, Aug 25, 2014 at 05:26:31PM -0600, Eric Blake wrote: > I just noticed today that passing "granularity":1 to QMP drive-mirror > results in this confusing error message: > > Invalid parameter 'drive-virtio-disk0' > > because the code mistakenly did > error_set(errp, QERR_INVALID_PARA

[Qemu-devel] bad error message in drive-mirror

2014-08-25 Thread Eric Blake
I just noticed today that passing "granularity":1 to QMP drive-mirror results in this confusing error message: Invalid parameter 'drive-virtio-disk0' because the code mistakenly did error_set(errp, QERR_INVALID_PARAMETER, device); instead of the correct error_set(errp, QERR_INVALI