On Mon, Aug 25, 2014 at 05:26:31PM -0600, Eric Blake wrote: > I just noticed today that passing "granularity":1 to QMP drive-mirror > results in this confusing error message: > > Invalid parameter 'drive-virtio-disk0' > > because the code mistakenly did > error_set(errp, QERR_INVALID_PARAMETER, device); > instead of the correct > error_set(errp, QERR_INVALID_PARAMETER, "granularity"); > > I ran out of time to patch it today, and at any rate, whoever writes the > patch should probably audit for other bad uses of > error_set(QERR_INVALID_PARAMETER).
I have sent a patch to fix this. Thanks for reporting it. Stefan
pgpt8huFjYu3J.pgp
Description: PGP signature
