Re: [Qemu-devel] [RFC 1/6] Add bpf support to qemu

2018-09-03 Thread Daniel P . Berrangé
On Mon, Sep 03, 2018 at 01:24:16PM +0100, Peter Maydell wrote: > On 3 September 2018 at 12:59, Daniel P. Berrangé wrote: > > >> ## > >> +# check for usable bpf system call > >> +if test "$bpf" = "yes"; then > > > > if test "x$bpf" != "xno"; then > > We do

Re: [Qemu-devel] [RFC 1/6] Add bpf support to qemu

2018-09-03 Thread Sameeh Jubran
On Mon, Sep 3, 2018 at 3:24 PM, Peter Maydell wrote: > On 3 September 2018 at 12:59, Daniel P. Berrangé wrote: > >>> ## >>> +# check for usable bpf system call >>> +if test "$bpf" = "yes"; then >> >> if test "x$bpf" != "xno"; then > > We don't use the lead

Re: [Qemu-devel] [RFC 1/6] Add bpf support to qemu

2018-09-03 Thread Peter Maydell
On 3 September 2018 at 12:59, Daniel P. Berrangé wrote: >> ## >> +# check for usable bpf system call >> +if test "$bpf" = "yes"; then > > if test "x$bpf" != "xno"; then We don't use the leading-x thingy elsewhere in configure, why is this condition specia

Re: [Qemu-devel] [RFC 1/6] Add bpf support to qemu

2018-09-03 Thread Sameeh Jubran
On Mon, Sep 3, 2018 at 2:59 PM, Daniel P. Berrangé wrote: > On Thu, Aug 30, 2018 at 05:27:03PM +0300, Sameeh Jubran wrote: >> From: Sameeh Jubran >> >> This commit adds the bpf header provided by Linux to Qemu. > > s/Qemu/QEMU/ > >> >> Signed-off-by: Sameeh Jubran >> --- >> MAINTAINERS

Re: [Qemu-devel] [RFC 1/6] Add bpf support to qemu

2018-09-03 Thread Daniel P . Berrangé
On Thu, Aug 30, 2018 at 05:27:03PM +0300, Sameeh Jubran wrote: > From: Sameeh Jubran > > This commit adds the bpf header provided by Linux to Qemu. s/Qemu/QEMU/ > > Signed-off-by: Sameeh Jubran > --- > MAINTAINERS | 5 + > configure | 44 >

[Qemu-devel] [RFC 1/6] Add bpf support to qemu

2018-08-30 Thread Sameeh Jubran
From: Sameeh Jubran This commit adds the bpf header provided by Linux to Qemu. Signed-off-by: Sameeh Jubran --- MAINTAINERS | 5 + configure | 44 + scripts/update-linux-headers.sh | 8 ++-- 3 files cha