On Mon, Sep 3, 2018 at 3:24 PM, Peter Maydell <peter.mayd...@linaro.org> wrote: > On 3 September 2018 at 12:59, Daniel P. Berrangé <berra...@redhat.com> wrote: > >>> ########################################## >>> +# check for usable bpf system call >>> +if test "$bpf" = "yes"; then >> >> if test "x$bpf" != "xno"; then > > We don't use the leading-x thingy elsewhere in configure, > why is this condition special? > (We can assume we don't have a broken shell, and we > know that $bpf won't be a string starting with a hyphen.) That's what Daniel suggested and I though it should be good for the reasons above. You have good points as well. Both approaches are okay with me :) > > thanks > -- PMM
-- Respectfully, Sameeh Jubran Linkedin Software Engineer @ Daynix.
