Re: [Qemu-devel] [Qemu-ppc] [PATCH V2] Fix float64_to_uint64

2013-10-17 Thread Tom Musta
> On 10/17/2013 11:31 AM, Stefan Weil wrote: Am 17.10.2013 11:40, schrieb Alexander Graf: Missing a SoB line. Alex There is already a mix of coding styles in fpu/softfloat.c, and your patch adds large regions of new code. Therefore I expect that such contributions should respect the QEMU codi

Re: [Qemu-devel] [Qemu-ppc] [PATCH V2] Fix float64_to_uint64

2013-10-17 Thread Stefan Weil
Am 17.10.2013 11:40, schrieb Alexander Graf: > On 16.10.2013, at 23:10, Tom Musta wrote: > >> The comment preceding the float64_to_uint64 routine suggests that >> the implementation is broken. And this is, indeed, the case. >> >> This patch properly implements the conversion of a 64-bit floating

Re: [Qemu-devel] [Qemu-ppc] [PATCH V2] Fix float64_to_uint64

2013-10-17 Thread Alexander Graf
On 16.10.2013, at 23:10, Tom Musta wrote: > The comment preceding the float64_to_uint64 routine suggests that > the implementation is broken. And this is, indeed, the case. > > This patch properly implements the conversion of a 64-bit floating > point number to an unsigned, 64 bit integer. >