Am 17.10.2013 11:40, schrieb Alexander Graf: > On 16.10.2013, at 23:10, Tom Musta <tommu...@gmail.com> wrote: > >> The comment preceding the float64_to_uint64 routine suggests that >> the implementation is broken. And this is, indeed, the case. >> >> This patch properly implements the conversion of a 64-bit floating >> point number to an unsigned, 64 bit integer. >> >> Note that the patch does not pass scripts/checkpatch.pl because it >> maintains the coding style of fpu/softfloat.c. >> >> V2: This contribution can be licensed under either the softfloat-2a or -2b >> license. > Missing a SoB line. > > > Alex
There is already a mix of coding styles in fpu/softfloat.c, and your patch adds large regions of new code. Therefore I expect that such contributions should respect the QEMU coding style. The situation is different if only single lines in some function are replaced or added. Stefan
