Re: [Qemu-devel] [PATCH v4 2/8] block: add basic backup support to block driver

2013-05-22 Thread Kevin Wolf
Am 22.05.2013 um 15:58 hat Stefan Hajnoczi geschrieben: > On Wed, May 22, 2013 at 11:56:45AM +0200, Kevin Wolf wrote: > > Am 22.05.2013 um 11:54 hat Paolo Bonzini geschrieben: > > > Il 22/05/2013 11:38, Kevin Wolf ha scritto: > > > >> + > > > >> +DPRINTF("brdv_co_backup_cow done C%" PRId64

Re: [Qemu-devel] [PATCH v4 2/8] block: add basic backup support to block driver

2013-05-22 Thread Stefan Hajnoczi
On Wed, May 22, 2013 at 11:56:45AM +0200, Kevin Wolf wrote: > Am 22.05.2013 um 11:54 hat Paolo Bonzini geschrieben: > > Il 22/05/2013 11:38, Kevin Wolf ha scritto: > > >> + > > >> +DPRINTF("brdv_co_backup_cow done C%" PRId64 "\n", start); > > >> +} > > >> + > > >> +out: > > >> +if (

Re: [Qemu-devel] [PATCH v4 2/8] block: add basic backup support to block driver

2013-05-22 Thread Kevin Wolf
Am 22.05.2013 um 11:54 hat Paolo Bonzini geschrieben: > Il 22/05/2013 11:38, Kevin Wolf ha scritto: > >> + > >> +DPRINTF("brdv_co_backup_cow done C%" PRId64 "\n", start); > >> +} > >> + > >> +out: > >> +if (bounce_buffer) { > >> +qemu_vfree(bounce_buffer); > >> +} > >> +

Re: [Qemu-devel] [PATCH v4 2/8] block: add basic backup support to block driver

2013-05-22 Thread Paolo Bonzini
Il 22/05/2013 11:38, Kevin Wolf ha scritto: >> + >> +DPRINTF("brdv_co_backup_cow done C%" PRId64 "\n", start); >> +} >> + >> +out: >> +if (bounce_buffer) { >> +qemu_vfree(bounce_buffer); >> +} >> + >> +cow_request_end(&cow_request); >> + >> +qemu_co_rwlock_unlock

Re: [Qemu-devel] [PATCH v4 2/8] block: add basic backup support to block driver

2013-05-22 Thread Kevin Wolf
Am 16.05.2013 um 10:36 hat Stefan Hajnoczi geschrieben: > From: Dietmar Maurer > > backup_start() creates a block job that copies a point-in-time snapshot > of a block device to a target block device. > > We call backup_do_cow() for each write during backup. That function > reads the original da

[Qemu-devel] [PATCH v4 2/8] block: add basic backup support to block driver

2013-05-16 Thread Stefan Hajnoczi
From: Dietmar Maurer backup_start() creates a block job that copies a point-in-time snapshot of a block device to a target block device. We call backup_do_cow() for each write during backup. That function reads the original data from the block device before it gets overwritten. The data is then