Il 22/05/2013 11:38, Kevin Wolf ha scritto:
>> +
>> + DPRINTF("brdv_co_backup_cow done C%" PRId64 "\n", start);
>> + }
>> +
>> +out:
>> + if (bounce_buffer) {
>> + qemu_vfree(bounce_buffer);
>> + }
>> +
>> + cow_request_end(&cow_request);
>> +
>> + qemu_co_rwlock_unlock(&job->flush_rwlock);
>> +
>> + return ret;
>> +}
>> +
>> +static void coroutine_fn backup_before_write_notify(Notifier *notifier,
>> + void *opaque)
>> +{
>> + BdrvTrackedRequest *req = opaque;
>> + backup_do_cow(req->bs, req->sector_num, req->nb_sectors);
>> +}
>
> I don't think you can ignore errors here. Not sure if we can stop the VM
> and resume later or something like that, but if we can't, the backup
> will be invalid and we must fail the job.
Yes, there is rerror/werror machinery for jobs that this patch is not using.
Paolo
