Re: [Qemu-devel] [PATCH v4 05/28] qapi: Add new visit_free() function

2016-06-03 Thread Markus Armbruster
Markus Armbruster writes: > Eric Blake writes: [...] >> diff --git a/qapi/qapi-dealloc-visitor.c b/qapi/qapi-dealloc-visitor.c >> index 9391dea..235e8a1 100644 >> --- a/qapi/qapi-dealloc-visitor.c >> +++ b/qapi/qapi-dealloc-visitor.c >> @@ -107,17 +107,12 @@ static void qapi_dealloc_type_null(Vi

Re: [Qemu-devel] [PATCH v4 05/28] qapi: Add new visit_free() function

2016-06-01 Thread Markus Armbruster
Eric Blake writes: > Making each visitor provide its own (awkwardly-named) FOO_cleanup() > is unusual, when we can instead have a polymorphic visit_free() > interface. > > The dealloc visitor is the first one converted to completely use > the new entry point, since only generated code and the tes

[Qemu-devel] [PATCH v4 05/28] qapi: Add new visit_free() function

2016-05-18 Thread Eric Blake
Making each visitor provide its own (awkwardly-named) FOO_cleanup() is unusual, when we can instead have a polymorphic visit_free() interface. The dealloc visitor is the first one converted to completely use the new entry point, since only generated code and the testsuite were using it. Diffs to