Markus Armbruster <[email protected]> writes:
> Eric Blake <[email protected]> writes:
[...]
>> diff --git a/qapi/qapi-dealloc-visitor.c b/qapi/qapi-dealloc-visitor.c
>> index 9391dea..235e8a1 100644
>> --- a/qapi/qapi-dealloc-visitor.c
>> +++ b/qapi/qapi-dealloc-visitor.c
>> @@ -107,17 +107,12 @@ static void qapi_dealloc_type_null(Visitor *v, const
>> char *name, Error **errp)
>> {
>> }
>>
>> -Visitor *qapi_dealloc_get_visitor(QapiDeallocVisitor *v)
>> -{
>> - return &v->visitor;
>> -}
>> -
>> -void qapi_dealloc_visitor_cleanup(QapiDeallocVisitor *v)
>> +static void qapi_dealloc_free(Visitor *v)
>> {
>> g_free(v);
>
> Uh, shouldn't this be g_free(v, QapiDeallocVisitor, visitor)? That way,
> we don't assume that visitor is QapiDeallocVisitor's first member.
I mean g_free(container_of(v, QapiDeallocVisitor, visitor), of course.
>
>> }
>>
>> -QapiDeallocVisitor *qapi_dealloc_visitor_new(void)
>> +Visitor *qapi_dealloc_visitor_new(void)
>> {
>> QapiDeallocVisitor *v;
>>
[...]
