Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends

2015-04-30 Thread Christian Borntraeger
Am 29.04.2015 um 22:19 schrieb Michael S. Tsirkin: [...] >> >> This commit made it work. >> >> commit 7a11370e5e6c26566904bb7f08281093a3002ff2 >> Author: Michael S. Tsirkin >> Date: Wed Oct 15 10:22:30 2014 +1030 >> >> virtio_blk: enable VQs early >> >> virtio spec requires drivers

Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends

2015-04-29 Thread Michael S. Tsirkin
On Wed, Apr 29, 2015 at 09:49:53PM +0200, Christian Borntraeger wrote: > Am 29.04.2015 um 20:35 schrieb Michael S. Tsirkin: > > On Wed, Apr 29, 2015 at 04:43:19PM +0200, Christian Borntraeger wrote: > >> Am 29.04.2015 um 12:32 schrieb Michael S. Tsirkin: > >>> On Wed, Apr 29, 2015 at 10:52:15AM +02

Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends

2015-04-29 Thread Christian Borntraeger
Am 29.04.2015 um 20:35 schrieb Michael S. Tsirkin: > On Wed, Apr 29, 2015 at 04:43:19PM +0200, Christian Borntraeger wrote: >> Am 29.04.2015 um 12:32 schrieb Michael S. Tsirkin: >>> On Wed, Apr 29, 2015 at 10:52:15AM +0200, Cornelia Huck wrote: On Wed, 29 Apr 2015 10:17:55 +0200 Christian

Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends

2015-04-29 Thread Michael S. Tsirkin
On Wed, Apr 29, 2015 at 04:43:19PM +0200, Christian Borntraeger wrote: > Am 29.04.2015 um 12:32 schrieb Michael S. Tsirkin: > > On Wed, Apr 29, 2015 at 10:52:15AM +0200, Cornelia Huck wrote: > >> On Wed, 29 Apr 2015 10:17:55 +0200 > >> Christian Borntraeger wrote: > >> > >>> Am 28.04.2015 um 20:32

Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends

2015-04-29 Thread Michael S. Tsirkin
On Wed, Apr 29, 2015 at 04:33:44PM +0200, Cornelia Huck wrote: > On Wed, 29 Apr 2015 12:32:04 +0200 > "Michael S. Tsirkin" wrote: > > > On Wed, Apr 29, 2015 at 10:52:15AM +0200, Cornelia Huck wrote: > > > > And (surprise, surprise) virtio-blk now works - but it also works when > > > I back out t

Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends

2015-04-29 Thread Christian Borntraeger
Am 29.04.2015 um 12:32 schrieb Michael S. Tsirkin: > On Wed, Apr 29, 2015 at 10:52:15AM +0200, Cornelia Huck wrote: >> On Wed, 29 Apr 2015 10:17:55 +0200 >> Christian Borntraeger wrote: >> >>> Am 28.04.2015 um 20:32 schrieb Michael S. Tsirkin: On Tue, Apr 28, 2015 at 08:14:44PM +0200, Michael

Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends

2015-04-29 Thread Cornelia Huck
On Wed, 29 Apr 2015 12:32:04 +0200 "Michael S. Tsirkin" wrote: > On Wed, Apr 29, 2015 at 10:52:15AM +0200, Cornelia Huck wrote: > > And (surprise, surprise) virtio-blk now works - but it also works when > > I back out the atomic.h change again. No barrier problems :) > > > > Good news is that w

Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends

2015-04-29 Thread Michael S. Tsirkin
On Wed, Apr 29, 2015 at 10:52:15AM +0200, Cornelia Huck wrote: > On Wed, 29 Apr 2015 10:17:55 +0200 > Christian Borntraeger wrote: > > > Am 28.04.2015 um 20:32 schrieb Michael S. Tsirkin: > > > On Tue, Apr 28, 2015 at 08:14:44PM +0200, Michael S. Tsirkin wrote: > > >> On Tue, Apr 28, 2015 at 04:3

Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends

2015-04-29 Thread Shannon Zhao
On 2015/4/28 21:16, Peter Maydell wrote: > On 28 April 2015 at 14:13, Michael S. Tsirkin wrote: >> > The patches look correct to me too, but I want s390 >> > cleaned up so it does not include COMMON_FEATURES >> > in 100 places, and I prefer merging it all together. > It seems a bit harsh to ask

Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends

2015-04-29 Thread Cornelia Huck
On Wed, 29 Apr 2015 10:17:55 +0200 Christian Borntraeger wrote: > Am 28.04.2015 um 20:32 schrieb Michael S. Tsirkin: > > On Tue, Apr 28, 2015 at 08:14:44PM +0200, Michael S. Tsirkin wrote: > >> On Tue, Apr 28, 2015 at 04:35:16PM +0200, Michael S. Tsirkin wrote: > >>> On Tue, Apr 28, 2015 at 03:24

Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends

2015-04-29 Thread Christian Borntraeger
Am 28.04.2015 um 20:32 schrieb Michael S. Tsirkin: > On Tue, Apr 28, 2015 at 08:14:44PM +0200, Michael S. Tsirkin wrote: >> On Tue, Apr 28, 2015 at 04:35:16PM +0200, Michael S. Tsirkin wrote: >>> On Tue, Apr 28, 2015 at 03:24:19PM +0200, Cornelia Huck wrote: On Tue, 28 Apr 2015 14:16:40 +0100

Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends

2015-04-28 Thread Michael S. Tsirkin
On Tue, Apr 28, 2015 at 07:34:29PM +0100, Peter Maydell wrote: > On 28 April 2015 at 19:14, Michael S. Tsirkin wrote: > > On Tue, Apr 28, 2015 at 04:35:16PM +0200, Michael S. Tsirkin wrote: > >> On Tue, Apr 28, 2015 at 03:24:19PM +0200, Cornelia Huck wrote: > >> > Yep, see my other reply... I'm no

Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends

2015-04-28 Thread Michael S. Tsirkin
On Tue, Apr 28, 2015 at 08:32:51PM +0200, Michael S. Tsirkin wrote: > On Tue, Apr 28, 2015 at 08:14:44PM +0200, Michael S. Tsirkin wrote: > > On Tue, Apr 28, 2015 at 04:35:16PM +0200, Michael S. Tsirkin wrote: > > > On Tue, Apr 28, 2015 at 03:24:19PM +0200, Cornelia Huck wrote: > > > > On Tue, 28 A

Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends

2015-04-28 Thread Peter Maydell
On 28 April 2015 at 19:14, Michael S. Tsirkin wrote: > On Tue, Apr 28, 2015 at 04:35:16PM +0200, Michael S. Tsirkin wrote: >> On Tue, Apr 28, 2015 at 03:24:19PM +0200, Cornelia Huck wrote: >> > Yep, see my other reply... I'm not quite sure what's wrong with >> > event_idx on virtio-blk for s390-vi

Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends

2015-04-28 Thread Michael S. Tsirkin
On Tue, Apr 28, 2015 at 08:14:44PM +0200, Michael S. Tsirkin wrote: > On Tue, Apr 28, 2015 at 04:35:16PM +0200, Michael S. Tsirkin wrote: > > On Tue, Apr 28, 2015 at 03:24:19PM +0200, Cornelia Huck wrote: > > > On Tue, 28 Apr 2015 14:16:40 +0100 > > > Peter Maydell wrote: > > > > > > > On 28 Apri

Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends

2015-04-28 Thread Michael S. Tsirkin
On Tue, Apr 28, 2015 at 04:35:16PM +0200, Michael S. Tsirkin wrote: > On Tue, Apr 28, 2015 at 03:24:19PM +0200, Cornelia Huck wrote: > > On Tue, 28 Apr 2015 14:16:40 +0100 > > Peter Maydell wrote: > > > > > On 28 April 2015 at 14:13, Michael S. Tsirkin wrote: > > > > The patches look correct to

Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends

2015-04-28 Thread Michael S. Tsirkin
On Tue, Apr 28, 2015 at 03:24:19PM +0200, Cornelia Huck wrote: > On Tue, 28 Apr 2015 14:16:40 +0100 > Peter Maydell wrote: > > > On 28 April 2015 at 14:13, Michael S. Tsirkin wrote: > > > The patches look correct to me too, but I want s390 > > > cleaned up so it does not include COMMON_FEATURES

Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends

2015-04-28 Thread Michael S. Tsirkin
On Tue, Apr 28, 2015 at 03:20:54PM +0200, Cornelia Huck wrote: > On Tue, 28 Apr 2015 15:05:47 +0200 > "Michael S. Tsirkin" wrote: > > > On Tue, Apr 28, 2015 at 01:52:40PM +0100, Peter Maydell wrote: > > > On 28 April 2015 at 13:48, Michael S. Tsirkin wrote: > > > > On Tue, Apr 28, 2015 at 07:51:

Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends

2015-04-28 Thread Cornelia Huck
On Tue, 28 Apr 2015 14:16:40 +0100 Peter Maydell wrote: > On 28 April 2015 at 14:13, Michael S. Tsirkin wrote: > > The patches look correct to me too, but I want s390 > > cleaned up so it does not include COMMON_FEATURES > > in 100 places, and I prefer merging it all together. > > It seems a bi

Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends

2015-04-28 Thread Cornelia Huck
On Tue, 28 Apr 2015 15:05:47 +0200 "Michael S. Tsirkin" wrote: > On Tue, Apr 28, 2015 at 01:52:40PM +0100, Peter Maydell wrote: > > On 28 April 2015 at 13:48, Michael S. Tsirkin wrote: > > > On Tue, Apr 28, 2015 at 07:51:11PM +0800, shannon.z...@linaro.org wrote: > > >> From: Shannon Zhao > > >

Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends

2015-04-28 Thread Peter Maydell
On 28 April 2015 at 14:13, Michael S. Tsirkin wrote: > The patches look correct to me too, but I want s390 > cleaned up so it does not include COMMON_FEATURES > in 100 places, and I prefer merging it all together. It seems a bit harsh to ask Shannon to do s390 cleanup when he doesn't have any acc

Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends

2015-04-28 Thread Michael S. Tsirkin
On Tue, Apr 28, 2015 at 02:06:35PM +0100, Peter Maydell wrote: > On 28 April 2015 at 12:51, wrote: > > From: Shannon Zhao > > > > The reason to do this is that the virtio-net-device can't expose host > > features to guest while using virtio-mmio. So the performance is low. > > > > The virtio-*-p

Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends

2015-04-28 Thread Peter Maydell
On 28 April 2015 at 12:51, wrote: > From: Shannon Zhao > > The reason to do this is that the virtio-net-device can't expose host > features to guest while using virtio-mmio. So the performance is low. > > The virtio-*-pci, virtio-*-s390, and virtio-*-ccw already have the > ability to forward pro

Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends

2015-04-28 Thread Michael S. Tsirkin
On Tue, Apr 28, 2015 at 01:52:40PM +0100, Peter Maydell wrote: > On 28 April 2015 at 13:48, Michael S. Tsirkin wrote: > > On Tue, Apr 28, 2015 at 07:51:11PM +0800, shannon.z...@linaro.org wrote: > >> From: Shannon Zhao > >> Here we move the host features to backends, involving > >> DEFINE_VIRTIO_

Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends

2015-04-28 Thread Peter Maydell
On 28 April 2015 at 13:48, Michael S. Tsirkin wrote: > On Tue, Apr 28, 2015 at 07:51:11PM +0800, shannon.z...@linaro.org wrote: >> From: Shannon Zhao >> Here we move the host features to backends, involving >> DEFINE_VIRTIO_NET_FEATURES, DEFINE_VIRTIO_SCSI_FEATURES. So the >> virtio-mmio devices

Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends

2015-04-28 Thread Michael S. Tsirkin
On Tue, Apr 28, 2015 at 07:51:11PM +0800, shannon.z...@linaro.org wrote: > From: Shannon Zhao > > The reason to do this is that the virtio-net-device can't expose host > features to guest while using virtio-mmio. So the performance is low. > > The virtio-*-pci, virtio-*-s390, and virtio-*-ccw al

[Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends

2015-04-28 Thread shannon . zhao
From: Shannon Zhao The reason to do this is that the virtio-net-device can't expose host features to guest while using virtio-mmio. So the performance is low. The virtio-*-pci, virtio-*-s390, and virtio-*-ccw already have the ability to forward property accesses to the backend child, by calling