Re: [Qemu-devel] [PATCH v2 06/23] target-arm: add arm_is_secure() function

2014-05-15 Thread Aggeler Fabian
The v8 ARM ARM only leaves it as implementation defined when EL2 is not implemented, otherwise is has only a non-secure state as Peter said. Another reason why I chose to make the default non-secure is the suggested mapping of non-secure Aarch32 registers to EL1 and secure Aarch32 registers to E

Re: [Qemu-devel] [PATCH v2 06/23] target-arm: add arm_is_secure() function

2014-05-14 Thread Greg Bellows
Thanks for the input Peter. >From briefly looking, it actually looks like the ARMv7 spec more strictly states that the default is secure. ARMv8 on the other hand appears to leave it open as implementation defined, Based on out past discussions, I assumed non-secure as the default and that appear

Re: [Qemu-devel] [PATCH v2 06/23] target-arm: add arm_is_secure() function

2014-05-14 Thread Peter Maydell
On 14 May 2014 21:22, Greg Bellows wrote: > I suppose it depends on how true we want to be to the specification and > whether our default is NS=0 or NS=1 when the security extension is present > or not. The code currently assumes non-secure as the default state. The v8 ARM ARM at least allows th

Re: [Qemu-devel] [PATCH v2 06/23] target-arm: add arm_is_secure() function

2014-05-14 Thread Greg Bellows
I suppose it depends on how true we want to be to the specification and whether our default is NS=0 or NS=1 when the security extension is present or not. The code currently assumes non-secure as the default state. Is there a convention in qemu? How closely do we attempt to stay to the pseudo co

Re: [Qemu-devel] [PATCH v2 06/23] target-arm: add arm_is_secure() function

2014-05-14 Thread Fedorov Sergey
14.05.2014 18:42, Greg Bellows пишет: > On 14 May 2014 00:53, Sergey Fedorov wrote: > >> On 13.05.2014 20:15, Fabian Aggeler wrote: >>> arm_is_secure() function allows to determine CPU security state >>> if the CPU implements Security Extensions. >>> >>> Signed-off-by: Sergey Fedorov >>> Signed-

Re: [Qemu-devel] [PATCH v2 06/23] target-arm: add arm_is_secure() function

2014-05-14 Thread Greg Bellows
On 14 May 2014 00:53, Sergey Fedorov wrote: > On 13.05.2014 20:15, Fabian Aggeler wrote: > > arm_is_secure() function allows to determine CPU security state > > if the CPU implements Security Extensions. > > > > Signed-off-by: Sergey Fedorov > > Signed-off-by: Fabian Aggeler > > --- > > target

Re: [Qemu-devel] [PATCH v2 06/23] target-arm: add arm_is_secure() function

2014-05-13 Thread Sergey Fedorov
On 13.05.2014 20:15, Fabian Aggeler wrote: > arm_is_secure() function allows to determine CPU security state > if the CPU implements Security Extensions. > > Signed-off-by: Sergey Fedorov > Signed-off-by: Fabian Aggeler > --- > target-arm/cpu.h | 15 +++ > 1 file changed, 15 insertio

[Qemu-devel] [PATCH v2 06/23] target-arm: add arm_is_secure() function

2014-05-13 Thread Fabian Aggeler
arm_is_secure() function allows to determine CPU security state if the CPU implements Security Extensions. Signed-off-by: Sergey Fedorov Signed-off-by: Fabian Aggeler --- target-arm/cpu.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/target-arm/cpu.h b/target-arm/cpu.h in